Staging: comedi: drivers: fix space coding style issue in s626.c

PATCH In review jitendra kumar khasdev 3 participants 3 messages Dec 29, 2014 – Jan 10, 2015 Staging

lore

Share & tools

lore

jitendra kumar khasdev

author

2014-12-29 09:13 UTC #0 lore raw

PATCH 1/1 Staging: comedi: drivers: fix space coding style issue in s626.c

This is a patch to the s626.c file that fixes up a space error found by the checkpatch.pl tool

Signed-off-by Jitendra Kumar Khasdev <[email protected]>

---
 drivers/staging/comedi/drivers/s626.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/comedi/drivers/s626.c +1 -1

index 14932c5..fc497dd 100644
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
 static void s626_mc_disable(struct comedi_device *dev,
 			    unsigned int cmd, unsigned int reg)
 {
-	writel(cmd << 16 , dev->mmio + reg);
+	writel(cmd << 16, dev->mmio + reg);
 	mmiowb();
 }

Signature · 1 line

1.9.1

Ian Abbott

Reviewed-by on v1 1/1

2014-12-30 22:19 UTC #1 lore raw

Quoted 13 lines · jitendra kumar khasdev

This is a patch to the s626.c file that fixes up a space error found by the checkpatch.pl tool
Signed-off-by Jitendra Kumar Khasdev <[email protected]>
---
  drivers/staging/comedi/drivers/s626.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/s626.c +0 -0
index 14932c5..fc497dd 100644

drivers/staging/comedi/drivers/s626.c static void s626_mc_enable(struct comedi_device *dev, · line 123

Quoted 7 lines

drivers/staging/comedi/drivers/s626.c +1 -1

@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
  static void s626_mc_disable(struct comedi_device *dev,
  			    unsigned int cmd, unsigned int reg)
  {
-	writel(cmd << 16 , dev->mmio + reg);
+	writel(cmd << 16, dev->mmio + reg);
  	mmiowb();
  }

Presumably this is PATCH 1/2?

Reviewed-by Ian Abbott <[email protected]>

Signature · 2 lines

-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Greg KH

maintainer

2015-01-10 01:00 UTC #2 lore raw

In reply to jitendra kumar khasdev

Quoted 24 lines · jitendra kumar khasdev

This is a patch to the s626.c file that fixes up a space error found by the checkpatch.pl tool
Signed-off-by Jitendra Kumar Khasdev <[email protected]>
Reviewed-by Ian Abbott <[email protected]>
---
 drivers/staging/comedi/drivers/s626.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/s626.c +1 -1
index 14932c5..fc497dd 100644
@@ -118,7 +118,7 @@ static void s626_mc_enable(struct comedi_device *dev,
 static void s626_mc_disable(struct comedi_device *dev,
 			    unsigned int cmd, unsigned int reg)
 {
-	writel(cmd << 16 , dev->mmio + reg);
+	writel(cmd << 16, dev->mmio + reg);
 	mmiowb();
 }
 
Signature · 1 line
1.9.1

Someone already sent this patch in before you :(