Skip to contentSkip to conversation

clk: Add more information to debug messages

PATCH New Sean Anderson 3 participants 5 messages Mar 20, 2020 – Sep 10, 2020 Common clk

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 clk: Add more information to debug messages

Some of the debug messages in the clock subsystem can be made more informative by adding the clock name or adding the explicit error.

---

 drivers/clk/clk-uclass.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/clk/clk-uclass.c +13 -11
index 71878474eb..d44df05680 100644
@@ -237,8 +237,8 @@ static int clk_set_default_parents(struct udevice *dev, int stage)
 			continue;
 
 		if (ret < 0) {
-			debug("%s: failed to reparent clock %d for %s\n",
-			      __func__, index, dev_read_name(dev));
+			debug("%s: failed to reparent clock %d for %s (err = %d)\n",
+			      __func__, index, dev_read_name(dev), ret);
 			return ret;
 		}
 	}
@@ -295,8 +295,8 @@ static int clk_set_default_rates(struct udevice *dev, int stage)
 		ret = clk_set_rate(&clk, rates[index]);
 
 		if (ret < 0) {
-			debug("%s: failed to set rate on clock index %d (%ld) for %s\n",
-			      __func__, index, clk.id, dev_read_name(dev));
+			debug("%s: failed to set rate on clock index %d (%ld) for %s (err = %d)\n",
+			      __func__, index, clk.id, dev_read_name(dev), ret);
 			break;
 		}
 	}
@@ -436,7 +436,7 @@ ulong clk_get_rate(struct clk *clk)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -452,7 +452,7 @@ struct clk *clk_get_parent(struct clk *clk)
 	struct udevice *pdev;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return NULL;
 
@@ -469,7 +469,7 @@ long long clk_get_parent_rate(struct clk *clk)
 	const struct clk_ops *ops;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 
@@ -492,7 +492,8 @@ ulong clk_set_rate(struct clk *clk, ulong rate)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, rate=%lu)\n", __func__, clk, rate);
+	debug("%s(clk=%p \"%s\", rate=%lu)\n", __func__, clk, clk->dev->name,
+	      rate);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -507,7 +508,8 @@ int clk_set_parent(struct clk *clk, struct clk *parent)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, parent=%p)\n", __func__, clk, parent);
+	debug("%s(clk=%p \"%s\", parent=%p \"%s\")\n", __func__, clk,
+	      clk->dev->name, parent, parent->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -524,7 +526,7 @@ int clk_enable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -584,7 +586,7 @@ int clk_disable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/1 clk: Add more information to debug messages

Quoted 98 lines · On Fri, 20 Mar 2020 01:53:16 -0400 Sean Anderson <[email protected]> wrote:

Some of the debug messages in the clock subsystem can be made more informative by adding the clock name or adding the explicit error.

---

 drivers/clk/clk-uclass.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/clk/clk-uclass.c +2 -2
index 71878474eb..d44df05680 100644
@@ -237,8 +237,8 @@ static int clk_set_default_parents(struct udevice
 *dev, int stage) continue;
 
 		if (ret < 0) {
-			debug("%s: failed to reparent clock %d for
 %s\n",
-			      __func__, index, dev_read_name(dev));
+			debug("%s: failed to reparent clock %d for
 %s (err = %d)\n",
+			      __func__, index, dev_read_name(dev),
 ret); return ret;
drivers/clk/clk-uclass.c +2 -2
 		}
 	}
@@ -295,8 +295,8 @@ static int clk_set_default_rates(struct udevice
 *dev, int stage) ret = clk_set_rate(&clk, rates[index]);
 
 		if (ret < 0) {
-			debug("%s: failed to set rate on clock index
 %d (%ld) for %s\n",
-			      __func__, index, clk.id,
 dev_read_name(dev));
+			debug("%s: failed to set rate on clock index
 %d (%ld) for %s (err = %d)\n",
+			      __func__, index, clk.id,

dev_read_name(dev), ret); break;

drivers/clk/clk-uclass.c +5 -4
 		}
 	}
@@ -436,7 +436,7 @@ ulong clk_get_rate(struct clk *clk)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -452,7 +452,7 @@ struct clk *clk_get_parent(struct clk *clk)
 	struct udevice *pdev;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return NULL;
 
@@ -469,7 +469,7 @@ long long clk_get_parent_rate(struct clk *clk)
 	const struct clk_ops *ops;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 
@@ -492,7 +492,8 @@ ulong clk_set_rate(struct clk *clk, ulong rate)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, rate=%lu)\n", __func__, clk, rate);
+	debug("%s(clk=%p \"%s\", rate=%lu)\n", __func__, clk,
 clk->dev->name,
+	      rate);
 	if (!clk_valid(clk))
 		return 0;
drivers/clk/clk-uclass.c +3 -2
 	ops = clk_dev_ops(clk->dev);
@@ -507,7 +508,8 @@ int clk_set_parent(struct clk *clk, struct clk
 *parent) {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, parent=%p)\n", __func__, clk, parent);
+	debug("%s(clk=%p \"%s\", parent=%p \"%s\")\n", __func__, clk,
+	      clk->dev->name, parent, parent->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -524,7 +526,7 @@ int clk_enable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);

drivers/clk/clk-uclass.c int clk_disable(struct clk *clk) · line 592

Quoted 8 lines
drivers/clk/clk-uclass.c +1 -1
@@ -584,7 +586,7 @@ int clk_disable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200320/2d932705/attachment.sig>

#2 lore raw

PATCH 1/1 clk: Add more information to debug messages

Quoted 113 lines · Lukasz Majewski
Quoted 98 lines · On Fri, 20 Mar 2020 01:53:16 -0400 Sean Anderson <[email protected]> wrote:

Some of the debug messages in the clock subsystem can be made more informative by adding the clock name or adding the explicit error.

---

 drivers/clk/clk-uclass.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/clk/clk-uclass.c +2 -2
index 71878474eb..d44df05680 100644
@@ -237,8 +237,8 @@ static int clk_set_default_parents(struct udevice
 *dev, int stage) continue;
 
 		if (ret < 0) {
-			debug("%s: failed to reparent clock %d for
 %s\n",
-			      __func__, index, dev_read_name(dev));
+			debug("%s: failed to reparent clock %d for
 %s (err = %d)\n",
+			      __func__, index, dev_read_name(dev),
 ret); return ret;
drivers/clk/clk-uclass.c +2 -2
 		}
 	}
@@ -295,8 +295,8 @@ static int clk_set_default_rates(struct udevice
 *dev, int stage) ret = clk_set_rate(&clk, rates[index]);
 
 		if (ret < 0) {
-			debug("%s: failed to set rate on clock index
 %d (%ld) for %s\n",
-			      __func__, index, clk.id,
 dev_read_name(dev));
+			debug("%s: failed to set rate on clock index
 %d (%ld) for %s (err = %d)\n",
+			      __func__, index, clk.id,

dev_read_name(dev), ret); break;

drivers/clk/clk-uclass.c +5 -4
 		}
 	}
@@ -436,7 +436,7 @@ ulong clk_get_rate(struct clk *clk)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -452,7 +452,7 @@ struct clk *clk_get_parent(struct clk *clk)
 	struct udevice *pdev;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return NULL;
 
@@ -469,7 +469,7 @@ long long clk_get_parent_rate(struct clk *clk)
 	const struct clk_ops *ops;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 
@@ -492,7 +492,8 @@ ulong clk_set_rate(struct clk *clk, ulong rate)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, rate=%lu)\n", __func__, clk, rate);
+	debug("%s(clk=%p \"%s\", rate=%lu)\n", __func__, clk,
 clk->dev->name,
+	      rate);
 	if (!clk_valid(clk))
 		return 0;
drivers/clk/clk-uclass.c +3 -2
 	ops = clk_dev_ops(clk->dev);
@@ -507,7 +508,8 @@ int clk_set_parent(struct clk *clk, struct clk
 *parent) {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, parent=%p)\n", __func__, clk, parent);
+	debug("%s(clk=%p \"%s\", parent=%p \"%s\")\n", __func__, clk,
+	      clk->dev->name, parent, parent->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -524,7 +526,7 @@ int clk_enable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);

drivers/clk/clk-uclass.c int clk_disable(struct clk *clk) · line 592

Quoted 8 lines
drivers/clk/clk-uclass.c +1 -1
@@ -584,7 +586,7 @@ int clk_disable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
Quoted 3 lines

Best regards,

Lukasz Majewski

*bump*

Is anything going to come of this?

--Sean

#3 lore raw

PATCH 1/1 clk: Add more information to debug messages

Quoted 114 lines · Sean Anderson
Quoted 113 lines · Lukasz Majewski
Quoted 98 lines · On Fri, 20 Mar 2020 01:53:16 -0400 Sean Anderson <[email protected]> wrote:

Some of the debug messages in the clock subsystem can be made more informative by adding the clock name or adding the explicit error.

---

 drivers/clk/clk-uclass.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)
drivers/clk/clk-uclass.c +2 -2
index 71878474eb..d44df05680 100644
@@ -237,8 +237,8 @@ static int clk_set_default_parents(struct udevice
 *dev, int stage) continue;
 
 		if (ret < 0) {
-			debug("%s: failed to reparent clock %d for
 %s\n",
-			      __func__, index, dev_read_name(dev));
+			debug("%s: failed to reparent clock %d for
 %s (err = %d)\n",
+			      __func__, index, dev_read_name(dev),
 ret); return ret;
drivers/clk/clk-uclass.c +2 -2
 		}
 	}
@@ -295,8 +295,8 @@ static int clk_set_default_rates(struct udevice
 *dev, int stage) ret = clk_set_rate(&clk, rates[index]);
 
 		if (ret < 0) {
-			debug("%s: failed to set rate on clock index
 %d (%ld) for %s\n",
-			      __func__, index, clk.id,
 dev_read_name(dev));
+			debug("%s: failed to set rate on clock index
 %d (%ld) for %s (err = %d)\n",
+			      __func__, index, clk.id,

dev_read_name(dev), ret); break;

drivers/clk/clk-uclass.c +5 -4
 		}
 	}
@@ -436,7 +436,7 @@ ulong clk_get_rate(struct clk *clk)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -452,7 +452,7 @@ struct clk *clk_get_parent(struct clk *clk)
 	struct udevice *pdev;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return NULL;
 
@@ -469,7 +469,7 @@ long long clk_get_parent_rate(struct clk *clk)
 	const struct clk_ops *ops;
 	struct clk *pclk;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 
@@ -492,7 +492,8 @@ ulong clk_set_rate(struct clk *clk, ulong rate)
 {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, rate=%lu)\n", __func__, clk, rate);
+	debug("%s(clk=%p \"%s\", rate=%lu)\n", __func__, clk,
 clk->dev->name,
+	      rate);
 	if (!clk_valid(clk))
 		return 0;
drivers/clk/clk-uclass.c +3 -2
 	ops = clk_dev_ops(clk->dev);
@@ -507,7 +508,8 @@ int clk_set_parent(struct clk *clk, struct clk
 *parent) {
 	const struct clk_ops *ops;
 
-	debug("%s(clk=%p, parent=%p)\n", __func__, clk, parent);
+	debug("%s(clk=%p \"%s\", parent=%p \"%s\")\n", __func__, clk,
+	      clk->dev->name, parent, parent->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
@@ -524,7 +526,7 @@ int clk_enable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p \"%s\")\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);

drivers/clk/clk-uclass.c int clk_disable(struct clk *clk) · line 592

Quoted 8 lines
drivers/clk/clk-uclass.c +1 -1
@@ -584,7 +586,7 @@ int clk_disable(struct clk *clk)
 	struct clk *clkp = NULL;
 	int ret;
 
-	debug("%s(clk=%p)\n", __func__, clk);
+	debug("%s(clk=%p) \"%s\"\n", __func__, clk, clk->dev->name);
 	if (!clk_valid(clk))
 		return 0;
 	ops = clk_dev_ops(clk->dev);
Quoted 7 lines
Quoted 3 lines

Best regards,

Lukasz Majewski

*bump*

Is anything going to come of this?

Second *bump*. It looks like this is not going to end up in the clock tree. Can anyone else pick this up? Thanks.

--Sean

#4 lore raw

PATCH 1/1 clk: Add more information to debug messages

Quoted 9 lines · Sean Anderson
Quoted 7 lines · Sean Anderson
Quoted 6 lines · Lukasz Majewski
Quoted 3 lines · On Fri, 20 Mar 2020 01:53:16 -0400 Sean Anderson <[email protected]> wrote:

Some of the debug messages in the clock subsystem can be made more informative by adding the clock name or adding the explicit error.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

---

 drivers/clk/clk-uclass.c | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)