: ixgbevf: Allow querying VFs RSS indirection table and key
Subsystems (3)
v2 cover : ixgbevf: Allow querying VFs RSS indirection table and key
Add the ethtool ops to VF driver to allow querying the RSS indirection table and RSS Random Key.
- PF driver: Add new VF-PF channel commands.
- VF driver: Utilize these new commands and add the corresponding ethtool callbacks.
New in v2:
- Added a detailed description to patches 4 and 5.
New in v1 (compared to RFC):
- Use "if-else" statement instead of a "switch-case" for a single option case. More specifically: in cases where the newly added API version is the only one allowed. We may consider using a "switch-case" back again when the list of allowed API versions in these specific places grows up.
Vlad Zolotarov (5):
ixgbe: Add a RETA query command to VF-PF channel API
ixgbevf: Add a RETA query code
ixgbe: Add GET_RSS_KEY command to VF-PF channel commands set
ixgbevf: Add RSS Key query code
ixgbevf: Add the appropriate ethtool ops to query RSS indirection
table and key
drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 8 ++ drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 52 ++++++++++ drivers/net/ethernet/intel/ixgbevf/ethtool.c | 37 +++++++ drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 +- drivers/net/ethernet/intel/ixgbevf/mbx.h | 8 ++ drivers/net/ethernet/intel/ixgbevf/vf.c | 117 ++++++++++++++++++++++ drivers/net/ethernet/intel/ixgbevf/vf.h | 2 + 7 files changed, 227 insertions(+), 1 deletion(-)
Signature · 1 line
2.1.0
PATCH v2 1/5 ixgbe: Add a RETA query command to VF-PF channel API
82599 VFs and PF share the same RSS redirection table (RETA). Therefore we just return it for all VFs.
RETA table is an array of 32 registers and the maximum number of registers that may be delivered in a single VF-PF channel command is 15. Therefore we will deliver the whole table in 3 steps: 12, 12 and 8 registers in each step correspondingly. Thus this patch does the following:
- Adds a new API version (to specify a new commands set).
- Adds the IXGBE_VF_GET_RETA_[0,1,2] commands to the VF-PF commands set.
---
New in v1 (compared to RFC):
- Use "if-else" statement instead of a "switch-case" for a single option case
(in ixgbe_get_vf_reta()). --- drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 6 +++++ drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 31 ++++++++++++++++++++++++++ 2 files changed, 37 insertions(+)
drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h +6 -0
@@ -73,6 +73,7 @@ enum ixgbe_pfvf_api_rev { ixgbe_mbox_api_10,/* API version 1.0, linux/freebsd VF driver */ ixgbe_mbox_api_20,/* API version 2.0, solaris Phase1 VF driver */ ixgbe_mbox_api_11,/* API version 1.1, linux/freebsd VF driver */ + ixgbe_mbox_api_12,/* API version 1.2, linux/freebsd VF driver */ /* This value should always be last */ ixgbe_mbox_api_unknown, /* indicates that API version is not known */ };
@@ -91,6 +92,11 @@ enum ixgbe_pfvf_api_rev {/* mailbox API, version 1.1 VF requests */ #define IXGBE_VF_GET_QUEUES 0x09/* get queue configuration */ +/* mailbox API, version 1.2 VF requests */ +#define IXGBE_VF_GET_RETA_0 0x0a/* get RETA[0..11] */ +#define IXGBE_VF_GET_RETA_1 0x0b/* get RETA[12..23] */ +#define IXGBE_VF_GET_RETA_2 0x0c/* get RETA[24..31] */ +/* GET_QUEUES return data indices within the mailbox */ #define IXGBE_VF_TX_QUEUES 1/* number of Tx queues supported */ #define IXGBE_VF_RX_QUEUES 2/* number of Rx queues supported */
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +31 -0
@@ -427,6 +427,7 @@ static s32 ixgbe_set_vf_lpe(struct ixgbe_adapter *adapter, u32 *msgbuf, u32 vf)#endif /* CONFIG_FCOE */ switch (adapter->vfinfo[vf].vf_api) {case ixgbe_mbox_api_11: +case ixgbe_mbox_api_12:/* * Version 1.1 supports jumbo frames on VFs if PF has * jumbo frames enabled which means legacy VFs are
@@ -894,6 +895,7 @@ static int ixgbe_negotiate_vf_api(struct ixgbe_adapter *adapter,switch (api) {case ixgbe_mbox_api_10:case ixgbe_mbox_api_11: +case ixgbe_mbox_api_12: adapter->vfinfo[vf].vf_api = api;return 0 ;default :
@@ -917,6 +919,7 @@ static int ixgbe_get_vf_queues(struct ixgbe_adapter *adapter,switch (adapter->vfinfo[vf].vf_api) {case ixgbe_mbox_api_20:case ixgbe_mbox_api_11: +case ixgbe_mbox_api_12:break ;default :return -1 ;
@@ -944,6 +947,25 @@ static int ixgbe_get_vf_queues(struct ixgbe_adapter *adapter,return 0 ; } +static int ixgbe_get_vf_reta (struct ixgbe_adapter *adapter, +u32 *msgbuf,u32 vf,int reta_offset_dw, +size_t dwords) +{ +struct ixgbe_hw *hw = &adapter->hw; +int i; +u32 *reta = &msgbuf[1 ]; + +/* verify the PF is supporting the correct API */ +if (adapter->vfinfo[vf].vf_api != ixgbe_mbox_api_12) +return -EPERM ; + +/* Read the appropriate portion of RETA */ +for (i =0 ; i < dwords; i++) + reta[i] =IXGBE_READ_REG (hw,IXGBE_RETA (i + reta_offset_dw)); + +return 0 ; +} +static int ixgbe_rcv_msg_from_vf (struct ixgbe_adapter *adapter,u32 vf) {u32 mbx_size =IXGBE_VFMAILBOX_SIZE ;
@@ -1000,6 +1022,15 @@ static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf)case IXGBE_VF_GET_QUEUES : retval =ixgbe_get_vf_queues (adapter, msgbuf, vf);break ; +case IXGBE_VF_GET_RETA_0 : + retval =ixgbe_get_vf_reta (adapter, msgbuf, vf,0 ,12 ); +break ; +case IXGBE_VF_GET_RETA_1 : + retval =ixgbe_get_vf_reta (adapter, msgbuf, vf,12 ,12 ); +break ; +case IXGBE_VF_GET_RETA_2 : + retval =ixgbe_get_vf_reta (adapter, msgbuf, vf,24 ,8 ); +break ;default :e_err (drv,"Unhandled Msg %8.8x\n" , msgbuf[0 ]); retval =IXGBE_ERR_MBX ;
Signature · 1 line
2.1.0
PATCH v2 2/5 ixgbevf: Add a RETA query code
In reply to Vlad Zolotarov - Added a new API version support.
- Added the query implementation in the ixgbevf.
---
New in v1 (compared to RFC):
- Use "if-else" statement instead of a "switch-case" for a single option case
(in ixgbevf_get_reta()). --- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 +- drivers/net/ethernet/intel/ixgbevf/mbx.h | 6 ++ drivers/net/ethernet/intel/ixgbevf/vf.c | 73 +++++++++++++++++++++++ drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + 4 files changed, 83 insertions(+), 1 deletion(-)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +3 -1
@@ -1880,7 +1880,8 @@ static void ixgbevf_init_last_counter_stats(struct ixgbevf_adapter *adapter)static void ixgbevf_negotiate_api (struct ixgbevf_adapter *adapter) {struct ixgbe_hw *hw = &adapter->hw; -int api[] = { ixgbe_mbox_api_11, +int api[] = { ixgbe_mbox_api_12, + ixgbe_mbox_api_11, ixgbe_mbox_api_10, ixgbe_mbox_api_unknown };int err =0 , idx =0 ;
@@ -3525,6 +3526,7 @@ static int ixgbevf_change_mtu(struct net_device *netdev, int new_mtu)switch (adapter->hw.api_version) {case ixgbe_mbox_api_11: +case ixgbe_mbox_api_12: max_possible_frame =IXGBE_MAX_JUMBO_FRAME_SIZE ;break ;default :
drivers/net/ethernet/intel/ixgbevf/mbx.h +6 -0
@@ -86,6 +86,7 @@ enum ixgbe_pfvf_api_rev { ixgbe_mbox_api_10,/* API version 1.0, linux/freebsd VF driver */ ixgbe_mbox_api_20,/* API version 2.0, solaris Phase1 VF driver */ ixgbe_mbox_api_11,/* API version 1.1, linux/freebsd VF driver */ + ixgbe_mbox_api_12,/* API version 1.2, linux/freebsd VF driver */ /* This value should always be last */ ixgbe_mbox_api_unknown, /* indicates that API version is not known */ };
@@ -104,6 +105,11 @@ enum ixgbe_pfvf_api_rev {/* mailbox API, version 1.1 VF requests */ #define IXGBE_VF_GET_QUEUE 0x09/* get queue configuration */ +/* mailbox API, version 1.2 VF requests */ +#define IXGBE_VF_GET_RETA_0 0x0a/* get RETA[0..11] */ +#define IXGBE_VF_GET_RETA_1 0x0b/* get RETA[12..23] */ +#define IXGBE_VF_GET_RETA_2 0x0c/* get RETA[24..31] */ +/* GET_QUEUES return data indices within the mailbox */ #define IXGBE_VF_TX_QUEUES 1/* number of Tx queues supported */ #define IXGBE_VF_RX_QUEUES 2/* number of Rx queues supported */
drivers/net/ethernet/intel/ixgbevf/vf.c +73 -0
85 lines not on this page · raw message
drivers/net/ethernet/intel/ixgbevf/vf.h +1 -0
@@ -208,5 +208,6 @@ void ixgbevf_rlpml_set_vf(struct ixgbe_hw *hw, u16 max_size);int ixgbevf_negotiate_api_version (struct ixgbe_hw *hw,int api);int ixgbevf_get_queues (struct ixgbe_hw *hw,unsigned int *num_tcs,unsigned int *default_tc); +int ixgbevf_get_reta (struct ixgbe_hw *hw,u32 *reta);#endif /* __IXGBE_VF_H__ */
Signature · 1 line
2.1.0
PATCH v2 3/5 ixgbe: Add GET_RSS_KEY command to VF-PF channel commands set
In reply to Vlad Zolotarov82599 VFs and PF share the same RSS Key. Therefore we will return the same RSS key for all VFs.
---
New in v1 (compared to RFC):
- Use "if-else" statement instead of a "switch-case" for a single option case
(in ixgbe_get_vf_rss_key()). --- drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h | 2 ++ drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 21 +++++++++++++++++++++ 2 files changed, 23 insertions(+)
drivers/net/ethernet/intel/ixgbe/ixgbe_mbx.h +2 -0
@@ -97,6 +97,8 @@ enum ixgbe_pfvf_api_rev {#define IXGBE_VF_GET_RETA_1 0x0b/* get RETA[12..23] */ #define IXGBE_VF_GET_RETA_2 0x0c/* get RETA[24..31] */ +#define IXGBE_VF_GET_RSS_KEY 0x0d/* get RSS key */ +/* GET_QUEUES return data indices within the mailbox */ #define IXGBE_VF_TX_QUEUES 1/* number of Tx queues supported */ #define IXGBE_VF_RX_QUEUES 2/* number of Rx queues supported */
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c +21 -0
@@ -966,6 +966,24 @@ static int ixgbe_get_vf_reta(struct ixgbe_adapter *adapter,return 0 ; } +static int ixgbe_get_vf_rss_key (struct ixgbe_adapter *adapter, +u32 *msgbuf,u32 vf) +{ +struct ixgbe_hw *hw = &adapter->hw; +int i; +u32 *rss_key = &msgbuf[1 ]; + +/* verify the PF is supporting the correct API */ +if (adapter->vfinfo[vf].vf_api != ixgbe_mbox_api_12) +return -EPERM ; + +/* Read the RSS KEY */ +for (i =0 ; i <10 ; i++) + rss_key[i] =IXGBE_READ_REG (hw,IXGBE_RSSRK (i)); + +return 0 ; +} +static int ixgbe_rcv_msg_from_vf (struct ixgbe_adapter *adapter,u32 vf) {u32 mbx_size =IXGBE_VFMAILBOX_SIZE ;
@@ -1031,6 +1049,9 @@ static int ixgbe_rcv_msg_from_vf(struct ixgbe_adapter *adapter, u32 vf)case IXGBE_VF_GET_RETA_2 : retval =ixgbe_get_vf_reta (adapter, msgbuf, vf,24 ,8 );break ; +case IXGBE_VF_GET_RSS_KEY : + retval =ixgbe_get_vf_rss_key (adapter, msgbuf, vf); +break ;default :e_err (drv,"Unhandled Msg %8.8x\n" , msgbuf[0 ]); retval =IXGBE_ERR_MBX ;
Signature · 1 line
2.1.0
PATCH v2 4/5 ixgbevf: Add RSS Key query code
In reply to Vlad ZolotarovAdd the ixgbevf_get_rss_key() function that queries the PF for an RSS Random Key using a new VF-PF channel IXGBE_VF_GET_RSS_KEY command.
---
New in v2:
- Added a more detailed patch description.
New in v1 (compared to RFC):
- Use "if-else" statement instead of a "switch-case" for a single option case
(in ixgbevf_get_rss_key()). --- drivers/net/ethernet/intel/ixgbevf/mbx.h | 2 ++ drivers/net/ethernet/intel/ixgbevf/vf.c | 44 ++++++++++++++++++++++++++++++++ drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + 3 files changed, 47 insertions(+)
drivers/net/ethernet/intel/ixgbevf/mbx.h +2 -0
@@ -110,6 +110,8 @@ enum ixgbe_pfvf_api_rev {#define IXGBE_VF_GET_RETA_1 0x0b/* get RETA[12..23] */ #define IXGBE_VF_GET_RETA_2 0x0c/* get RETA[24..31] */ +#define IXGBE_VF_GET_RSS_KEY 0x0d/* get RSS hash key */ +/* GET_QUEUES return data indices within the mailbox */ #define IXGBE_VF_TX_QUEUES 1/* number of Tx queues supported */ #define IXGBE_VF_RX_QUEUES 2/* number of Rx queues supported */
drivers/net/ethernet/intel/ixgbevf/vf.c +44 -0
50 lines not on this page · raw message
drivers/net/ethernet/intel/ixgbevf/vf.h +1 -0
@@ -209,5 +209,6 @@ int ixgbevf_negotiate_api_version(struct ixgbe_hw *hw, int api);int ixgbevf_get_queues (struct ixgbe_hw *hw,unsigned int *num_tcs,unsigned int *default_tc);int ixgbevf_get_reta (struct ixgbe_hw *hw,u32 *reta); +int ixgbevf_get_rss_key (struct ixgbe_hw *hw,u8 *rss_key);#endif /* __IXGBE_VF_H__ */
Signature · 1 line
2.1.0
PATCH v2 5/5 ixgbevf: Add the appropriate ethtool ops to query RSS indirection table and key
In reply to Vlad ZolotarovAdded get_rxfh_indir_size, get_rxfh_key_size and get_rxfh ethtool_ops callbacks implementations.
This enables the ethtool's "-x" and "-n rx-flow-hash" options for 82599 VF devices.
---
New in v2:
- Added a detailed description to the patch.
--- drivers/net/ethernet/intel/ixgbevf/ethtool.c | 37 ++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+)
drivers/net/ethernet/intel/ixgbevf/ethtool.c +37 -0
@@ -792,6 +792,40 @@ static int ixgbevf_set_coalesce(struct net_device *netdev,return 0 ; } +static u32 ixgbevf_get_rxfh_indir_size (struct net_device *netdev) +{ +return 128 ; +} + +static u32 ixgbevf_get_rxfh_key_size (struct net_device *netdev) +{ +return 40 ; +} + +static int ixgbevf_get_rxfh (struct net_device *netdev,u32 *indir,u8 *key, +u8 *hfunc) +{ +struct ixgbevf_adapter *adapter =netdev_priv (netdev); +int err; + +if (hfunc) + *hfunc =ETH_RSS_HASH_TOP ; + +if (indir) { + err =ixgbevf_get_reta (&adapter->hw, indir); +if (err) +return err; + } + +if (key) { + err =ixgbevf_get_rss_key (&adapter->hw, key); +if (err) +return err; + } + +return 0 ; +} +static const struct ethtool_ops ixgbevf_ethtool_ops = { .get_settings = ixgbevf_get_settings, .get_drvinfo = ixgbevf_get_drvinfo,
@@ -809,6 +843,9 @@ static const struct ethtool_ops ixgbevf_ethtool_ops = { .get_ethtool_stats = ixgbevf_get_ethtool_stats, .get_coalesce = ixgbevf_get_coalesce, .set_coalesce = ixgbevf_set_coalesce, + .get_rxfh_indir_size = ixgbevf_get_rxfh_indir_size, + .get_rxfh_key_size = ixgbevf_get_rxfh_key_size, + .get_rxfh = ixgbevf_get_rxfh, };void ixgbevf_set_ethtool_ops (struct net_device *netdev)
Signature · 1 line
2.1.0