Staging: comedi: fix line over 80 characters warning
PATCH 1/5 Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line over 80 character which is found by checkpatch tool.
--- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl812.c +2 -1
@@ -510,7 +510,8 @@ struct pcl812_private {unsigned char dma;/* >0 use dma ( usedDMA channel) */ unsigned char range_correction;/* =1 we must add 1 to range number */ unsigned int last_ai_chanspec; -unsigned char mode_reg_int;/* there is stored INT number for some card */ +unsigned char mode_reg_int;/* there is stored INT number +for some card */ unsigned int ai_poll_ptr;/* how many sampes transfer poll */ unsigned int dmapages;unsigned int hwdmasize;
Signature · 1 line
1.9.1
PATCH 2/5 Staging: comedi: fix line over 80 characters warning
This is patch to file pcl812.c that fix up warning line over 80 character which is found by checkpatch tool.
--- drivers/staging/comedi/drivers/pcl812.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl812.c +3 -1
@@ -519,7 +519,9 @@ struct pcl812_private {unsigned int hwdmaptr[2 ];/* HW PTR to DMA buf */ unsigned int dmabytestomove[2 ];/* how many bytes DMA transfer */ int next_dma_buf;/* which buffer is next to use */ -unsigned int dma_runs_to_end;/* how many times we must switch DMA buffers */ +unsigned int dma_runs_to_end;/* how many times we must switch +* DMA buffers +*/ unsigned int last_dma_run;/* how many bytes to transfer on last DMA buffer */ unsigned int max_812_ai_mode0_rangewait;/* setling time for gain */ unsigned int divisor1;
Signature · 1 line
1.9.1
PATCH 3/5 Staging: comedi: fix line over 80 characters warning
In reply to jitendra kumar khasdevThis is patch to file pcl812.c that fix up warning line over 80 character which is found by checkpatch tool.
--- drivers/staging/comedi/drivers/pcl812.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl812.c +3 -1
@@ -522,7 +522,9 @@ struct pcl812_private {unsigned int dma_runs_to_end;/* how many times we must switch * DMA buffers */ -unsigned int last_dma_run;/* how many bytes to transfer on last DMA buffer */ +unsigned int last_dma_run;/* how many bytes to transfer on last +* DMA buffer +*/ unsigned int max_812_ai_mode0_rangewait;/* setling time for gain */ unsigned int divisor1;unsigned int divisor2;
Signature · 1 line
1.9.1
PATCH 4/5 Staging: comedi: fix line over 80 characters warning
In reply to jitendra kumar khasdevThis is patch to file pcl812.c that fix up warning line over 80 character which is found by checkpatch tool.
--- drivers/staging/comedi/drivers/pcl812.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl812.c +1 -1
@@ -525,7 +525,7 @@ struct pcl812_private {unsigned int last_dma_run;/* how many bytes to transfer on last * DMA buffer */ -unsigned int max_812_ai_mode0_rangewait;/* setling time for gain */ +unsigned int max_812_ai_mode0_rangewait;/* setling time for gain */ unsigned int divisor1;unsigned int divisor2; unsigned int use_diff:1;
Signature · 1 line
1.9.1
PATCH 5/5 Staging: comedi: fix line over 80 characters warning
In reply to jitendra kumar khasdevThis is patch to file pcl812.c that fix up warning line over 80 character which is found by checkpatch tool.
--- drivers/staging/comedi/drivers/pcl812.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl812.c +1 -1
@@ -1240,7 +1240,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)for (i =0 ; i <2 ; i++) {unsigned long dmabuf; - dmabuf =__get_dma_pages (GFP_KERNEL , devpriv->dmapages); + dmabuf =__get_dma_pages (GFP_KERNEL , devpriv->dmapages);if (!dmabuf)return -ENOMEM ;
Signature · 1 line
1.9.1
Quoted 4 lines · jitendra kumar khasdev
This is patch to file
pcl812.cthat fix up warning line over 80 character which is found by checkpatch tool.Signed-off-by Jitendra Kumar Khasdev <[email protected]>
I am assuming this one you wanted to make as v3.
but why you are sending different patches to do the same type of change in comedi?
usually we send different patches to do different types of change, but for the same type of change it can be a single patch.
sudip
Quoted 26 lines
--- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/staging/comedi/drivers/pcl812.c +2
-1@@ -510,7 +510,8 @@ struct pcl812_private {unsigned char dma;/* >0 use dma ( usedDMA channel) */ unsigned char range_correction;/* =1 we must add 1 to range number */ unsigned int last_ai_chanspec; -unsigned char mode_reg_int;/* there is stored INT number for some card */ +unsigned char mode_reg_int;/* there is stored INT number +for some card */ unsigned int ai_poll_ptr;/* how many sampes transfer poll */ unsigned int dmapages;unsigned int hwdmasize;Signature · 7 lines
1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Greg KH
maintainerQuoted 7 lines · jitendra kumar khasdev
This is patch to file
pcl812.cthat fix up warning line over 80 character which is found by checkpatch tool.Signed-off-by Jitendra Kumar Khasdev <[email protected]>--- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
There are 5 patches here all with the identical subject line, which I can't accept for the obvious reason that they must be all doing the same exact thing, which would be pointless, right? :)
thanks,
greg k-h
Hello,
Will I have to resubmit by combining all 5 into 1 patch? Please give me suggestion so that I can do it in correct way.
Regards,
Jitendra
Regards,
Jitendra Kumar Khasdev,
CSE-Student | GGITM
[email protected]| Mo.8435260882
Quoted 17 lines · Greg KH
Quoted 7 lines · jitendra kumar khasdev
This is patch to file
pcl812.cthat fix up warning line over 80 character which is found by checkpatch tool.Signed-off-by Jitendra Kumar Khasdev <[email protected]>--- drivers/staging/comedi/drivers/pcl812.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)There are 5 patches here all with the identical subject line, which I can't accept for the obvious reason that they must be all doing the same exact thing, which would be pointless, right? :)
thanks,
greg k-h
Greg KH
maintainerA: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 3 lines · jitendra kumar khasdev
Hello,
Will I have to resubmit by combining all 5 into 1 patch? Please give me suggestion so that I can do it in correct way.
I don't know, I didn't read the patches, but if you do send a series of patches, they each have to be doing something different to make them different patches, right?
thanks,
greg k-h