staging: gdm724x: fix coding style issues
PATCH 1/1 staging: gdm724x: fix coding style issues
Signed-off-by Ning Zhou <[email protected]>
--- drivers/staging/gdm724x/gdm_lte.c | 3 ++- drivers/staging/gdm724x/gdm_mux.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)
drivers/staging/gdm724x/gdm_lte.c +2 -1
@@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type) icmp6_out.icmp6_type =NDISC_NEIGHBOUR_ADVERTISEMENT ; icmp6_out.icmp6_code =0 ; icmp6_out.icmp6_cksum =0 ; - icmp6_out.icmp6_dataun.un_data32[0 ] =htonl (0x60000000 );/* R=0, S=1, O=1 */ +/* R=0, S=1, O=1 */ + icmp6_out.icmp6_dataun.un_data32[0 ] =htonl (0x60000000 ); ns = (struct neighbour_solicitation *) (skb_in->data + mac_header_len +
drivers/staging/gdm724x/gdm_mux.c +1 -1
@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)static void do_rx (struct work_struct *work) {struct mux_dev *mux_dev = - container_of(work, struct mux_dev , work_rx.work); + container_of(work, struct mux_dev, work_rx.work);struct mux_rx *r;struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;unsigned long flags;
Signature · 1 line
1.9.1
Quoted 1 line · Ning Zhou
Signed-off-by Ning Zhou <[email protected]>
You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch shall address one category of stuff and seems that yours could be separated into two.
thanks,
konrad
Quoted 39 lines
--- drivers/staging/gdm724x/gdm_lte.c | 3 ++- drivers/staging/gdm724x/gdm_mux.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)drivers/staging/gdm724x/gdm_lte.c +2
-1@@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type) icmp6_out.icmp6_type =NDISC_NEIGHBOUR_ADVERTISEMENT ; icmp6_out.icmp6_code =0 ; icmp6_out.icmp6_cksum =0 ; - icmp6_out.icmp6_dataun.un_data32[0 ] =htonl (0x60000000 );/* R=0, S=1, O=1 */ +/* R=0, S=1, O=1 */ + icmp6_out.icmp6_dataun.un_data32[0 ] =htonl (0x60000000 ); ns = (struct neighbour_solicitation *) (skb_in->data + mac_header_len +drivers/staging/gdm724x/gdm_mux.c +1
-1@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)static void do_rx (struct work_struct *work) {struct mux_dev *mux_dev = - container_of(work, struct mux_dev , work_rx.work); + container_of(work, struct mux_dev, work_rx.work);struct mux_rx *r;struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;unsigned long flags;Signature · 6 lines
1.9.1 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
OK, then this one is abandoned. I will send two patches instead.
/Ning
Quoted 49 lines · Konrad Zapalowicz
Quoted 1 line · Ning Zhou
Signed-off-by Ning Zhou <[email protected]>You need to describe your changes, a vague subject is not enough. Also keep in mind that one patch shall address one category of stuff and seems that yours could be separated into two.
thanks,
konradQuoted 39 lines
--- drivers/staging/gdm724x/gdm_lte.c | 3 ++- drivers/staging/gdm724x/gdm_mux.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)drivers/staging/gdm724x/gdm_lte.c +2
-1@@ -281,7 +281,8 @@ static int gdm_lte_emulate_ndp(struct sk_buff *skb_in, u32 nic_type) icmp6_out.icmp6_type =NDISC_NEIGHBOUR_ADVERTISEMENT ; icmp6_out.icmp6_code =0 ; icmp6_out.icmp6_cksum =0 ; - icmp6_out.icmp6_dataun.un_data32[0 ] =htonl (0x60000000 );/* R=0, S=1, O=1 */ +/* R=0, S=1, O=1 */ + icmp6_out.icmp6_dataun.un_data32[0 ] =htonl (0x60000000 ); ns = (struct neighbour_solicitation *) (skb_in->data + mac_header_len +drivers/staging/gdm724x/gdm_mux.c +1
-1@@ -220,7 +220,7 @@ static int up_to_host(struct mux_rx *r)static void do_rx (struct work_struct *work) {struct mux_dev *mux_dev = - container_of(work, struct mux_dev , work_rx.work); + container_of(work, struct mux_dev, work_rx.work);struct mux_rx *r;struct rx_cxt *rx = (struct rx_cxt *)&mux_dev->rx;unsigned long flags;Signature · 6 lines
1.9.1 _______________________________________________ devel mailing list [email protected] http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel