sunxi: axp221: Fix using the wrong register address for ALDO2
PATCH 1/1 sunxi: axp221: Fix using the wrong register address for ALDO2
Hi Ian (et al),
Trivial patch fixing an important bug for the new sun6i / axp221 support in v2015.01, if someone can give me a quick ack, then I'll send a pull-req to Tom to get this included in v2015.01.
Thanks & Regards,
Hans
PATCH 1/1 sunxi: axp221: Fix using the wrong register address for ALDO2
This fixes us never programming ALDO2, and programming the ALDO2 voltage into ALDo1.
--- include/axp221.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/axp221.h +1 -1
@@ -43,7 +43,7 @@#define AXP221_DCDC4_CTRL 0x24#define AXP221_DCDC5_CTRL 0x25#define AXP221_ALDO1_CTRL 0x28 -#define AXP221_ALDO2_CTRL 0x28 +#define AXP221_ALDO2_CTRL 0x29#define AXP221_ALDO3_CTRL 0x2a#define AXP221_PAGE 0xff
Signature · 1 line
2.1.0
PATCH 1/1 sunxi: axp221: Fix using the wrong register address for ALDO2
Quoted 5 lines · Hans de Goede
This fixes us never programming ALDO2, and programming the ALDO2 voltage into ALDo1.
Reported-by Siarhei Siamashka <[email protected]>Signed-off-by Hans de Goede <[email protected]>
Quoted 17 lines
--- include/axp221.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/axp221.h +1
-1@@ -43,7 +43,7 @@#define AXP221_DCDC4_CTRL 0x24#define AXP221_DCDC5_CTRL 0x25#define AXP221_ALDO1_CTRL 0x28 -#define AXP221_ALDO2_CTRL 0x28 +#define AXP221_ALDO2_CTRL 0x29#define AXP221_ALDO3_CTRL 0x2a#define AXP221_PAGE 0xff
PATCH 1/1 sunxi: axp221: Fix using the wrong register address for ALDO2
Hi,
Quoted 8 lines · Ian Campbell
Quoted 5 lines · Hans de Goede
This fixes us never programming ALDO2, and programming the ALDO2 voltage into ALDo1.
Reported-by Siarhei Siamashka <[email protected]>Signed-off-by Hans de Goede <[email protected]>Acked-by Ian Campbell <[email protected]>
Thanks I've just send out a pull-req for v2015.01 with this fix in, I just realized I forgot to amend the commit message with your Acked-by though, ah well.
Regards,
Hans