Skip to contentSkip to conversation

drm/i915: Make sample_c messages go faster on Haswell.

PATCH Applied Kenneth Graunke 6 participants 11 messages Jan 1, 2015 – Jan 6, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: Make sample_c messages go faster on Haswell.

Haswell significantly improved the performance of sampler_c messages, but the optimization appears to be off by default. Later platforms remove this bit, and apparently always enable the optimization.

Improves performance in "Counter Strike: Global Offensive" by 18% at default settings on Iris Pro.

This may break sampling of paletted formats (P8/A8P8/P8A8). It's unclear whether it affects sampling of paletted formats in general, or just the sample_c message (which is never used).

While libva does have support for using paletted formats (primarily for OSDs), that support appears to have been broken for at least a year, so I couldn't observe a regression from this.

---
 drivers/gpu/drm/i915/i915_reg.h | 1 +
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 2 files changed, 5 insertions(+)

Resubmitting the patch to unconditionally enable this. I tried to get libva-intel to use paletted formats, and observe a regression...but the only thing I found that used it was mplayer's OSD (on screen display). Even without my patch, the colors were totally wrong with that, and it's according to a few distro wikis, that's been the case for over a year.

If libva's code for paletted formats /is/ broken, they could always add code to disable this bit using the command validator when fixing it.

Could we try merging this, and back it out if someone reports a regression? I haven't observed any problems. It's also been quite stable.

drivers/gpu/drm/i915/i915_reg.h +1 -0
index 40ca873..0f32fd1a 100644
@@ -6167,6 +6167,7 @@ enum punit_power_well {
 #define  HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE    (1 << 6)
 
 #define HALF_SLICE_CHICKEN3		0xe184
+#define   HSW_SAMPLE_C_PERFORMANCE	(1<<9)
 #define   GEN8_CENTROID_PIXEL_OPT_DIS	(1<<8)
 #define   GEN8_SAMPLER_POWER_BYPASS_DIS	(1<<1)
 
drivers/gpu/drm/i915/intel_pm.c +4 -0
index 7d99a9c..17e84dc 100644
@@ -5974,6 +5974,10 @@ static void haswell_init_clock_gating(struct drm_device *dev)
 	I915_WRITE(GEN7_GT_MODE,
 		   _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4));
 
+	/* Make sample_c messages faster. */
+	I915_WRITE(HALF_SLICE_CHICKEN3,
+		   _MASKED_BIT_ENABLE(HSW_SAMPLE_C_PERFORMANCE));
+
 	/* WaSwitchSolVfFArbitrationPriority:hsw */
 	I915_WRITE(GAM_ECOCHK, I915_READ(GAM_ECOCHK) | HSW_ECOCHK_ARB_PRIO_SOL);
 
Signature · 6 lines
2.2.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Tested-by on v1 1/1
#1 lore raw

-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 363/364 363/364
ILK -1 364/366 363/366
SNB +2-1 443/450 444/450

IVB                                  496/498              496/498
BYT                                  288/289              288/289

HSW +2-6 542/564 538/564
BDW 415/417 415/417
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied

*ILK  igt_gem_fenced_exec_thrash_no-spare-fences-busy      PASS(2, M37)      DMESG_WARN(1, M37)
*SNB  igt_kms_flip_modeset-vs-vblank-race      DMESG_WARN(2, M35)      PASS(1, M35)
 SNB  igt_kms_flip_modeset-vs-vblank-race-interruptible      DMESG_WARN(2, M35M22)PASS(1, M35)      DMESG_WARN(1, M35)
 SNB  igt_kms_plane_plane-position-hole-pipe-B-plane-1      DMESG_WARN(1, M35)PASS(2, M35M22)      PASS(1, M35)
*HSW  igt_kms_flip_flip-vs-expired-vblank      PASS(2, M40)      DMESG_WARN(1, M40)
*HSW  igt_kms_flip_flip-vs-expired-vblank-interruptible      PASS(2, M40)      DMESG_WARN(1, M40)
*HSW  igt_kms_flip_nonexisting-fb      PASS(2, M40)      DMESG_WARN(1, M40)
*HSW  igt_kms_flip_nonexisting-fb-interruptible      PASS(2, M40)      DMESG_WARN(1, M40)
*HSW  igt_kms_flip_single-buffer-flip-vs-dpms-off-vs-modeset      PASS(3, M40M19)      DMESG_WARN(1, M40)
*HSW  igt_kms_plane_plane-panning-bottom-right-pipe-C-plane-1      TIMEOUT(2, M40)PASS(1, M19)      PASS(1, M40)
*HSW  igt_kms_plane_plane-position-hole-pipe-A-plane-2      PASS(2, M40)      DMESG_WARN(1, M40)
 HSW  igt_pm_rpm_modeset-non-lpsp-stress-no-wait      NSPT(1, M19)DMESG_WARN(1, M40)PASS(1, M40)      PASS(1, M40)

Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
In reply to Kenneth Graunke
Quoted 27 lines · Kenneth Graunke

Haswell significantly improved the performance of sampler_c messages, but the optimization appears to be off by default. Later platforms remove this bit, and apparently always enable the optimization.

Improves performance in "Counter Strike: Global Offensive" by 18% at default settings on Iris Pro.

This may break sampling of paletted formats (P8/A8P8/P8A8). It's unclear whether it affects sampling of paletted formats in general, or just the sample_c message (which is never used).

While libva does have support for using paletted formats (primarily for OSDs), that support appears to have been broken for at least a year, so I couldn't observe a regression from this.

---
 drivers/gpu/drm/i915/i915_reg.h | 1 +
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 2 files changed, 5 insertions(+)

Resubmitting the patch to unconditionally enable this. I tried to get libva-intel to use paletted formats, and observe a regression...but the only thing I found that used it was mplayer's OSD (on screen display). Even without my patch, the colors were totally wrong with that, and it's according to a few distro wikis, that's been the case for over a year.

Quoted 6 lines

If libva's code for paletted formats /is/ broken, they could always add code to disable this bit using the command validator when fixing it.

Could we try merging this, and back it out if someone reports a regression? I haven't observed any problems. It's also been quite stable.

Yeah makes sense. When resending please incorporated review feedback (Ville dug out the wa name), I've done that. And I've pasted the additional detail about the libva saga, just for reference (since no one will remember that it's mplayer's OSD which uses this 2 months down the road).

Also please cc libva mailing lists next time around as an fyi. Done that too.

Queued for -next, thanks for the patch.
-Daniel

Quoted 35 lines
drivers/gpu/drm/i915/i915_reg.h +1 -0
index 40ca873..0f32fd1a 100644
@@ -6167,6 +6167,7 @@ enum punit_power_well {
 #define  HSW_ROW_CHICKEN3_L3_GLOBAL_ATOMICS_DISABLE    (1 << 6)
 
 #define HALF_SLICE_CHICKEN3		0xe184
+#define   HSW_SAMPLE_C_PERFORMANCE	(1<<9)
 #define   GEN8_CENTROID_PIXEL_OPT_DIS	(1<<8)
 #define   GEN8_SAMPLER_POWER_BYPASS_DIS	(1<<1)
 
drivers/gpu/drm/i915/intel_pm.c +4 -0
index 7d99a9c..17e84dc 100644
@@ -5974,6 +5974,10 @@ static void haswell_init_clock_gating(struct drm_device *dev)
 	I915_WRITE(GEN7_GT_MODE,
 		   _MASKED_FIELD(GEN6_WIZ_HASHING_MASK, GEN6_WIZ_HASHING_16x4));
 
+	/* Make sample_c messages faster. */
+	I915_WRITE(HALF_SLICE_CHICKEN3,
+		   _MASKED_BIT_ENABLE(HSW_SAMPLE_C_PERFORMANCE));
+
 	/* WaSwitchSolVfFArbitrationPriority:hsw */
 	I915_WRITE(GAM_ECOCHK, I915_READ(GAM_ECOCHK) | HSW_ECOCHK_ARB_PRIO_SOL);
 
Signature · 6 lines
2.2.1

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 41 lines · Daniel Vetter
Quoted 27 lines · Kenneth Graunke

Haswell significantly improved the performance of sampler_c messages, but the optimization appears to be off by default. Later platforms remove this bit, and apparently always enable the optimization.

Improves performance in "Counter Strike: Global Offensive" by 18% at default settings on Iris Pro.

This may break sampling of paletted formats (P8/A8P8/P8A8). It's unclear whether it affects sampling of paletted formats in general, or just the sample_c message (which is never used).

While libva does have support for using paletted formats (primarily for OSDs), that support appears to have been broken for at least a year, so I couldn't observe a regression from this.

---
 drivers/gpu/drm/i915/i915_reg.h | 1 +
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 2 files changed, 5 insertions(+)

Resubmitting the patch to unconditionally enable this. I tried to get libva-intel to use paletted formats, and observe a regression...but the only thing I found that used it was mplayer's OSD (on screen display). Even without my patch, the colors were totally wrong with that, and it's according to a few distro wikis, that's been the case for over a year.

Quoted 6 lines

If libva's code for paletted formats /is/ broken, they could always add code to disable this bit using the command validator when fixing it.

Could we try merging this, and back it out if someone reports a regression? I haven't observed any problems. It's also been quite stable.

Yeah makes sense. When resending please incorporated review feedback (Ville dug out the wa name), I've done that. And I've pasted the additional detail about the libva saga, just for reference (since no one will remember that it's mplayer's OSD which uses this 2 months down the road).

Quoted 5 lines

Also please cc libva mailing lists next time around as an fyi. Done that too.

Queued for -next, thanks for the patch.
-Daniel

Oh, sorry, I missed that in the review.

Thanks, Daniel!

--Ken

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Hi Kenneth,

How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch.

I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't disable the palette.

Thanks
Haihao

Quoted 48 lines · Daniel Vetter
Quoted 41 lines · Kenneth Graunke
Quoted 27 lines

Haswell significantly improved the performance of sampler_c messages, but the optimization appears to be off by default. Later platforms remove this bit, and apparently always enable the optimization.

Improves performance in "Counter Strike: Global Offensive" by 18% at default settings on Iris Pro.

This may break sampling of paletted formats (P8/A8P8/P8A8). It's unclear whether it affects sampling of paletted formats in general, or just the sample_c message (which is never used).

While libva does have support for using paletted formats (primarily for OSDs), that support appears to have been broken for at least a year, so I couldn't observe a regression from this.

---
 drivers/gpu/drm/i915/i915_reg.h | 1 +
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 2 files changed, 5 insertions(+)

Resubmitting the patch to unconditionally enable this. I tried to get libva-intel to use paletted formats, and observe a regression...but the only thing I found that used it was mplayer's OSD (on screen display). Even without my patch, the colors were totally wrong with that, and it's according to a few distro wikis, that's been the case for over a year.

Quoted 6 lines

If libva's code for paletted formats /is/ broken, they could always add code to disable this bit using the command validator when fixing it.

Could we try merging this, and back it out if someone reports a regression? I haven't observed any problems. It's also been quite stable.

Yeah makes sense. When resending please incorporated review feedback (Ville dug out the wa name), I've done that. And I've pasted the additional detail about the libva saga, just for reference (since no one will remember that it's mplayer's OSD which uses this 2 months down the road).

Quoted 5 lines

Also please cc libva mailing lists next time around as an fyi. Done that too.

Queued for -next, thanks for the patch.
-Daniel

Quoted 6 lines

Oh, sorry, I missed that in the review.

Thanks, Daniel!

--Ken
_______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw
Quoted 7 lines · Haihao

Hi Kenneth,

How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch.

Quoted 5 lines

I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't disable the palette.

Thanks
Haihao

I ran:

mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg

For me, the OSD text is solid green, with hard edges.

If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black border around it. I presume that it's supposed to be white with vaapi as well, but I guess I'm not entirely sure.

It's possible that the optimization doesn't affect the palette as long as you never use sample_c with the paletted textures.

--Ken

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw
Quoted 11 lines · Kenneth Graunke
Quoted 10 lines · Haihao

Hi Kenneth,

How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch.

I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't disable the palette.

Quoted 8 lines
Quoted 2 lines

Thanks
Haihao

I ran:

mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg

For me, the OSD text is solid green, with hard edges.

The OSD text is white for me when using mplayer -osdlevel 3 -vo vaapi xxx. If possible, could you update your mplayer ?

Quoted 7 lines

If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black border around it. I presume that it's supposed to be white with vaapi as well, but I guess I'm not entirely sure.

It's possible that the optimization doesn't affect the palette as long as you never use sample_c with the paletted textures.

I verified the palette takes effect in the following way:

1. Only support P8A8 format in the driver

2. ran the above command and I saw white OSD text

3. Only support P4A4 format in the driver and don't use 3DSTATE_SAMPLER_PALETTE_LOAD0 to load the value to the texture palette, so the palette keeps unchanged.

4. ran the above command and I saw black OSD text.

5. Load the right value to the texture palette and ran the above command again, I saw white OSD text.

Hence I think sample_c with the paletted textures is used in the driver.

Quoted 2 lines

--Ken

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw
Quoted 43 lines · Haihao
Quoted 11 lines · Kenneth Graunke
Quoted 10 lines · Haihao

Hi Kenneth,

How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch.

I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't disable the palette.

Quoted 8 lines
Quoted 2 lines

Thanks
Haihao

I ran:

mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg

For me, the OSD text is solid green, with hard edges.

The OSD text is white for me when using mplayer -osdlevel 3 -vo vaapi xxx. If possible, could you update your mplayer ?

Quoted 7 lines

If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black border around it. I presume that it's supposed to be white with vaapi as well, but I guess I'm not entirely sure.

It's possible that the optimization doesn't affect the palette as long as you never use sample_c with the paletted textures.

I verified the palette takes effect in the following way:

1. Only support P8A8 format in the driver

2. ran the above command and I saw white OSD text

3. Only support P4A4 format in the driver and don't use 3DSTATE_SAMPLER_PALETTE_LOAD0 to load the value to the texture palette, so the palette keeps unchanged.

Quoted 6 lines

4. ran the above command and I saw black OSD text.

5. Load the right value to the texture palette and ran the above command again, I saw white OSD text.

Hence I think sample_c with the paletted textures is used in the driver.

Sorry, libva driver doesn't use sample_c message, I mean the paletted texture is used. However corroding to the doc, Palette is disabled for fast mode.

Quoted 9 lines
Quoted 3 lines

--Ken

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva

#8 lore raw
In reply to Xiang, Haihao
Quoted 15 lines · Haihao
Quoted 14 lines · Kenneth Graunke
Quoted 12 lines · Haihao

Hi Kenneth,

How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch.

I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't disable the palette.

Thanks
Haihao

Quoted 8 lines
Quoted 5 lines

I ran:

mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg

For me, the OSD text is solid green, with hard edges.

The OSD text is white for me when using mplayer -osdlevel 3 -vo vaapi xxx. If possible, could you update your mplayer ?

Huh. I'm using the Arch Linux package of mplayer-vaapi 36265-13, which seems to be the most recent subversion commit ID. I've never seen white text on my Haswell system - it seems to be consistently dark green.

Quoted 17 lines
Quoted 6 lines

If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black border around it. I presume that it's supposed to be white with vaapi as well, but I guess I'm not entirely sure.

It's possible that the optimization doesn't affect the palette as long as you never use sample_c with the paletted textures.

I verified the palette takes effect in the following way:

1. Only support P8A8 format in the driver

2. ran the above command and I saw white OSD text

3. Only support P4A4 format in the driver and don't use 3DSTATE_SAMPLER_PALETTE_LOAD0 to load the value to the texture palette, so the palette keeps unchanged.

Quoted 6 lines

4. ran the above command and I saw black OSD text.

5. Load the right value to the texture palette and ran the above command again, I saw white OSD text.

Hence I think sample_c with the paletted textures is used in the driver.

That sounds like the palette is actually working, then. Great :)

I doubt that libva would use sample_c - sampling with a shadow comparison? It looks like it just uses sample and sample+killpix.

I'm pretty sure the sample_c optimization just uses the palette memory as storage for some stuff, so it's quite possible it just works if you're only using sample and sample+killpix.

--Ken

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#9 lore raw
Quoted 51 lines · Kenneth Graunke
Quoted 15 lines · Haihao
Quoted 14 lines · Kenneth Graunke
Quoted 12 lines · Haihao

Hi Kenneth,

How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch.

I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't disable the palette.

Thanks
Haihao

Quoted 8 lines
Quoted 5 lines

I ran:

mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg

For me, the OSD text is solid green, with hard edges.

The OSD text is white for me when using mplayer -osdlevel 3 -vo vaapi xxx. If possible, could you update your mplayer ?

Huh. I'm using the Arch Linux package of mplayer-vaapi 36265-13, which seems to be the most recent subversion commit ID. I've never seen white text on my Haswell system - it seems to be consistently dark green.

Quoted 22 lines
Quoted 6 lines

If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black border around it. I presume that it's supposed to be white with vaapi as well, but I guess I'm not entirely sure.

It's possible that the optimization doesn't affect the palette as long as you never use sample_c with the paletted textures.

I verified the palette takes effect in the following way:

1. Only support P8A8 format in the driver

2. ran the above command and I saw white OSD text

3. Only support P4A4 format in the driver and don't use 3DSTATE_SAMPLER_PALETTE_LOAD0 to load the value to the texture palette, so the palette keeps unchanged.

4. ran the above command and I saw black OSD text.

5. Load the right value to the texture palette and ran the above command again, I saw white OSD text.

Quoted 6 lines
Quoted 1 line

Hence I think sample_c with the paletted textures is used in the driver.

That sounds like the palette is actually working, then. Great :)

I doubt that libva would use sample_c - sampling with a shadow comparison? It looks like it just uses sample and sample+killpix.

You are right, libva driver doesn't use sample_c message.

Quoted 3 lines

I'm pretty sure the sample_c optimization just uses the palette memory as storage for some stuff, so it's quite possible it just works if you're only using sample and sample+killpix.

Thanks for the explanation, it makes sense to me.

Quoted 2 lines

--Ken

_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva

#10 lore raw
Quoted 59 lines · Haihao
Quoted 51 lines · Kenneth Graunke
Quoted 15 lines · Haihao
Quoted 14 lines · Kenneth Graunke
Quoted 12 lines · Haihao

Hi Kenneth,

How did you test OSD ? I can't reproduce the issue you mentioned, OSD works well for me when using mplayer-vaapi with the latest libva/libva-intel-driver master branch.

I tried your patch, what surprised me is OSD still works well after applying your patch. It seems your patch didn't disable the palette.

Thanks
Haihao

Quoted 8 lines
Quoted 5 lines

I ran:

mplayer -osdlevel 3 -vo vaapi big_buck_bunny_720p_stereo.ogg

For me, the OSD text is solid green, with hard edges.

The OSD text is white for me when using mplayer -osdlevel 3 -vo vaapi xxx. If possible, could you update your mplayer ?

Huh. I'm using the Arch Linux package of mplayer-vaapi 36265-13, which seems to be the most recent subversion commit ID. I've never seen white text on my Haswell system - it seems to be consistently dark green.

Quoted 22 lines
Quoted 6 lines

If you use "-vo gl" or "-vo xv", the OSD is solid white text with a black border around it. I presume that it's supposed to be white with vaapi as well, but I guess I'm not entirely sure.

It's possible that the optimization doesn't affect the palette as long as you never use sample_c with the paletted textures.

I verified the palette takes effect in the following way:

1. Only support P8A8 format in the driver

2. ran the above command and I saw white OSD text

3. Only support P4A4 format in the driver and don't use 3DSTATE_SAMPLER_PALETTE_LOAD0 to load the value to the texture palette, so the palette keeps unchanged.

4. ran the above command and I saw black OSD text.

5. Load the right value to the texture palette and ran the above command again, I saw white OSD text.

Quoted 6 lines
Quoted 1 line

Hence I think sample_c with the paletted textures is used in the driver.

That sounds like the palette is actually working, then. Great :)

I doubt that libva would use sample_c - sampling with a shadow comparison? It looks like it just uses sample and sample+killpix.

Quoted 7 lines

You are right, libva driver doesn't use sample_c message.

Quoted 3 lines

I'm pretty sure the sample_c optimization just uses the palette memory as storage for some stuff, so it's quite possible it just works if you're only using sample and sample+killpix.

Thanks for the explanation, it makes sense to me.

Thanks for digging into this some more, I've added the above discussion in a quote to the commit message.

Thanks, Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva