Skip to contentSkip to conversation

qt4: Fix QT4 applications spamming "QWSLock::down(): Invalid argument"

PATCH Superseded Mike Looijmans 2 participants 4 messages Jan 6, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 qt4: Fix QT4 applications spamming "QWSLock::down(): Invalid argument"

If you run a QT server application, and a client in a separate process, it will spam the log with "QWSLock::down(): Invalid argument" messages because of an old bug in the locking code. There's a patch on the net that fixes it, which I manually adapted by removing the commented-out debug statements.

We have been using this patch for about half a year without problems, and the QT people apparently don't care about the bug, hence there's no upstream status. Including this into OE core will at least save other people the trouble of having to find and apply it for themselves.

---
 meta/recipes-qt/qt4/qt4-4.8.6.inc |    1 +
 1 file changed, 1 insertion(+)
meta/recipes-qt/qt4/qt4-4.8.6.inc +1 -0
index 074e82d..a2c0688 100644
@@ -26,6 +26,7 @@ SRC_URI = "http://download.qt-project.org/official_releases/qt/4.8/${PV}/qt-ever
            file://0030-aarch64_arm64_qatomic_support.patch \
            file://0031-aarch64_arm64_mkspecs.patch \
            file://0032-aarch64_add_header.patch \
+           file://Fix-QWSLock-invalid-argument-logs.patch \
            file://g++.conf \
            file://linux.conf \
            "
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 8 lines · Mike Looijmans

We have been using this patch for about half a year without problems, and the QT people
apparently don't care about the bug, hence there's no upstream status. Including this
into OE core will at least save other people the trouble of having to find and apply
it for themselves.

You still need an upstream-status - if it's been submitted to Qt but they're ignoring it then use Submitted and ideally put a link to the patch.

Ross

#2 lore raw

PATCH v3 1/1 qt4: Fix QT4 applications spamming "QWSLock::down(): Invalid argument"

If you run a QT server application, and a client in a separate process, it will spam the log with "QWSLock::down(): Invalid argument" messages because of an old bug in the locking code. There's a patch on the net that fixes it, which I manually adapted by removing the commented-out debug statements.

We have been using this patch for about half a year without problems, and the QT people apparently don't care about the bug, for which this solution has been posted in 2012. Including this into OE core will at least save other people the trouble of having to find and apply it for themselves.

---
v3: Added my signoff, upstream-status and link to original patch to the patch

 meta/recipes-qt/qt4/qt4-4.8.6.inc                  |    1 +
 .../Fix-QWSLock-invalid-argument-logs.patch        |   98 ++++++++++++++++++++
 2 files changed, 99 insertions(+)
 create mode 100644 meta/recipes-qt/qt4/qt4-4.8.6/Fix-QWSLock-invalid-argument-logs.patch
meta/recipes-qt/qt4/qt4-4.8.6.inc +1 -0
index 074e82d..a2c0688 100644
@@ -26,6 +26,7 @@ SRC_URI = "http://download.qt-project.org/official_releases/qt/4.8/${PV}/qt-ever
            file://0030-aarch64_arm64_qatomic_support.patch \
            file://0031-aarch64_arm64_mkspecs.patch \
            file://0032-aarch64_add_header.patch \
+           file://Fix-QWSLock-invalid-argument-logs.patch \
            file://g++.conf \
            file://linux.conf \
            "
meta/recipes-qt/qt4/qt4-4.8.6/Fix-QWSLock-invalid-argument-logs.patch new file +98 -0

98 lines not on this page · raw message

Signature · 1 line
1.7.9.5
#3 lore raw
In reply to Burton, Ross

Ok, I'll add some extra information to the patch and submit a v3.

M.

Quoted 13 lines · Ross

On 6 January 2015 at 10:34, Mike Looijmans <[email protected] <mailto:[email protected]>> wrote:

We have been using this patch for about half a year without problems, and the QT people
apparently don't care about the bug, hence there's no upstream status. Including this
into OE core will at least save other people the trouble of having to find and apply
it for themselves.

Quoted 4 lines

You still need an upstream-status - if it's been submitted to Qt but they're ignoring it then use Submitted and ideally put a link to the patch.

Ross

Met vriendelijke groet / kind regards,

Mike Looijmans
System Expert

TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax: (+31) (0) 499 33 69 70
E-mail: [email protected]
Website: www.topic.nl

Please consider the environment before printing this e-mail

Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/