Skip to contentSkip to conversation

kernel.bbclass: change oldnoconfig to olddefconfig

PATCH In review Bob Cochran 2 participants 2 messages Jan 9, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kernel.bbclass: change oldnoconfig to olddefconfig

KERNEL_CONFIG_COMMAND is defined as passing oldnoconfig to oe_runmake_call, but oldnoconfig is both an alias to olddefconfig and a misleading name. Therefore, change it to the meaningfully named
option: olddefconfig.

For further background, please see commit fb16d8912db5268f29706010ecafff74b971c58d in Linux kernel source tree:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fb16d8912db5268f29706010ecafff74b971c58d

---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -1
index 88356b1..aebbc65 100644
@@ -275,7 +275,7 @@ python sysroot_stage_all () {
     oe.path.copyhardlinktree(d.expand("${D}${KERNEL_SRC_PATH}"), d.expand("${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}"))
 }
 
-KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} oldnoconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
+KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} olddefconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
 
 kernel_do_configure() {
 	# fixes extra + in /lib/modules/2.6.37+
Signature · 1 line
1.7.9.5
#1 lore raw
Quoted 4 lines · Bob Cochran

KERNEL_CONFIG_COMMAND is defined as passing oldnoconfig to oe_runmake_call, but oldnoconfig is both an alias to olddefconfig and a misleading name. Therefore, change it to the meaningfully named
option: olddefconfig.

We've discussed this on the mailing list before. To keep compatibility with the widest range of possible kernels, we are using the oldest target on purpose, with
a fallback where appropriate:

http://lists.openembedded.org/pipermail/openembedded-core/2014-February/089242.html
https://www.mail-archive.com/[email protected]/msg49040.html

Cheers,

Bruce

Quoted 32 lines

For further background, please see commit fb16d8912db5268f29706010ecafff74b971c58d in Linux kernel source tree:

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=fb16d8912db5268f29706010ecafff74b971c58d

---
 meta/classes/kernel.bbclass |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/kernel.bbclass +1 -2
index 88356b1..aebbc65 100644
@@ -275,7 +275,7 @@ python sysroot_stage_all () {
     oe.path.copyhardlinktree(d.expand("${D}${KERNEL_SRC_PATH}"), d.expand("${SYSROOT_DESTDIR}${KERNEL_SRC_PATH}"))
 }
 
-KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} oldnoconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
+KERNEL_CONFIG_COMMAND ?= "oe_runmake_call -C ${S} O=${B} olddefconfig || yes '' | oe_runmake -C ${S} O=${B} oldconfig"
 
 kernel_do_configure() {
        # fixes extra + in /lib/modules/2.6.37+
--

1.7.9.5

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Signature · 2 lines
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"