Skip to contentSkip to conversation

Staging: comedi: patch to fix line over 80 characters warning

PATCH In review jitendra kumar khasdev 2 participants 4 messages Jan 10, 2015 – Jan 19, 2015 Staging

lore
Share & tools
lore

jitendra kumar khasdev

author
#0 lore raw

PATCH v7 1/1 Staging: comedi: patch to fix line over 80 characters warning

This is patch to pcl812.c that fix line over 80 characters warning which is found by checkpatch.pl tool. Reduce the extra space around equal sign that fix warning.

Signed-off-by Jitendra kumar khasdev <[email protected]>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/comedi/drivers/pcl812.c +1 -1
index ac243ca..9b576bc 100644
@@ -1235,7 +1235,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
 		for (i = 0; i < 2; i++) {
 			unsigned long dmabuf;
 
-			dmabuf =  __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
+			dmabuf = __get_dma_pages(GFP_KERNEL, devpriv->dmapages);
 			if (!dmabuf)
 				return -ENOMEM;
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 8 lines · jitendra kumar khasdev

This is patch to pcl812.c that fix line over 80 characters warning which is found by checkpatch.pl tool. Reduce the extra space around equal sign that fix warning.

Signed-off-by Jitendra kumar khasdev <[email protected]>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree :(

author
#2 lore raw

Will you give reason for not apply my patch on your tree. I have tested by appling on linux main tree.

Quoted 3 lines · jitendra kumar khasdev

This is patch to pcl812.c that fix line over 80 characters warning which is found by checkpatch.pl tool. Reduce the extra space around equal sign that fix warning.

Regards,
JItendra kumar khasdev,
jitendra-02.github.io | Mo. 8871242083

Quoted 12 lines · Greg KH
Quoted 8 lines · jitendra kumar khasdev

This is patch to pcl812.c that fix line over 80 characters warning which is found by checkpatch.pl tool. Reduce the extra space around equal sign that fix warning.

Signed-off-by Jitendra kumar khasdev <[email protected]>
---
 drivers/staging/comedi/drivers/pcl812.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree :(

maintainer
#3 lore raw

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

Quoted 2 lines · jitendra kumar khasdev

Will you give reason for not apply my patch on your tree. I have tested by appling on linux main tree.

Probably because someone else sent in fixes that changed things in this area, and those patches are not in Linus's tree yet. Please always work against the linux-next tree, or even better, my staging.git tree, using the staging-testing branch.

thanks,

greg k-h