watchdog: wdt_pci: Fixed missing blank line warning
Subsystems (2)
PATCH v2 1/8 watchdog: wdt_pci: Fixed missing blank line warning
Add a new line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/wdt_pci.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/watchdog/wdt_pci.c +2 -0
@@ -279,6 +279,7 @@ static int wdtpci_get_temperature(int *temperature) {unsigned short c;unsigned long flags; +spin_lock_irqsave (&wdtpci_lock, flags); c =inb (WDT_RT );udelay (8 );
@@ -366,6 +367,7 @@ static ssize_t wdtpci_write(struct file *file, const char __user *buf,for (i =0 ; i != count; i++) {char c; +if (get_user (c, buf + i))return -EFAULT ;if (c =='V' )
Signature · 1 line
1.7.9.5
PATCH v2 2/8 watchdog: sch311x_wdt: Fixed missing blank line warning
Add a new line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/sch311x_wdt.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/sch311x_wdt.c +1 -0
@@ -233,6 +233,7 @@ static ssize_t sch311x_wdt_write(struct file *file, const char __user *buf,for (i =0 ; i != count; i++) {char c; +if (get_user (c, buf + i))return -EFAULT ;if (c =='V' )
Signature · 1 line
1.7.9.5
PATCH v2 3/8 watchdog: alim1535_wdt: Fixed missing blank line warning
In reply to Athira LekshmiAdd a blank line after declarations to remove the checkpatch warning:
'Missing line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/alim1535_wdt.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/watchdog/alim1535_wdt.c +2 -0
@@ -154,6 +154,7 @@ static ssize_t ali_write(struct file *file, const char __user *data,the magic character */ for (i =0 ; i != len; i++) {char c; +if (get_user (c, data + i))return -EFAULT ;if (c =='V' )
@@ -218,6 +219,7 @@ static long ali_ioctl(struct file *file, unsigned int cmd, unsigned long arg)case WDIOC_SETTIMEOUT : {int new_timeout; +if (get_user (new_timeout, p))return -EFAULT ;if (ali_settimer (new_timeout))
Signature · 1 line
1.7.9.5
PATCH v2 4/8 watchdog: advantechwdt: Fixed missing blank line warning
In reply to Athira LekshmiAdd a blank line after declarations to remove the checkpatch warning:
'Missing line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/advantechwdt.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/advantechwdt.c +1 -0
@@ -121,6 +121,7 @@ static ssize_t advwdt_write(struct file *file, const char __user *buf,for (i =0 ; i != count; i++) {char c; +if (get_user (c, buf + i))return -EFAULT ;if (c =='V' )
Signature · 1 line
1.7.9.5
PATCH v2 5/8 watchdog: acquirewdt: Fixed missing blank line warning
In reply to Athira LekshmiAdd a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/acquirewdt.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/acquirewdt.c +1 -0
@@ -132,6 +132,7 @@ static ssize_t acq_write(struct file *file, const char __user *buf,magic character */ for (i =0 ; i != count; i++) {char c; +if (get_user (c, buf + i))return -EFAULT ;if (c =='V' )
Signature · 1 line
1.7.9.5
PATCH v2 6/8 watchdog: ar7_wdt: Fixed missing blank line warning
In reply to Athira LekshmiAdd a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/ar7_wdt.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/ar7_wdt.c +1 -0
@@ -202,6 +202,7 @@ static ssize_t ar7_wdt_write(struct file *file, const char *data, expect_close =0 ;for (i =0 ; i < len; ++i) {char c; +if (get_user (c, data + i))return -EFAULT ;if (c =='V' )
Signature · 1 line
1.7.9.5
PATCH v2 7/8 watchdog: at91sam9_wdt: Fixed missing blank line warning
In reply to Athira LekshmiAdd a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/at91sam9_wdt.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/watchdog/at91sam9_wdt.c +3 -0
@@ -82,6 +82,7 @@ MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started "#define to_wdt (wdd) container_of(wdd, struct at91wdt, wdd)struct at91wdt {struct watchdog_device wdd; +void __iomem *base;unsigned long next_heartbeat;/* the next_heartbeat for the timer */ struct timer_list timer;/* The timer that pings the watchdog */
@@ -121,6 +122,7 @@ static inline void at91_wdt_reset(struct at91wdt *wdt)static void at91_ping (unsigned long data) {struct at91wdt *wdt = (struct at91wdt *)data; +if (time_before (jiffies, wdt->next_heartbeat) || !watchdog_active (&wdt->wdd)) {at91_wdt_reset (wdt);
@@ -372,6 +374,7 @@ static int __init at91wdt_probe(struct platform_device *pdev) static int __exit at91wdt_remove(struct platform_device *pdev) {struct at91wdt *wdt =platform_get_drvdata (pdev); +watchdog_unregister_device (&wdt->wdd);pr_warn ("I quit now, hardware will probably reboot!\n" );
Signature · 1 line
1.7.9.5
PATCH v2 8/8 watchdog: eurotechwdt: Fixed missing blank line warning
In reply to Athira LekshmiAdd a blank line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'
---
Changes in v2:
- Make the commit message more clearer.
drivers/watchdog/eurotechwdt.c | 1 + 1 file changed, 1 insertion(+)
drivers/watchdog/eurotechwdt.c +1 -0
@@ -210,6 +210,7 @@ size_t count, loff_t *ppos)for (i =0 ; i != count; i++) {char c; +if (get_user (c, buf + i))return -EFAULT ;if (c =='V' )
Signature · 1 line
1.7.9.5
Guenter Roeck
maintainerQuoted 8 lines · Athira Lekshmi
Add a new line after declarations to remove the checkpatch warning:
'Missing blank line after declarations'Signed-off-by Athira Lekshmi <[email protected]>---
Changes in v2:
- Make the commit message more clearer.
The patches are all good, though I would suggest something like "Add missing blank lines" as subject, and I would suggest to merge the 8 watchdog patches into one.
Thanks,
Guenter