Skip to contentSkip to conversation

ubi: reset mtd_devs when ubi part fail

PATCH New Heiko Schocher 1 participant 1 message Jan 20, 2015

Subsystems (2)
Memory technology devices (MTD) Unsorted block images (UBI)
lore
Share & tools
lore

Heiko Schocher

author
#0 lore raw

PATCH 1/1 ubi: reset mtd_devs when ubi part fail

if "ubi part" fails, reset also mtd_devs to 0, as further "ubi part" would use wrong mtd_devs.

Signed-off-by Heiko Schocher <[email protected]>

---
This issue was posted from Andrew here:

http://patchwork.ozlabs.org/patch/410507/
Patchwork [U-Boot] ubi: reset relevant globals in ubi_exit()

Could this produce with current mainline also now, and fixed it in ubi_init() in the error path too.

Andrew: could you test this patch?
(Should I add your Signed-off-by ?)

 drivers/mtd/ubi/build.c | 8 ++++++++
 1 file changed, 8 insertions(+)
drivers/mtd/ubi/build.c +8 -0
index 584cf5f..290d524 100644
@@ -1358,6 +1358,10 @@ out_version:
 out_class:
 	class_destroy(ubi_class);
 out:
+#ifdef __UBOOT__
+	/* Reset any globals that the driver depends on being zeroed */
+	mtd_devs = 0;
+#endif
 	ubi_err("cannot initialize UBI, error %d", err);
 	return err;
 }

@@ -1384,6 +1388,10 @@ void ubi_exit(void)
 	misc_deregister(&ubi_ctrl_cdev);
 	class_remove_file(ubi_class, &ubi_version);
 	class_destroy(ubi_class);
+#ifdef __UBOOT__
+	/* Reset any globals that the driver depends on being zeroed */
+	mtd_devs = 0;
+#endif
 }
 module_exit(ubi_exit);
Signature · 1 line
2.1.0