server/process: Fix select call

PATCH New Richard Purdie 1 participant 1 message Jan 21, 2015

Share & tools

Richard Purdie

author

2015-01-21 17:44 UTC #0 lore raw

PATCH 1/1 server/process: Fix select call

There was a report that bitbake -e | less would use 100% cpu when it shouldn't really. The issue appears to be a bogus file descriptor in the select call. We shouldn't be blocking if there is event data pending to a *reader* from server context.

[YOCTO #7138]

Signed-off-by Richard Purdie <[email protected]>

bitbake/lib/bb/server/process.py +1 -1

index d362f8d..7671b26 100644
@@ -115,7 +115,7 @@ class ProcessServer(Process, BaseImplServer):
                     self.quitout.recv()
                     self.quit = True
 
-                self.idle_commands(.1, [self.event_queue._reader, self.command_channel, self.quitout])
+                self.idle_commands(.1, [self.command_channel, self.quitout])
             except Exception:
                 logger.exception('Running command %s', command)