base-files/profile: change EDITOR to not be busybox specific
PATCH 1/1 base-files/profile: change EDITOR to not be busybox specific
Setting "EDITOR=/bin/vi" breaks on non-busybox systems, as vim will populate /usr/bin/vi instead, and you get stuff like:
op3:~/poky/meta-builder$ git commit -s error: cannot run /bin/vi: No such file or directory error: unable to start editor '/bin/vi' Please supply the message using either -m or -F option. op3:~/poky/meta-builder$ which vi /usr/bin/vi op3:~/poky/meta-builder$
Since we've already specified a proper path above in the profile, we've no need to call out where in the path vi lives, and hence this will work with busybox and a full vim install w/o busybox.
--- meta/recipes-core/base-files/base-files/profile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-core/base-files/base-files/profile +1 -1
@@ -2,7 +2,7 @@ # and Bourne compatible shells (bash(1), ksh(1), ash(1), ...). PATH="/usr/local/bin:/usr/bin:/bin" -EDITOR="/bin/vi" # needed for packages like cron +EDITOR="vi" # needed for packages like cron, git-commit test -z "$TERM" && TERM="vt100" # Basic terminal capab. For screen etc. if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
Signature · 1 line
2.2.1
Quoted 25 lines · Paul Gortmaker
Setting "EDITOR=/bin/vi" breaks on non-busybox systems, as vim will populate
/usr/bin/viinstead, and you get stuff like:op3:~/poky/meta-builder$ git commit -s error: cannot run /bin/vi: No such file or directory error: unable to start editor '/bin/vi' Please supply the message using either -m or -F option. op3:~/poky/meta-builder$ which vi /usr/bin/vi op3:~/poky/meta-builder$Since we've already specified a proper path above in the profile, we've no need to call out where in the path vi lives, and hence this will work with busybox and a full vim install w/o busybox.
Signed-off-by Paul Gortmaker <[email protected]>--- meta/recipes-core/base-files/base-files/profile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-core/base-files/base-files/profile +0
-0
meta/recipes-core/base-files/base-files/profile line 8
Quoted 8 lines
meta/recipes-core/base-files/base-files/profile +1
-1@@ -2,7 +2,7 @@ # and Bourne compatible shells (bash(1), ksh(1), ash(1), ...). PATH="/usr/local/bin:/usr/bin:/bin" -EDITOR="/bin/vi" # needed for packages like cron +EDITOR="vi" # needed for packages like cron, git-commit test -z "$TERM" && TERM="vt100" # Basic terminal capab. For screen etc. if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then
While I agree with this change, arguably busybox should also be changed. Everywhere I look "vi" lives in /usr/bin. FreeBSD, NetBSD, Ubuntu, and Slackware all seem to put vi in /usr/bin.
The same is true of getopt.
What are other people's thoughs?
Quoted 40 lines · Dan McGregor
Quoted 25 lines · Paul Gortmaker
Setting "EDITOR=/bin/vi" breaks on non-busybox systems, as vim will populate
/usr/bin/viinstead, and you get stuff like:op3:~/poky/meta-builder$ git commit -s error: cannot run /bin/vi: No such file or directory error: unable to start editor '/bin/vi' Please supply the message using either -m or -F option. op3:~/poky/meta-builder$ which vi /usr/bin/vi op3:~/poky/meta-builder$Since we've already specified a proper path above in the profile, we've no need to call out where in the path vi lives, and hence this will work with busybox and a full vim install w/o busybox.
Signed-off-by Paul Gortmaker <[email protected]>--- meta/recipes-core/base-files/base-files/profile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-core/base-files/base-files/profile +0
-0meta/recipes-core/base-files/base-files/profile line 8
Quoted 8 lines
meta/recipes-core/base-files/base-files/profile +1
-1@@ -2,7 +2,7 @@ # and Bourne compatible shells (bash(1), ksh(1), ash(1), ...). PATH="/usr/local/bin:/usr/bin:/bin" -EDITOR="/bin/vi" # needed for packages like cron +EDITOR="vi" # needed for packages like cron, git-commit test -z "$TERM" && TERM="vt100" # Basic terminal capab. For screen etc. if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; thenWhile I agree with this change, arguably busybox should also be changed. Everywhere I look "vi" lives in
/usr/bin. FreeBSD, NetBSD, Ubuntu, and Slackware all seem to put vi in/usr/bin.
Quoted 4 lines
The same is true of getopt.
What are other people's thoughs?
If I remember my history lessons correctly, the distinction between /bin and /usr/bin was that /bin will reside in the root mount, while /usr may mount something else. Busybox seems to consider "vi" and "getopt" things that need to be available at all times. Which is not a strange thought, it would be frustrating to know that all you need to fix the system is to edit a file, but you're stuck without editor when /usr can't be mounted for whatever reason.
On the other hand, if you have a busybox system, you can always run vi using "/bin/busybox vi" and /bin/vi is just a symbolic link for that. If all other systems use /usr/bin/vi, I think busybox should be changed to follow suit.
In the end, my vote would be on a busybox modification. I can't think of a convincing reason why it should reside in /bin/, while there are plenty reasons to move it to /usr/bin.
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax: (+31) (0) 499 33 69 70
E-mail: [email protected]
Website: www.topic.nl
Please consider the environment before printing this e-mail
Visit us at Embedded World 2015 Nuernberg, 24.02.2015 till 26.02.2015, Hall 1, stand number 136.
https://www.embedded-world.de/de/ausstellerprodukte/?focus=edb3exhibitor&focus2=14017667&focus3=embwld15&highlight=topic
Quoted 38 lines · Dan McGregor
Quoted 15 lines · Paul Gortmaker
Setting "EDITOR=/bin/vi" breaks on non-busybox systems, as vim will populate
/usr/bin/viinstead, and you get stuff like:op3:~/poky/meta-builder$ git commit -s error: cannot run /bin/vi: No such file or directory error: unable to start editor '/bin/vi' Please supply the message using either -m or -F option. op3:~/poky/meta-builder$ which vi /usr/bin/vi op3:~/poky/meta-builder$Since we've already specified a proper path above in the profile, we've no need to call out where in the path vi lives, and hence this will work with busybox and a full vim install w/o busybox.
Review
Quoted 6 lines
Signed-off-by Paul Gortmaker <[email protected]>--- meta/recipes-core/base-files/base-files/profile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0b/meta/recipes-core/base-files/base-files/profile
meta/recipes-core/base-files/base-files/profile line 5
Quoted 8 lines
index
88ab8d877b0d..53c2680409dd100644meta/recipes-core/base-files/base-files/profile +0
-1@@ -2,7 +2,7 @@ # and Bourne compatible shells (bash(1), ksh(1), ash(1), ...). PATH="/usr/local/bin:/usr/bin:/bin" -EDITOR="/bin/vi" # needed for packages likecron
meta/recipes-core/base-files/base-files/profile line 5
Quoted 1 line
meta/recipes-core/base-files/base-files/profile +1
-0+EDITOR="vi" # needed for packages like cron,git-commit
meta/recipes-core/base-files/base-files/profile line 6
Quoted 1 line
meta/recipes-core/base-files/base-files/profile +0
-0test -z "$TERM" && TERM="vt100" # Basic terminal capab. Forscreen etc.
Quoted 1 line
Quoted 7 lines
Quoted 1 line
if [ ! -e
/etc/localtime-a ! -e/etc/TZ]; thenWhile I agree with this change, arguably busybox should also be changed. Everywhere I look "vi" lives in
/usr/bin. FreeBSD, NetBSD, Ubuntu, and Slackware all seem to put vi in/usr/bin.The same is true of getopt.
Yea.
http://lists.busybox.net/pipermail/busybox/2012-June/078020.html
And we should run that again nowadays, obviously. Perhaps fedora fixed their layout in the meantime? Can anyone check on a current fedora, please?
Thanks,
Quoted 6 lines · [[PATCH] base-files/profile: change EDITOR to not be busybox specific] On…
Setting "EDITOR=/bin/vi" breaks on non-busybox systems, as vim will populate
/usr/bin/viinstead, and you get stuff like:op3:~/poky/meta-builder$ git commit -s error: cannot run /bin/vi: No such file or directory error: unable to start editor '/bin/vi'
Ping - this seems like the right thing to do, even if we decide to make busybox LSB compliant at a later date; there is no need to do a full pathspec for vi.
P.
--
Quoted 30 lines
Please supply the message using either -m or -F option.
op3:~/poky/meta-builder$ which vi /usr/bin/vi op3:~/poky/meta-builder$Since we've already specified a proper path above in the profile, we've no need to call out where in the path vi lives, and hence this will work with busybox and a full vim install w/o busybox.
Signed-off-by Paul Gortmaker <[email protected]>--- meta/recipes-core/base-files/base-files/profile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/recipes-core/base-files/base-files/profile +1
-1@@ -2,7 +2,7 @@ # and Bourne compatible shells (bash(1), ksh(1), ash(1), ...). PATH="/usr/local/bin:/usr/bin:/bin" -EDITOR="/bin/vi" # needed for packages like cron +EDITOR="vi" # needed for packages like cron, git-commit test -z "$TERM" && TERM="vt100" # Basic terminal capab. For screen etc. if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; thenSignature · 1 line
2.2.1