Skip to contentSkip to conversation

ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C

PATCH Applied Jarkko Nikula 3 participants 3 messages Jan 23, 2015 – Jan 29, 2015 ACPI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ACPI / LPSS: Remove non-existing clock control from Intel Lynxpoint I2C

Intel Lynxpoint I2C does not have clock parameter register like SPI and UART do have. Therefore remove LPSS_CLK_GATE flag from the Lynxpoint I2C device description in order to not needlessly toggle clock enable bit in non-existing register.

---
For linux-next branch. This has been here since commit f58b082aed43 ("ACPI / scan: Add special handler for Intel Lynxpoint LPSS devices") without known problems.

Mika: I assumed this holds true for INT3432 and INT3433 too?

---
 drivers/acpi/acpi_lpss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/acpi/acpi_lpss.c +1 -1
index 4f3febf8a589..9d43f79627a9 100644
@@ -129,7 +129,7 @@ static struct lpss_device_desc lpt_dev_desc = {
 };
 
 static struct lpss_device_desc lpt_i2c_dev_desc = {
-	.flags = LPSS_CLK | LPSS_CLK_GATE | LPSS_LTR,
+	.flags = LPSS_CLK | LPSS_LTR,
 	.prv_offset = 0x800,
 };
 
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines · Jarkko Nikula

Intel Lynxpoint I2C does not have clock parameter register like SPI and UART do have. Therefore remove LPSS_CLK_GATE flag from the Lynxpoint I2C device description in order to not needlessly toggle clock enable bit in non-existing register.

Quoted 7 lines

---
For linux-next branch. This has been here since commit f58b082aed43 ("ACPI / scan: Add special handler for Intel Lynxpoint LPSS devices") without known problems.

Mika: I assumed this holds true for INT3432 and INT3433 too?

Yes.

IIRC there used to be versions of Lynxpoint where the clock was actually gated even if the document said the register is reserved. That's why the I2C still tries to ungate the clock.

As long as you tested this properly,

#2 lore raw
Quoted 16 lines · Mika Westerberg
Quoted 5 lines · Jarkko Nikula

Intel Lynxpoint I2C does not have clock parameter register like SPI and UART do have. Therefore remove LPSS_CLK_GATE flag from the Lynxpoint I2C device description in order to not needlessly toggle clock enable bit in non-existing register.

Quoted 7 lines

---
For linux-next branch. This has been here since commit f58b082aed43 ("ACPI / scan: Add special handler for Intel Lynxpoint LPSS devices") without known problems.

Mika: I assumed this holds true for INT3432 and INT3433 too?

Yes.

Quoted 7 lines

IIRC there used to be versions of Lynxpoint where the clock was actually gated even if the document said the register is reserved. That's why the I2C still tries to ungate the clock.

As long as you tested this properly,

Queued up for 3.20 then, thanks!

Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.