Skip to contentSkip to conversation

line over 80 character warnings.

PATCH In review jitendra kumar khasdev 3 participants 6 messages Jan 23, 2015 – Jan 26, 2015 Staging

lore
Share & tools
lore

jitendra kumar khasdev

author
#0 lore raw

cover line over 80 character warnings.

In these two files jr3_pci.c, jr3_pci.h, 80 character warnings are reduced.

jitendra kumar khasdev (2):
Staging: comedi: fix line over 80 characters warning
Staging: comedi: fix line over 80 characters warning

 drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
 drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
 2 files changed, 5 insertions(+), 3 deletions(-)
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 1/2 Staging: comedi: fix line over 80 characters warning

This is patch to file jr3_pci.h that fix up warning line over 80 character which is found by checkpatch tool.

Signed-off-by Jitendra Kumar Khasdev <[email protected]>
---
 drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/jr3_pci.h +3 -2
index 20478ae..356811d 100644
@@ -261,8 +261,9 @@ struct intern_transform {
 	} link[8];
 };
 
-/*  JR3 force/torque sensor data definition. For more information see sensor and */
-/*  hardware manuals. */
+/*  JR3 force/torque sensor data definition. For more information see sensor
+ *  and hardware manuals.
+ */
 
 struct jr3_channel {
 	/*  Raw_channels is the area used to store the raw data coming from */
Signature · 1 line
1.9.1
#2 lore raw

Re: [PATCH v1 1/2] Staging: comedi: fix line over 80 characters warning

Quoted 13 lines · jitendra kumar khasdev

This is patch to file jr3_pci.h that fix up warning line over 80 character which is found by checkpatch tool.

Signed-off-by Jitendra Kumar Khasdev <[email protected]>
---
  drivers/staging/comedi/drivers/jr3_pci.h | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)
drivers/staging/comedi/drivers/jr3_pci.h +0 -0
index 20478ae..356811d 100644

drivers/staging/comedi/drivers/jr3_pci.h struct intern_transform { · line 266

Quoted 8 lines
drivers/staging/comedi/drivers/jr3_pci.h +3 -2
@@ -261,8 +261,9 @@ struct intern_transform {
  	} link[8];
  };
 
-/*  JR3 force/torque sensor data definition. For more information see sensor and */
-/*  hardware manuals. */
+/*  JR3 force/torque sensor data definition. For more information see sensor
+ *  and hardware manuals.
+ */

The usual block comment style is like this:

/*
* Blah blah
* blah.
*/

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
author
#3 lore raw

PATCH 2/2 Staging: comedi: fix line over 80 characters warning

In reply to jitendra kumar khasdev

This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline so that 80 character line over warning to be reduced.

Signed-off-by Jitendra Kumar Khasdev <[email protected]>
---
 drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/jr3_pci.c +2 -1
index 81fab2d..1de843d 100644
@@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
 	return 0;
 }
 
-static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
+static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
+							*s)
 {
 	struct jr3_pci_subdev_private *spriv = s->private;
 	struct jr3_pci_poll_delay result = poll_delay_min_max(1000, 2000);
Signature · 1 line
1.9.1
maintainer
#4 lore raw

Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning

Quoted 4 lines · jitendra kumar khasdev

This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline so that 80 character line over warning to be reduced.

The irony of not properly line-wrapping your changelog comment for a patch that you are fixing up proper line size is huge :)

Quoted 11 lines
Signed-off-by Jitendra Kumar Khasdev <[email protected]>
---
 drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/jr3_pci.c +0 -0
index 81fab2d..1de843d 100644

drivers/staging/comedi/drivers/jr3_pci.c static int jr3_download_firmware(struct comedi_device *dev, · line 453

Quoted 6 lines
drivers/staging/comedi/drivers/jr3_pci.c +2 -1
@@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
 	return 0;
 }
 
-static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
+static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
+							*s)

Be reasonable, this is now looks worse than the code did before, just leave this as-is, coding style is a guideline, not hard rules.

thanks,

greg k-h

#5 lore raw

Re: [PATCH v1 2/2] Staging: comedi: fix line over 80 characters warning

In reply to jitendra kumar khasdev
Quoted 15 lines · jitendra kumar khasdev

This is patch to file jr3_pci.c that fix up warning line
over 80 character which is found by checkpatch tool. Made change into signature of struct jr3_pci_poll_delay jr3_pci_poll_subdevice function by giving a newline so that 80 character line over warning to be reduced.

Signed-off-by Jitendra Kumar Khasdev <[email protected]>
---
  drivers/staging/comedi/drivers/jr3_pci.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/comedi/drivers/jr3_pci.c +0 -0
index 81fab2d..1de843d 100644

drivers/staging/comedi/drivers/jr3_pci.c static int jr3_download_firmware(struct comedi_device *dev, · line 453

Quoted 6 lines
drivers/staging/comedi/drivers/jr3_pci.c +2 -1
@@ -449,7 +449,8 @@ static int jr3_download_firmware(struct comedi_device *dev,
  	return 0;
  }
 
-static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)
+static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice
+							*s)

I think it looks better wrapped like this:

static struct jr3_pci_poll_delay jr3_pci_poll_subdevice(struct comedi_subdevice *s)

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-