gpio: sysfs: fix memory leaks

Here are two more fixes for long-standing memory leaks in the gpio sysfs interface (for v3.19).

Johan

Johan Hovold (2):
gpio: sysfs: fix memory leak in gpiod_export_link
gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low

 drivers/gpio/gpiolib-sysfs.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

2.0.5

Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when creating a link.

using sysfs links")

---
 drivers/gpio/gpiolib-sysfs.c | 1 +
 1 file changed, 1 insertion(+)

index 14c4f94813eb..820b1e70ddfe 100644
@@ -648,6 +648,7 @@ int gpiod_export_link(struct device *dev, const char *name,
 		if (tdev != NULL) {
 			status = sysfs_create_link(&dev->kobj, &tdev->kobj,
 						name);
+			put_device(tdev);
 		} else {
 			status = -ENODEV;
 		}

2.0.5

Patch applied.

Let's see if I get it into v3.19 properly...

Yours,
Linus Walleij

Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when setting the gpio-line polarity.

in sysfs")

---
 drivers/gpio/gpiolib-sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

index 820b1e70ddfe..4908d09873e5 100644
@@ -696,7 +696,7 @@ int gpiod_sysfs_set_active_low(struct gpio_desc *desc, int value)
 	}
 
 	status = sysfs_set_active_low(desc, dev, value);
-
+	put_device(dev);
 unlock:
 	mutex_unlock(&sysfs_lock);
 

2.0.5

Patch applied.

Yours,
Linus Walleij