Configure flag clean up

PATCH New Steve Dickson 1 participant 5 messages Jan 28, 2015 – Jan 29, 2015

Subsystems (2)

NFS client NFS server

lore

Share & tools

lore

Steve Dickson

author

2015-01-29 01:07 UTC #0 lore raw

cover Configure flag clean up

Here are a few patches the change some default values and rearrange a few flags as well as added some default values to flag descriptions.

Question: Does anybody know what this flag came from?
--enable-kprefix install progs as rpc.knfsd etc

I can't see where or how it is used? I would like to get ride of it.

Also would it cause problems if I enable the linking
of libmount to be on by default?
Basically changing
--enable-libmount-mount Link mount.nfs with libmount [default=no]
to
--disable-libmount-mount Link mount.nfs with libmount [default=no]

Thoughts?

Steve Dickson (4):
ipv6: Enable IPv6 support by default.
svcgssd: Disable support for the rpcsec_gss server by default configure.ac: clean up
configure.ac: More clean up

 configure.ac | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)

Signature · 1 line

2.1.0

Steve Dickson

author

2015-01-28 20:54 UTC #1 lore raw

PATCH 1/4 ipv6: Enable IPv6 support by default.

Enable IPv6 support to be on by default. Use
the --disable-ipv6 flag to disable the support

Signed-off-by Steve Dickson <[email protected]>

---
 configure.ac | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

configure.ac +3 -3

index 6740fda..72055be 100644
@@ -171,10 +171,10 @@ AC_ARG_ENABLE(tirpc,
 	enable_tirpc=$enableval,
 	enable_tirpc='')
 AC_ARG_ENABLE(ipv6,
-	[AC_HELP_STRING([--enable-ipv6],
-                        [enable support for IPv6 @<:@default=no@:>@])],
+	[AC_HELP_STRING([--disable-ipv6],
+                        [disable support for IPv6 @<:@default=no@:>@])],
 	enable_ipv6=$enableval,
-	enable_ipv6=no)
+	enable_ipv6=yes)
 	if test "$enable_ipv6" = yes; then
 		AC_DEFINE(IPV6_SUPPORTED, 1, [Define this if you want IPv6 support compiled in])
 	else

Signature · 1 line

2.1.0

Steve Dickson

author

2015-01-28 20:40 UTC #2 lore raw

PATCH 2/4 svcgssd: Disable support for the rpcsec_gss server by default

In reply to Steve Dickson

At this point the gssproxy is better option than the svcgssd so the support is off by default.

Use --enable-svcgss to re-enable the support

Signed-off-by Steve Dickson <[email protected]>

---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

configure.ac +2 -2

index 72055be..3feb0b3 100644
@@ -115,9 +115,9 @@ AC_ARG_ENABLE(gss,
 
 AC_ARG_ENABLE(svcgss,
 	[AC_HELP_STRING([--enable-svcgss],
-    [enable building svcgssd for rpcsec_gss server support @<:@default=yes@:>@])],
+    [enable building svcgssd for rpcsec_gss server support @<:@default=no@:>@])],
 	enable_svcgss=$enableval,
-	enable_svcgss=yes)
+	enable_svcgss=no)
 	if test "$enable_gss" = yes -a "$enable_svcgss" = yes; then
 		SVCGSSD=svcgssd
 	else

Signature · 1 line

2.1.0

Steve Dickson

author

2015-01-28 20:56 UTC #3 lore raw

PATCH 3/4 configure.ac: clean up

In reply to Steve Dickson

Reworked the configuration flags. If the default
is on the used --disable to turn off. If the
default is off use --enable to turn on.

Signed-off-by Steve Dickson <[email protected]>

---
 configure.ac | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

configure.ac +13 ~~-13~~

index 3feb0b3..f27b46e 100644
@@ -66,8 +66,8 @@ AC_ARG_WITH(systemd,
 	AC_SUBST(unitdir)
 
 AC_ARG_ENABLE(nfsv4,
-	[AC_HELP_STRING([--enable-nfsv4],
-                        [enable support for NFSv4 @<:@default=yes@:>@])],
+	[AC_HELP_STRING([--disable-nfsv4],
+                        [disable support for NFSv4 @<:@default=no@:>@])],
 	enable_nfsv4=$enableval,
 	enable_nfsv4=yes)
 	if test "$enable_nfsv4" = yes; then

@@ -81,8 +81,8 @@ AC_ARG_ENABLE(nfsv4,
 	AM_CONDITIONAL(CONFIG_NFSV4, [test "$enable_nfsv4" = "yes"])
 
 AC_ARG_ENABLE(nfsv41,
-	[AC_HELP_STRING([--enable-nfsv41],
-                        [enable support for NFSv41 @<:@default=yes@:>@])],
+	[AC_HELP_STRING([--disable-nfsv41],
+                        [disable support for NFSv41 @<:@default=no@:>@])],
 	enable_nfsv41=$enableval,
 	enable_nfsv41=yes)
 	if test "$enable_nfsv41" = yes; then

@@ -99,8 +99,8 @@ AC_ARG_ENABLE(nfsv41,
 	AM_CONDITIONAL(CONFIG_NFSV41, [test "$enable_nfsv41" = "yes"])
 
 AC_ARG_ENABLE(gss,
-	[AC_HELP_STRING([--enable-gss],
-              [enable client support for rpcsec_gss @<:@default=yes@:>@])],
+	[AC_HELP_STRING([--disable-gss],
+              [disable client support for rpcsec_gss @<:@default=no@:>@])],
 	enable_gss=$enableval,
 	enable_gss=yes)
 	if test "$enable_gss" = yes; then

@@ -151,8 +151,8 @@ AC_ARG_ENABLE(uuid,
 	if test "$enableval" = "yes" ; then choose_blkid=yes; else choose_blkid=no; fi,
 	choose_blkid=default)
 AC_ARG_ENABLE(mount,
-	[AC_HELP_STRING([--enable-mount],
-			[Create mount.nfs and do not use the util-linux mount(8) functionality. @<:@default=yes@:>@])],
+	[AC_HELP_STRING([--disable-mount],
+		[Don't build mount.nfs and do use the util-linux mount(8) functionality. @<:@default=no@:>@])],
 	enable_mount=$enableval,
 	enable_mount=yes)
 	AM_CONDITIONAL(CONFIG_MOUNT, [test "$enable_mount" = "yes"])

@@ -166,10 +166,10 @@ if test "$enable_mount" = yes; then
 fi
 
 AC_ARG_ENABLE(tirpc,
-	[AC_HELP_STRING([--enable-tirpc],
-			[enable use of TI-RPC @<:@default=yes@:>@])],
+	[AC_HELP_STRING([--disable-tirpc],
+			[disable use of TI-RPC library @<:@default=no@:>@])],
 	enable_tirpc=$enableval,
-	enable_tirpc='')
+	enable_tirpc=yes)
 AC_ARG_ENABLE(ipv6,
 	[AC_HELP_STRING([--disable-ipv6],
                         [disable support for IPv6 @<:@default=no@:>@])],

@@ -211,8 +211,8 @@ else
 fi
 
 AC_ARG_ENABLE(nfsdcltrack,
-	[AC_HELP_STRING([--enable-nfsdcltrack],
-			[enable NFSv4 clientid tracking programs @<:@default=yes@:>@])],
+	[AC_HELP_STRING([--disable-nfsdcltrack],
+			[disable NFSv4 clientid tracking programs @<:@default=no@:>@])],
 	enable_nfsdctrack=$enableval,
 	enable_nfsdcltrack="yes")

Signature · 1 line

2.1.0

Steve Dickson

author

2015-01-28 20:54 UTC #4 lore raw

PATCH 4/4 configure.ac: More clean up

In reply to Steve Dickson

Added a couple default values to the flag descriptions

Signed-off-by Steve Dickson <[email protected]>

---
 configure.ac | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

configure.ac +3 -2

index f27b46e..f667abe 100644
@@ -147,7 +147,8 @@ AC_ARG_WITH(rpcgen,
 	AC_SUBST(RPCGEN_PATH)
 	AM_CONDITIONAL(CONFIG_RPCGEN, [test "$RPCGEN_PATH" = ""])
 AC_ARG_ENABLE(uuid,
-	[AC_HELP_STRING([--disable-uuid], [Exclude uuid support to avoid buggy libblkid])],
+	[AC_HELP_STRING([--disable-uuid], 
+		[Exclude uuid support to avoid buggy libblkid. @<:@default=no@:>@])],
 	if test "$enableval" = "yes" ; then choose_blkid=yes; else choose_blkid=no; fi,
 	choose_blkid=default)
 AC_ARG_ENABLE(mount,

@@ -160,7 +161,7 @@ AC_ARG_ENABLE(mount,
 if test "$enable_mount" = yes; then
 	AC_ARG_ENABLE(libmount-mount,
 		[AC_HELP_STRING([--enable-libmount-mount],
-				[Link mount.nfs with libmount (EXPERIMENTAL)])],
+				[Link mount.nfs with libmount @<:@default=no@:>@])],
 		enable_libmount=$enableval,
 		enable_libmount=no)
 fi

Signature · 1 line

2.1.0