irqchip: gic: Don't complain in gic_get_cpumask() if UP system
Subsystems (2)
PATCH 1/1 irqchip: gic: Don't complain in gic_get_cpumask() if UP system
In a uniprocessor implementation the interrupt processor targets registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately gic_get_cpumask() will print a critical message saying
GIC CPU mask not found - kernel will fail to boot.
if these registers all read as zero, but there won't actually be a problem on uniprocessor systems and the kernel will boot just fine. Skip this check if we're running a UP kernel or if we detect that the hardware only supports a single processor.
--- drivers/irqchip/irq-gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/irqchip/irq-gic.c +1 -1
@@ -346,7 +346,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)break ; } -if (!mask) +if (!mask &&num_possible_cpus () >1 )pr_crit ("GIC CPU mask not found - kernel will fail to boot.\n" );return mask;
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
+linux-omap
Quoted 11 lines · Stephen Boyd
In a uniprocessor implementation the interrupt processor targets registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately
gic_get_cpumask()will print a critical message sayingGIC CPU mask not found - kernel will fail to boot.
if these registers all read as zero, but there won't actually be a problem on uniprocessor systems and the kernel will boot just fine. Skip this check if we're running a UP kernel or if we detect that the hardware only supports a single processor.
Nice, I'll test this on AM437x on Monday but certainly looks promising:
Quoted 30 lines
Acked-by Nicolas Pitre <[email protected]>Cc Russell King <[email protected]>Cc Stefan Agner <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/irqchip/irq-gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/irqchip/irq-gic.c +1
-1@@ -346,7 +346,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)break ; } -if (!mask) +if (!mask &&num_possible_cpus () >1 )pr_crit ("GIC CPU mask not found - kernel will fail to boot.\n" );return mask;Signature · 8 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Signature · 8 lines
balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150131/7eb07cdf/attachment.sig>
Nishanth Menon
Acked-byQuoted 45 lines · Felipe Balbi
+linux-omap
Quoted 11 lines · Stephen Boyd
In a uniprocessor implementation the interrupt processor targets registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately
gic_get_cpumask()will print a critical message sayingGIC CPU mask not found - kernel will fail to boot.
if these registers all read as zero, but there won't actually be a problem on uniprocessor systems and the kernel will boot just fine. Skip this check if we're running a UP kernel or if we detect that the hardware only supports a single processor.
Nice, I'll test this on AM437x on Monday but certainly looks promising:
Acked-by Felipe Balbi <[email protected]>Quoted 25 lines
Acked-by Nicolas Pitre <[email protected]>Cc Russell King <[email protected]>Cc Stefan Agner <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/irqchip/irq-gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/irqchip/irq-gic.c +1
-1@@ -346,7 +346,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)break ; } -if (!mask) +if (!mask &&num_possible_cpus () >1 )pr_crit ("GIC CPU mask not found - kernel will fail to boot.\n" );return mask;Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Quoted 8 lines
Quoted 5 lines
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/Signature · 1 line
balbi
Signature · 2 lines
Regards, Nishanth Menon
Quoted 10 lines · Stephen Boyd
In a uniprocessor implementation the interrupt processor targets registers are read-as-zero/write-ignored (RAZ/WI). Unfortunately
gic_get_cpumask()will print a critical message sayingGIC CPU mask not found - kernel will fail to boot.
if these registers all read as zero, but there won't actually be a problem on uniprocessor systems and the kernel will boot just fine. Skip this check if we're running a UP kernel or if we detect that the hardware only supports a single processor.
Does the job for my device too, thx.
Quoted 22 lines
Acked-by Nicolas Pitre <[email protected]>Cc Russell King <[email protected]>Cc Stefan Agner <[email protected]>Signed-off-by Stephen Boyd <[email protected]>--- drivers/irqchip/irq-gic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/irqchip/irq-gic.c +1
-1@@ -346,7 +346,7 @@ static u8 gic_get_cpumask(struct gic_chip_data *gic)break ; } -if (!mask) +if (!mask &&num_possible_cpus () >1 )pr_crit ("GIC CPU mask not found - kernel will fail to boot.\n" );return mask;