Skip to contentSkip to conversation

Input: drv260x - Remove wrong and unneeded drv260x-haptics modalias

PATCH Applied Axel Lin 2 participants 3 messages Jan 31, 2015 – Feb 1, 2015

Subsystems (2)
HID Input drivers
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH 1/2 Input: drv260x - Remove wrong and unneeded drv260x-haptics modalias

This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded drv260x-haptics modalias.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/input/misc/drv260x.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/misc/drv260x.c +0 -1
index a364e10..5995780 100644
@@ -733,7 +733,6 @@ static struct i2c_driver drv260x_driver = {
 };
 module_i2c_driver(drv260x_driver);
 
-MODULE_ALIAS("platform:drv260x-haptics");
 MODULE_DESCRIPTION("TI DRV260x haptics driver");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Dan Murphy <[email protected]>");
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias

This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded drv2667-haptics modalias.

Signed-off-by Axel Lin <[email protected]>
---
 drivers/input/misc/drv2667.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/misc/drv2667.c +0 -1
index a021744..fc0fddf 100644
@@ -492,7 +492,6 @@ static struct i2c_driver drv2667_driver = {
 };
 module_i2c_driver(drv2667_driver);
 
-MODULE_ALIAS("platform:drv2667-haptics");
 MODULE_DESCRIPTION("TI DRV2667 haptics driver");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Dan Murphy <[email protected]>");
Signature · 1 line
1.9.1
maintainer Applied
#2 lore raw

Re: [PATCH 2/2] Input: drv2667 - Remove wrong and unneeded drv2667-haptics modalias

Quoted 5 lines · Axel Lin

This is a I2C driver, so it's wrong to use platform prefix for the modalias. We have all needed i2c aliases coming form MODULE_DEVICE_TABLE, so remove the wrong and unneeded drv2667-haptics modalias.

Signed-off-by Axel Lin <[email protected]>

Applied both, thank you.

Quoted 21 lines
---
 drivers/input/misc/drv2667.c | 1 -
 1 file changed, 1 deletion(-)
drivers/input/misc/drv2667.c +0 -1
index a021744..fc0fddf 100644
@@ -492,7 +492,6 @@ static struct i2c_driver drv2667_driver = {
 };
 module_i2c_driver(drv2667_driver);
 
-MODULE_ALIAS("platform:drv2667-haptics");
 MODULE_DESCRIPTION("TI DRV2667 haptics driver");
 MODULE_LICENSE("GPL");
 MODULE_AUTHOR("Dan Murphy <[email protected]>");
Signature · 1 line
1.9.1
Signature · 1 line
Dmitry