Skip to contentSkip to conversation

gpio: at91: Fix getting address of private data

PATCH New Axel Lin 2 participants 3 messages Jan 31, 2015 – Feb 6, 2015

Subsystems (2)
GPIO Arm/Microchip (AT91) SoC support
lore
Share & tools
lore

Axel Lin

author
#0 lore raw

PATCH v2 1/1 gpio: at91: Fix getting address of private data

Use dev_get_priv() rather than dev_get_platdata() to get correct address of private data.

Signed-off-by Axel Lin <[email protected]>

---
v2: Fix an obvious typo in subject line (s/addres/address).

 drivers/gpio/at91_gpio.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/gpio/at91_gpio.c +5 -5
index 6129c02..22fbd63 100644
@@ -451,7 +451,7 @@ struct at91_port_priv {
 /* set GPIO pin 'gpio' as an input */
 static int at91_gpio_direction_input(struct udevice *dev, unsigned offset)
 {
-	struct at91_port_priv *port = dev_get_platdata(dev);
+	struct at91_port_priv *port = dev_get_priv(dev);
 
 	at91_set_port_input(port->regs, offset, 0);
 

@@ -462,7 +462,7 @@ static int at91_gpio_direction_input(struct udevice *dev, unsigned offset)
 static int at91_gpio_direction_output(struct udevice *dev, unsigned offset,
 				       int value)
 {
-	struct at91_port_priv *port = dev_get_platdata(dev);
+	struct at91_port_priv *port = dev_get_priv(dev);
 
 	at91_set_port_output(port->regs, offset, value);
 

@@ -472,7 +472,7 @@ static int at91_gpio_direction_output(struct udevice *dev, unsigned offset,
 /* read GPIO IN value of pin 'gpio' */
 static int at91_gpio_get_value(struct udevice *dev, unsigned offset)
 {
-	struct at91_port_priv *port = dev_get_platdata(dev);
+	struct at91_port_priv *port = dev_get_priv(dev);
 
 	return at91_get_port_value(port->regs, offset);
 }

@@ -481,7 +481,7 @@ static int at91_gpio_get_value(struct udevice *dev, unsigned offset)
 static int at91_gpio_set_value(struct udevice *dev, unsigned offset,
 			       int value)
 {
-	struct at91_port_priv *port = dev_get_platdata(dev);
+	struct at91_port_priv *port = dev_get_priv(dev);
 
 	at91_set_port_value(port->regs, offset, value);
 

@@ -490,7 +490,7 @@ static int at91_gpio_set_value(struct udevice *dev, unsigned offset,
 
 static int at91_gpio_get_function(struct udevice *dev, unsigned offset)
 {
-	struct at91_port_priv *port = dev_get_platdata(dev);
+	struct at91_port_priv *port = dev_get_priv(dev);
 
 	/* GPIOF_FUNC is not implemented yet */
 	if (at91_get_port_output(port->regs, offset))
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 gpio: at91: Fix getting address of private data

Quoted 8 lines · Axel Lin

Use dev_get_priv() rather than dev_get_platdata() to get correct address of private data.

Signed-off-by Axel Lin <[email protected]>

---
v2: Fix an obvious typo in subject line (s/addres/address).

 drivers/gpio/at91_gpio.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Acked-by Simon Glass <[email protected]>

Thanks for picking this up. I'll apply it to u-boot-dm soon as a bug fix.

Regards,
Simon

#2 lore raw

PATCH v2 1/1 gpio: at91: Fix getting address of private data

Quoted 10 lines · Simon Glass
Quoted 8 lines · Axel Lin

Use dev_get_priv() rather than dev_get_platdata() to get correct address of private data.

Signed-off-by Axel Lin <[email protected]>

---
v2: Fix an obvious typo in subject line (s/addres/address).

 drivers/gpio/at91_gpio.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
Quoted 3 lines
Acked-by Simon Glass <[email protected]>

Thanks for picking this up. I'll apply it to u-boot-dm soon as a bug fix.

Applied to u-boot-dm, thanks!