Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.
PATCH 1/1 Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.
v1 changes:
* Update the commit id as per Tejun's comments.
* Add a bit explanation.
---
Suman Tripathi (1):
ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO
mode command.
drivers/ata/ahci_xgene.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
--
1.8.2.1
PATCH 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.
This patch addresses the issue with ATA_CMD_SMART pio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters CMFatalErrorUpdate state and locks up. It is the same issue as in the patch(Commit ID : 2a0bdff6b958d1b2523d2754b6cd5e0ea4053016).
---
--- drivers/ata/ahci_xgene.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/ata/ahci_xgene.c +2 -1
@@ -211,7 +211,8 @@ static unsigned int xgene_ahci_qc_issue(struct ata_queued_cmd *qc) }if (unlikely ((ctx->last_cmd[ap->port_no] ==ATA_CMD_ID_ATA ) || - (ctx->last_cmd[ap->port_no] ==ATA_CMD_PACKET ))) + (ctx->last_cmd[ap->port_no] ==ATA_CMD_PACKET ) || + (ctx->last_cmd[ap->port_no] ==ATA_CMD_SMART )))xgene_ahci_restart_engine (ap); rc =ahci_qc_issue (qc);
--
1.8.2.1
PATCH 1/1 ahci_xgene: Fix the dma state machine lockup for the ATA_CMD_SMART PIO mode command.
Hello.
Quoted 6 lines · Suman Tripathi
This patch addresses the issue with
ATA_CMD_SMARTpio mode command for enumeration and device detection with ATA devices. The X-Gene AHCI controller has an errata in which it cannot clear the BSY bit after the PIO setup FIS. The dma state machine enters CMFatalErrorUpdate state and locks up. It is the same issue as in the patch(Commit ID :2a0bdff6b958d1b2523d2754b6cd5e0ea4053016).
Just "in the commit 2a0bdff6b958d1b2523d2754b6cd5e0ea4053016". And you
also need to specify the commit's summary line in parens.
Quoted 1 line
Signed-off-by Suman Tripathi <[email protected]>
WBR, Sergei