Skip to contentSkip to conversation

android/log: Add missing libc includes.

PATCH Superseded Ian Coolidge 2 participants 4 messages Feb 2, 2015 – Feb 3, 2015 Bluetooth drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 android/log: Add missing libc includes.

---
 android/log.c | 3 +++
 1 file changed, 3 insertions(+)
android/log.c +3 -0
index 09d226a..8013eba 100644
@@ -25,7 +25,10 @@
 #endif
 
 #include <fcntl.h>
+#include <stdarg.h>
 #include <stdio.h>
+#include <stdint.h>
+#include <stdlib.h>
 #include <unistd.h>
 #include <stdbool.h>
 #include <time.h>
Signature · 1 line
2.2.0.rc0.207.ga3a616c
#1 lore raw

Hi Ian,

Quoted 9 lines · On Monday 02 of February 2015 00:33:48 Ian Coolidge wrote:
---
 android/log.c | 3 +++
 1 file changed, 3 insertions(+)
android/log.c +0 -0
index 09d226a..8013eba 100644

android/log.c line 34

Quoted 10 lines
android/log.c +3 -0
@@ -25,7 +25,10 @@
 #endif
 
 #include <fcntl.h>
+#include <stdarg.h>
 #include <stdio.h>
+#include <stdint.h>
+#include <stdlib.h>
 #include <unistd.h>
 #include <stdbool.h>
 #include <time.h>

Could you add some explanation to commit message why those are needed?

Signature · 2 lines
Best regards, 
Szymon Janc
#2 lore raw

PATCH v2 1/1 android/log: Add missing libc includes.

Bionic is moving to reduce the amount of transitive includes, so they should not be relied upon.

---
 android/log.c | 3 +++
 1 file changed, 3 insertions(+)
android/log.c +3 -0
index 09d226a..8013eba 100644
@@ -25,7 +25,10 @@
 #endif
 
 #include <fcntl.h>
+#include <stdarg.h>
 #include <stdio.h>
+#include <stdint.h>
+#include <stdlib.h>
 #include <unistd.h>
 #include <stdbool.h>
 #include <time.h>
Signature · 1 line
2.2.0.rc0.207.ga3a616c
#3 lore raw

Hi Ian,

Quoted 12 lines · On Monday 02 of February 2015 11:10:40 Ian Coolidge wrote:

Bionic is moving to reduce the amount of transitive includes, so they should not be relied upon.

---
 android/log.c | 3 +++
 1 file changed, 3 insertions(+)
android/log.c +0 -0
index 09d226a..8013eba 100644

android/log.c line 34

Quoted 10 lines
android/log.c +3 -0
@@ -25,7 +25,10 @@
 #endif
 
 #include <fcntl.h>
+#include <stdarg.h>
 #include <stdio.h>
+#include <stdint.h>
+#include <stdlib.h>
 #include <unistd.h>
 #include <stdbool.h>
 #include <time.h>

Patch applied, thanks.

Signature · 2 lines
Best regards, 
Szymon Janc