Skip to contentSkip to conversation

staging: sm7xxfb: make smtc_scr_info static

PATCH In review Max Perepelitsyn 3 participants 4 messages Feb 3, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: sm7xxfb: make smtc_scr_info static

This symbol is never used anywhere else besides sm7xxfb.c

---
 drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xxfb.c +1 -1
index 2ae9fd0..72036c2 100644
@@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
 	{"0x31B", 1280, 1024, 24},
 };
 
-struct screen_info smtc_scr_info;
+static struct screen_info smtc_scr_info;
 
 /* process command line options, get vga parameter */
 static int __init sm7xx_vga_setup(char *options)
Signature · 1 line
2.2.2
#1 lore raw
Quoted 1 line · Max Perepelitsyn

This symbol is never used anywhere else besides sm7xxfb.c

Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?

regards
sudip

Quoted 22 lines
---
 drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xxfb.c +1 -1
index 2ae9fd0..72036c2 100644
@@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
 	{"0x31B", 1280, 1024, 24},
 };
 
-struct screen_info smtc_scr_info;
+static struct screen_info smtc_scr_info;
 
 /* process command line options, get vga parameter */
 static int __init sm7xx_vga_setup(char *options)
Signature · 1 line
2.2.2
maintainer
#2 lore raw
Quoted 5 lines · Sudip Mukherjee
Quoted 1 line · Max Perepelitsyn

This symbol is never used anywhere else besides sm7xxfb.c

Hi Greg,
do i need to do anything about this patch? maybe a tested-by or reviewed-by?

If you test or review it, yes, please add such a line to an email and reply to the patch with it.

thanks,

greg k-h

Tested-by on v1 1/1
#3 lore raw
In reply to Max Perepelitsyn
Quoted 3 lines · Max Perepelitsyn

This symbol is never used anywhere else besides sm7xxfb.c

Quoted 20 lines
---
 drivers/staging/sm7xxfb/sm7xxfb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/sm7xxfb/sm7xxfb.c +1 -1
index 2ae9fd0..72036c2 100644
@@ -111,7 +111,7 @@ static struct vesa_mode vesa_mode_table[] = {
 	{"0x31B", 1280, 1024, 24},
 };
 
-struct screen_info smtc_scr_info;
+static struct screen_info smtc_scr_info;
 
 /* process command line options, get vga parameter */
 static int __init sm7xx_vga_setup(char *options)
Signature · 1 line
2.2.2