Skip to contentSkip to conversation

ext3: dump dentry in ext3_dx_add_entry

PATCH In review Olaf Hering 2 participants 2 messages Feb 3, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext3: dump dentry in ext3_dx_add_entry

Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>
---
 fs/ext3/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ext3/namei.c +1 -1
index f197736..0692058 100644
@@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
 		if (levels && (dx_get_count(frames->entries) ==
 			       dx_get_limit(frames->entries))) {
 			ext3_warning(sb, __func__,
-				     "Directory index full!");
+				     "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
 			err = -ENOSPC;
 			goto cleanup;
 		}
#1 lore raw
Quoted 13 lines · Olaf Hering
Cc Jan Kara <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Andreas Dilger <[email protected]>
---
 fs/ext3/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/ext3/namei.c +0 -0
index f197736..0692058 100644

fs/ext3/namei.c static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry, · line 1535

Quoted 8 lines
fs/ext3/namei.c +1 -1
@@ -1529,7 +1529,7 @@ static int ext3_dx_add_entry(handle_t *handle, struct dentry *dentry,
 		if (levels && (dx_get_count(frames->entries) ==
 			       dx_get_limit(frames->entries))) {
 			ext3_warning(sb, __func__,
-				     "Directory index full!");
+				     "Directory index full! %pd4 %pd", dentry->d_parent, dentry);
 			err = -ENOSPC;
 			goto cleanup;
 		}

Would you mind to also add the inode number? That way one could use debugfs to figure out the complete path.
And it should be done for ext4 as well.

Cheers,
Bernd