Skip to contentSkip to conversation

fix a leak in bch_cached_dev_run()

PATCH New Joshua Schmid 1 participant 1 message Feb 3, 2015 bcache (block layer cache)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fix a leak in bch_cached_dev_run()

From: Al Viro <[email protected]>

---
 drivers/md/bcache/super.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/md/bcache/super.c +4 -1
index 8c2d657..53f1512 100644
@@ -880,8 +880,11 @@ void bch_cached_dev_run(struct cached_dev *dc)
 	buf[SB_LABEL_SIZE] = '\0';
 	env[2] = kasprintf(GFP_KERNEL, "CACHED_LABEL=%s", buf);
 
-	if (atomic_xchg(&dc->running, 1))
+	if (atomic_xchg(&dc->running, 1)) {
+		kfree(env[1]);
+		kfree(env[2]);
 		return;
+	}
 
 	if (!d->c &&
 	    BDEV_STATE(&dc->sb) != BDEV_STATE_NONE) {
Signature · 1 line
2.1.2