Skip to contentSkip to conversation

sprd_serial: compile sprd_suspend and sprd_resume conditionally

PATCH New Paul Bolle 1 participant 1 message Feb 3, 2015

Subsystems (2)
lore
Share & tools
lore

Paul Bolle

author
#0 lore raw

PATCH 1/1 sprd_serial: compile sprd_suspend and sprd_resume conditionally

Building sprd_serial.o when CONFIG_PM_SLEEP is not defined triggers
these warnings:
drivers/tty/serial/sprd_serial.c:755:12: warning: ‘sprd_suspend’ defined but not used [-Wunused-function]
static int sprd_suspend(struct device *dev)
^
drivers/tty/serial/sprd_serial.c:764:12: warning: ‘sprd_resume’ defined but not used [-Wunused-function]
static int sprd_resume(struct device *dev)
^

Let's compile these functions only when CONFIG_PM_SLEEP is defined.

---
The only reason I looked into this driver is because it landed in today's linux-next (ie, next-20150203) and depends on ARCH_SPRD. ARCH_SPRD is not yet included in linux-next. Since there was a patch submitted on lkml recently to add that symbol that's not a big deal. (That might change if that symbol doesn't make it into v3.20-rc[123] or so.) But I did compile this file while looking into this issue.

Compile tested only, on x86_64, using the hacky
make drivers/tty/serial/sprd_serial.o

way to compile this file!

 drivers/tty/serial/sprd_serial.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/tty/serial/sprd_serial.c +2 -0
index 594b63331ef4..be3ed3f4ad60 100644
@@ -752,6 +752,7 @@ static int sprd_probe(struct platform_device *pdev)
 	return ret;
 }
 
+#ifdef CONFIG_PM_SLEEP
 static int sprd_suspend(struct device *dev)
 {
 	struct sprd_uart_port *sup = dev_get_drvdata(dev);
@@ -769,6 +770,7 @@ static int sprd_resume(struct device *dev)
 
 	return 0;
 }
+#endif
 
 static SIMPLE_DEV_PM_OPS(sprd_pm_ops, sprd_suspend, sprd_resume);
 
Signature · 1 line
1.9.3