Add missing indirect dependencies
cover Add missing indirect dependencies
With the fix for randconfig that I made in
http://patchwork.ozlabs.org/patch/432554/ it is now possible to run 'make randconfig' and get usable results. So I ran the following loop to detect missing indirect dependencies:
while true; do make randconfig 2>&1 | grep warning; done
If there is a missing indirect dependency, this will output a line like:
warning: (BR2_PACKAGE_UTIL_LINUX_SETPRIV) selects BR2_PACKAGE_LIBCAP_NG which has unmet direct dependencies (!BR2_avr32)
After this series, I ran about 6000 randconfigs and didn't encounter any
warning anymore.
It would be good to include such a test in a jenkins job to detect this
type of error earlier.
Regards,
Arnout
----------------------------------------------------------------
Arnout Vandecappelle (Essensium/Mind) (21):
python-coherence: add missing indirect dependency on c++
gst-plugins-bad: add missing indirect dependency on atomics for rsvg
gst1-plugins-bad: add missing indirect dependency on atomics for rsvg
gst-plugins-base: add missing indirect dependency on atomics for pango
gst1-plugins-base: add missing indirect dependency on atomics for pango
qemu: add missing indirect dependency on dynamic library for fdt
grantlee: add missing indirect dependency on jscore available
libgail: add missing indirect dependency on C++ and atomics
espeak: add missing indirect dependency on atomics for pulseaudio
kodi: add missing indirect dependency on dynamic lib for shairport
oprofile: add missing indirect dependency on NPTL for PPC
util-linux: add missing indirect dependency on !avr32 for setpriv
dovecot: add missing indirect dependency on !avr32 for mysql
php: add missing indirect dependency on !avr32 for mysql extensions
cwiid: add missing indirect dependency on atomics for wmgui
opencv: add missing indirect dependency on atomics for gtk support
pinenty: add missing indirect dependency on atomics for gtk2 support
xscreensaver: add missing indirect dependency on atomics
enlightenment: add missing indirect dependency on atomics
qt5cinex: add missing indirect dependency on libegl
qt5webkit: add missing indirect dependency on atomics and !flat
package/cwiid/Config.in | 6 ++++++ package/dovecot/Config.in | 6 ++++-- package/enlightenment/Config.in | 3 +++ package/espeak/Config.in | 4 +++- package/grantlee/Config.in | 6 ++++-- package/gstreamer/gst-plugins-bad/Config.in | 11 +++++------ package/gstreamer/gst-plugins-base/Config.in | 10 ++++------ package/gstreamer1/gst1-plugins-bad/Config.in | 11 +++++------ package/gstreamer1/gst1-plugins-base/Config.in | 10 ++++------ package/kodi/Config.in | 4 ++++ package/libgail/Config.in | 7 +++++-- package/opencv/Config.in | 1 + package/oprofile/Config.in | 4 ++-- package/php/Config.ext | 8 ++++++-- package/pinentry/Config.in | 6 ++---- package/python-coherence/Config.in | 5 +++++ package/qemu/Config.in | 8 ++++++++ package/qt5/qt5webkit/Config.in | 2 ++ package/qt5cinex/Config.in | 5 +++-- package/util-linux/Config.in | 1 + package/xscreensaver/Config.in | 13 ++++++++----- 21 files changed, 85 insertions(+), 46 deletions(-)
PATCH 1/21 python-coherence: add missing indirect dependency on c++
--- package/python-coherence/Config.in | 5 +++++ 1 file changed, 5 insertions(+)
package/python-coherence/Config.in +5 -0
@@ -1,6 +1,7 @@ config BR2_PACKAGE_PYTHON_COHERENCE bool "python-coherence" depends on BR2_PACKAGE_PYTHON + depends on BR2_INSTALL_LIBSTDCPP # python-pyasn select BR2_PACKAGE_PYTHON_TWISTED select BR2_PACKAGE_PYTHON_ZOPE_INTERFACE select BR2_PACKAGE_PYTHON_PYASN
@@ -8,3 +9,7 @@ config BR2_PACKAGE_PYTHON_COHERENCE A DLNA/UPnP Media Server and Framework for the Digital Living. http://coherence-project.org/ + +comment "python-coherence needs a toolchain w/ C++" + depends on BR2_PACKAGE_PYTHON + depends on !BR2_INSTALL_LIBSTDCPP
Signature · 1 line
2.1.4
PATCH 2/21 gst-plugins-bad: add missing indirect dependency on atomics for rsvg
In reply to Arnout Vandecappelle (Essensium/Mind)Also removed the redundant indirect dependencies on wchar, threads (gstreamer depends on libglib2 so this indirect dependency is obvious).
--- package/gstreamer/gst-plugins-bad/Config.in | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
package/gstreamer/gst-plugins-bad/Config.in +5 -6
@@ -297,14 +297,13 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_OPUS config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_RSVG bool "rsvg" - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_USE_WCHAR # librsvg -> libglib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> libglib2 + depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango + depends on BR2_ARCH_HAS_ATOMICS # librsvg -> cairo select BR2_PACKAGE_LIBRSVG -comment "rsvg plugin needs a toolchain w/ C++, wchar, threads" - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS +comment "rsvg plugin needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_ARCH_HAS_ATOMICS config BR2_PACKAGE_GST_PLUGINS_BAD_PLUGIN_SDL bool "sdl"
Signature · 1 line
2.1.4
PATCH 3/21 gst1-plugins-bad: add missing indirect dependency on atomics for rsvg
In reply to Arnout Vandecappelle (Essensium/Mind)Also removed the redundant indirect dependencies on wchar, threads (gstreamer depends on libglib2 so this indirect dependency is obvious).
--- package/gstreamer1/gst1-plugins-bad/Config.in | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
package/gstreamer1/gst1-plugins-bad/Config.in +5 -6
@@ -460,16 +460,15 @@ config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_OPUS config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_RSVG bool "rsvg" - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_USE_WCHAR # librsvg -> glib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # librsvg -> glib2 + depends on BR2_INSTALL_LIBSTDCPP # librsvg -> pango + depends on BR2_ARCH_HAS_ATOMICS # librsvg -> cairo select BR2_PACKAGE_LIBRSVG help RSVG plugin library -comment "rsvg plugin needs a toolchain w/ C++, wchar, threads" - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS +comment "rsvg plugin needs a toolchain w/ C++" + depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_ARCH_HAS_ATOMICS config BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_SDL bool "sdl"
Signature · 1 line
2.1.4
PATCH 4/21 gst-plugins-base: add missing indirect dependency on atomics for pango
In reply to Arnout Vandecappelle (Essensium/Mind)Also removed the redundant indirect dependencies on wchar, threads, mmu (gstreamer depends on libglib2 so this indirect dependency is obvious).
--- package/gstreamer/gst-plugins-base/Config.in | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
package/gstreamer/gst-plugins-base/Config.in +4 -6
@@ -84,15 +84,13 @@ config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_OGG config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_PANGO bool "pango font renderer" - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_USE_WCHAR # pango -> libglib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> libglib2 - depends on BR2_USE_MMU # pango -> glib2 + depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype + depends on BR2_ARCH_HAS_ATOMICS # pango -> cairo select BR2_PACKAGE_PANGO comment "pango plugin needs a toolchain w/ C++, wchar, threads" - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_ARCH_HAS_ATOMICS config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_THEORA bool "theora (*.ogg video)"
Signature · 1 line
2.1.4
PATCH 4/21 gst-plugins-base: add missing indirect dependency on atomics for pango
Hi Arnout,
Quoted 15 lines
Also removed the redundant indirect dependencies on wchar, threads, mmu (gstreamer depends on libglib2 so this indirect dependency is obvious).
--- package/gstreamer/gst-plugins-base/Config.in | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)package/gstreamer/gst-plugins-base/Config.in +0
-0@@ -84,15 +84,13 @@ config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_OGG config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_PANGO
package/gstreamer/gst-plugins-base/Config.in config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_OGG · line 91
Quoted 10 lines
package/gstreamer/gst-plugins-base/Config.in +2
-4bool "pango font renderer" - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_USE_WCHAR # pango -> libglib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> libglib2 - depends on BR2_USE_MMU # pango -> glib2 + depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype + depends on BR2_ARCH_HAS_ATOMICS # pango -> cairo select BR2_PACKAGE_PANGO comment "pango plugin needs a toolchain w/ C++, wchar, threads"
Shouldn't this be
comment "pango plugin needs a toolchain w/ C++"
Regards,
Jerzy
Quoted 7 lines
package/gstreamer/gst-plugins-base/Config.in +2
-2- depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_ARCH_HAS_ATOMICS config BR2_PACKAGE_GST_PLUGINS_BASE_PLUGIN_THEORA bool "theora (*.ogg video)"
PATCH 5/21 gst1-plugins-base: add missing indirect dependency on atomics for pango
In reply to Arnout Vandecappelle (Essensium/Mind)Also removed the redundant indirect dependencies on wchar, threads, mmu (gstreamer depends on libglib2 so this indirect dependency is obvious).
--- package/gstreamer1/gst1-plugins-base/Config.in | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)
package/gstreamer1/gst1-plugins-base/Config.in +4 -6
@@ -128,17 +128,15 @@ config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO bool "pango font renderer" - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_USE_WCHAR # pango -> libglib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> libglib2 - depends on BR2_USE_MMU # pango -> libglib2 + depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype + depends on BR2_ARCH_HAS_ATOMICS # pango -> cairo select BR2_PACKAGE_PANGO help Pango-based text rendering and overlay comment "pango plugin needs a toolchain w/ C++, wchar, threads" - depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_ARCH_HAS_ATOMICS config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA bool "theora (*.ogg video)"
Signature · 1 line
2.1.4
PATCH 5/21 gst1-plugins-base: add missing indirect dependency on atomics for pango
Hi Arnout,
Quoted 17 lines
Also removed the redundant indirect dependencies on wchar, threads, mmu (gstreamer depends on libglib2 so this indirect dependency is obvious).
--- package/gstreamer1/gst1-plugins-base/Config.in | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-)package/gstreamer1/gst1-plugins-base/Config.in +0
-1@@ -128,17 +128,15 @@ config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PANGO bool "pango font renderer" - depends on BR2_INSTALL_LIBSTDCPP
package/gstreamer1/gst1-plugins-base/Config.in config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_OGG · line 137
Quoted 10 lines
package/gstreamer1/gst1-plugins-base/Config.in +2
-3- depends on BR2_USE_WCHAR # pango -> libglib2 - depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> libglib2 - depends on BR2_USE_MMU # pango -> libglib2 + depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype + depends on BR2_ARCH_HAS_ATOMICS # pango -> cairo select BR2_PACKAGE_PANGO help Pango-based text rendering and overlay comment "pango plugin needs a toolchain w/ C++, wchar, threads"
Same here
comment "pango plugin needs a toolchain w/ C++"
Regards,
Jerzy
Quoted 7 lines
package/gstreamer1/gst1-plugins-base/Config.in +2
-2- depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \ - !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_INSTALL_LIBSTDCPP + depends on BR2_ARCH_HAS_ATOMICS config BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_THEORA bool "theora (*.ogg video)"
PATCH 6/21 qemu: add missing indirect dependency on dynamic library for fdt
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/qemu/Config.in | 8 ++++++++ 1 file changed, 8 insertions(+)
package/qemu/Config.in +8 -0
@@ -54,10 +54,14 @@ comment "... or you can select emulator families to enable, below:" config BR2_PACKAGE_QEMU_SYSTEM bool "Enable all systems emulation" + depends on !BR2_STATIC_LIBS # dtc select BR2_PACKAGE_QEMU_FDT help Say 'y' to build all system emulators/virtualisers that QEMU supports. +comment "systems emulation needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS + config BR2_PACKAGE_QEMU_LINUX_USER bool "Enable all Linux user-land emulation" help
@@ -86,11 +90,15 @@ comment "Misc. features" config BR2_PACKAGE_QEMU_FDT bool "Enable FDT" + depends on !BR2_STATIC_LIBS # dtc select BR2_PACKAGE_DTC help Say 'y' here to have QEMU capable of constructing Device Trees, and passing them to the VMs. +comment "FDT support needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS + endif # BR2_PACKAGE_QEMU_HAS_EMULS endif # BR2_PACKAGE_QEMU
Signature · 1 line
2.1.4
PATCH 7/21 grantlee: add missing indirect dependency on jscore available
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/grantlee/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/grantlee/Config.in +4 -2
@@ -1,7 +1,8 @@ config BR2_PACKAGE_GRANTLEE bool "grantlee" depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # Qt Script - depends on (BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT && BR2_PACKAGE_QT) || BR2_PACKAGE_QT5 + depends on (BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT && BR2_PACKAGE_QT) || \ + (BR2_PACKAGE_QT5_JSCORE_AVAILABLE && BR2_PACKAGE_QT5) select BR2_PACKAGE_QT_STL if BR2_PACKAGE_QT select BR2_PACKAGE_QT_SCRIPT if BR2_PACKAGE_QT select BR2_PACKAGE_QT_GUI_MODULE if BR2_PACKAGE_QT
@@ -14,4 +15,5 @@ config BR2_PACKAGE_GRANTLEE comment "grantlee needs a toolchain with NPTL" depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL - depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT || BR2_PACKAGE_QT5 + depends on (BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT && BR2_PACKAGE_QT) || \ + (BR2_PACKAGE_QT5_JSCORE_AVAILABLE && BR2_PACKAGE_QT5)
Signature · 1 line
2.1.4
PATCH 8/21 libgail: add missing indirect dependency on C++ and atomics
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/libgail/Config.in | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
package/libgail/Config.in +5 -2
@@ -3,6 +3,8 @@ config BR2_PACKAGE_LIBGAIL depends on BR2_USE_WCHAR # pango -> libglib2 depends on BR2_TOOLCHAIN_HAS_THREADS # pango -> libglib2 depends on BR2_USE_MMU # pango -> libglib2 + depends on BR2_INSTALL_LIBSTDCPP # pango -> freetype + depends on BR2_ARCH_HAS_ATOMICS # pango -> cairo depends on BR2_PACKAGE_LIBGTK2 select BR2_PACKAGE_PANGO help
@@ -20,7 +22,8 @@ config BR2_PACKAGE_LIBGAIL http://developer.gnome.org/projects/gap -comment "libgail needs a toolchain w/ wchar, threads" +comment "libgail needs a toolchain w/ C++, wchar, threads" depends on BR2_PACKAGE_LIBGTK2 - depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU + depends on BR2_ARCH_HAS_ATOMICS
Signature · 1 line
2.1.4
PATCH 9/21 espeak: add missing indirect dependency on atomics for pulseaudio
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/espeak/Config.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
package/espeak/Config.in +3 -1
@@ -30,11 +30,13 @@ config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_ALSA config BR2_PACKAGE_ESPEAK_AUDIO_BACKEND_PULSEAUDIO bool "pulseaudio" - select BR2_PACKAGE_PULSEAUDIO depends on BR2_LARGEFILE # pulseaudio + depends on BR2_ARCH_HAS_ATOMICS # pulseaudio + select BR2_PACKAGE_PULSEAUDIO comment "pulseaudio backend needs a toolchain with largefile" depends on !BR2_LARGEFILE + depends on BR2_ARCH_HAS_ATOMICS endchoice
Signature · 1 line
2.1.4
PATCH 10/21 kodi: add missing indirect dependency on dynamic lib for shairport
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/kodi/Config.in | 4 ++++ 1 file changed, 4 insertions(+)
package/kodi/Config.in +4 -0
@@ -194,11 +194,15 @@ config BR2_PACKAGE_KODI_RTMPDUMP config BR2_PACKAGE_KODI_LIBSHAIRPLAY bool "shairport" + depends on !BR2_STATIC_LIBS # libshairplay -> avahi select BR2_PACKAGE_LIBSHAIRPLAY help Enable Shairport support. Select this if you want to stream content from an Apple device. +comment "shairport support needs a toolchain w/ dynamic library" + depends on BR2_STATIC_LIBS + config BR2_PACKAGE_KODI_LIBSMBCLIENT bool "samba" select BR2_PACKAGE_SAMBA
Signature · 1 line
2.1.4
PATCH 11/21 oprofile: add missing indirect dependency on NPTL for PPC
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/oprofile/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
package/oprofile/Config.in +2 -2
@@ -9,7 +9,7 @@ config BR2_PACKAGE_OPROFILE depends on BR2_USE_WCHAR # binutils depends on !BR2_xtensa # libpfm4 is needed on PowerPC, and requires thread support - depends on BR2_TOOLCHAIN_HAS_THREADS || !BR2_powerpc + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_powerpc help OProfile is a system-wide profiler for Linux systems, capable of profiling all running code at low overhead.
@@ -31,6 +31,6 @@ comment "oprofile needs a toolchain w/ C++, wchar" depends on !BR2_aarch64 && !BR2_nios2 && !BR2_xtensa depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR -comment "oprofile needs a toolchain w/ threads on PPC" +comment "oprofile needs a toolchain w/ NPTL on PPC" depends on BR2_USE_MMU && BR2_powerpc depends on !BR2_TOOLCHAIN_HAS_THREADS
Signature · 1 line
2.1.4
PATCH 11/21 oprofile: add missing indirect dependency on NPTL for PPC
Quoted 21 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
--- package/oprofile/Config.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)package/oprofile/Config.in +1
-1@@ -9,7 +9,7 @@ config BR2_PACKAGE_OPROFILE depends on BR2_USE_WCHAR # binutils depends on !BR2_xtensa # libpfm4 is needed on PowerPC, and requires thread support - depends on BR2_TOOLCHAIN_HAS_THREADS || !BR2_powerpc + depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL || !BR2_powerpc help OProfile is a system-wide profiler for Linux systems, capable of profiling all running code at low overhead.
package/oprofile/Config.in comment "oprofile needs a toolchain w/ C++, wchar" · line 36
Quoted 7 lines
package/oprofile/Config.in +1
-1@@ -31,6 +31,6 @@ comment "oprofile needs a toolchain w/ C++, wchar" depends on !BR2_aarch64 && !BR2_nios2 && !BR2_xtensa depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR -comment "oprofile needs a toolchain w/ threads on PPC" +comment "oprofile needs a toolchain w/ NPTL on PPC" depends on BR2_USE_MMU && BR2_powerpc depends on !BR2_TOOLCHAIN_HAS_THREADS
This should then also be !BR2_TOOLCHAIN_HAS_THREADS_NPTL.
Signature · 1 line
Bye, Peter Korsgaard
PATCH 12/21 util-linux: add missing indirect dependency on !avr32 for setpriv
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/util-linux/Config.in | 1 + 1 file changed, 1 insertion(+)
package/util-linux/Config.in +1 -0
@@ -215,6 +215,7 @@ config BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS config BR2_PACKAGE_UTIL_LINUX_SETPRIV bool "setpriv" + depends on !BR2_avr32 # libcap-ng select BR2_PACKAGE_LIBCAP_NG help Run a program with different Linux privilege settings
Signature · 1 line
2.1.4
PATCH 13/21 dovecot: add missing indirect dependency on !avr32 for mysql
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/dovecot/Config.in | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
package/dovecot/Config.in +4 -2
@@ -22,13 +22,15 @@ config BR2_PACKAGE_DOVECOT_BZIP2 config BR2_PACKAGE_DOVECOT_MYSQL bool "mysql support" select BR2_PACKAGE_MYSQL - depends on BR2_INSTALL_LIBSTDCPP - depends on BR2_TOOLCHAIN_HAS_THREADS + depends on BR2_INSTALL_LIBSTDCPP # mysql + depends on BR2_TOOLCHAIN_HAS_THREADS # mysql + depends on !BR2_avr32 # mysql help Enable MySQL support. comment "mysql support needs a toolchain w/ C++, threads" depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_avr32 config BR2_PACKAGE_DOVECOT_OPENSSL bool "openssl support"
Signature · 1 line
2.1.4
PATCH 14/21 php: add missing indirect dependency on !avr32 for mysql extensions
In reply to Arnout Vandecappelle (Essensium/Mind)Also fix the comment.
--- package/php/Config.ext | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
package/php/Config.ext +6 -2
@@ -106,6 +106,7 @@ config BR2_PACKAGE_PHP_EXT_MYSQL depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_MMU # mysql depends on BR2_TOOLCHAIN_HAS_THREADS # mysql + depends on !BR2_avr32 # mysql select BR2_PACKAGE_MYSQL help MySQL support
@@ -115,6 +116,7 @@ config BR2_PACKAGE_PHP_EXT_MYSQLI depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_MMU # mysql depends on BR2_TOOLCHAIN_HAS_THREADS # mysql + depends on !BR2_avr32 # mysql select BR2_PACKAGE_MYSQL select BR2_PACKAGE_PHP_EXT_MYSQL help
@@ -132,13 +134,15 @@ config BR2_PACKAGE_PHP_EXT_PDO_MYSQL depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_MMU # mysql depends on BR2_TOOLCHAIN_HAS_THREADS # mysql + depends on !BR2_avr32 # mysql select BR2_PACKAGE_MYSQL help PDO driver for MySQL -comment "MySQL drivers need a toolchain w/ C++" +comment "MySQL drivers need a toolchain w/ C++, threads" depends on BR2_USE_MMU - depends on !BR2_INSTALL_LIBSTDCPP + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_avr32 config BR2_PACKAGE_PHP_EXT_PDO_POSTGRESQL bool "PostgreSQL"
Signature · 1 line
2.1.4
PATCH 15/21 cwiid: add missing indirect dependency on atomics for wmgui
In reply to Arnout Vandecappelle (Essensium/Mind)Also add a comment for cwiid itself.
--- package/cwiid/Config.in | 6 ++++++ 1 file changed, 6 insertions(+)
package/cwiid/Config.in +6 -0
@@ -15,6 +15,7 @@ config BR2_PACKAGE_CWIID if BR2_PACKAGE_CWIID config BR2_PACKAGE_CWIID_WMGUI bool "wmgui" + depends on BR2_ARCH_HAS_ATOMICS # libgtk2 -> cairo depends on BR2_PACKAGE_XORG7 # libgtk2 depends on BR2_USE_WCHAR # libgtk2 -> libglib2 depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> libglib2
@@ -23,3 +24,8 @@ config BR2_PACKAGE_CWIID_WMGUI select BR2_PACKAGE_LIBGLIB2 select BR2_PACKAGE_LIBGTK2 endif + +comment "cwiid needs a toolchain w/ dynamic lib, threads, wchar" + depends on BR2_STATIC_LIBS || !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS + depends on !BR2_avr32 + depends on !BR2_USE_MMU
Signature · 1 line
2.1.4
PATCH 16/21 opencv: add missing indirect dependency on atomics for gtk support
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/opencv/Config.in | 1 + 1 file changed, 1 insertion(+)
package/opencv/Config.in +1 -0
@@ -160,6 +160,7 @@ config BR2_PACKAGE_OPENCV_WITH_GTK depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> libglib2 depends on BR2_INSTALL_LIBSTDCPP depends on BR2_USE_MMU # libgtk2 -> glib2 + depends on BR2_ARCH_HAS_ATOMICS # libgtk2 -> cairo depends on BR2_PACKAGE_OPENCV_LIB_HIGHGUI select BR2_PACKAGE_LIBGTK2
Signature · 1 line
2.1.4
PATCH 17/21 pinenty: add missing indirect dependency on atomics for gtk2 support
In reply to Arnout Vandecappelle (Essensium/Mind)Also remove redundant comment lines.
--- package/pinentry/Config.in | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
package/pinentry/Config.in +2 -4
@@ -18,13 +18,12 @@ config BR2_PACKAGE_PINENTRY_NCURSES config BR2_PACKAGE_PINENTRY_GTK2 bool "pinentry-gtk2" - # propagate libgtk2's dependencies depends on BR2_PACKAGE_XORG7 depends on BR2_USE_WCHAR depends on BR2_TOOLCHAIN_HAS_THREADS depends on BR2_USE_MMU depends on BR2_INSTALL_LIBSTDCPP - # select libgtk2 + depends on BR2_ARCH_HAS_ATOMICS # libgtk2 -> cairo select BR2_PACKAGE_LIBGTK2 select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE help
@@ -32,17 +31,16 @@ config BR2_PACKAGE_PINENTRY_GTK2 comment "pinentry-gtk2 needs X and a toolchain w/ wchar, threads, C++" depends on BR2_USE_MMU + depends on BR2_ARCH_HAS_ATOMICS depends on !BR2_PACKAGE_XORG7 || !BR2_USE_WCHAR || \ !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS config BR2_PACKAGE_PINENTRY_QT4 bool "pinentry-qt4" - # propagate qt's dependencies depends on !BR2_avr32 # lacks TLS depends on BR2_USE_MMU # fork depends on BR2_INSTALL_LIBSTDCPP depends on BR2_TOOLCHAIN_HAS_THREADS - # select qt select BR2_PACKAGE_QT select BR2_PACKAGE_QT_GUI_MODULE help
Signature · 1 line
2.1.4
PATCH 18/21 xscreensaver: add missing indirect dependency on atomics
In reply to Arnout Vandecappelle (Essensium/Mind)Also reformat the comment lines and fix the comment.
--- package/xscreensaver/Config.in | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-)
package/xscreensaver/Config.in +8 -5
@@ -1,10 +1,11 @@ config BR2_PACKAGE_XSCREENSAVER bool "xscreensaver" depends on BR2_PACKAGE_XORG7 - depends on BR2_INSTALL_LIBSTDCPP # libgtk2->pango - depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2->glib2 - depends on BR2_USE_WCHAR # libgtk2->glib2 - depends on BR2_USE_MMU # libgtk2->glib2 + depends on BR2_INSTALL_LIBSTDCPP # libgtk2 -> pango + depends on BR2_TOOLCHAIN_HAS_THREADS # libgtk2 -> glib2 + depends on BR2_USE_WCHAR # libgtk2 -> glib2 + depends on BR2_USE_MMU # libgtk2 -> glib2 + depends on BR2_ARCH_HAS_ATOMICS # libgtk2 -> cairo select BR2_PACKAGE_LIBGTK2 select BR2_PACKAGE_LIBGLADE select BR2_PACKAGE_JPEG
@@ -24,4 +25,6 @@ config BR2_PACKAGE_XSCREENSAVER comment "xscreensaver needs a toolchain w/ wchar, C++, threads" depends on BR2_PACKAGE_XORG7 depends on BR2_USE_MMU - depends on !(BR2_INSTALL_LIBSTDCPP && BR2_TOOLCHAIN_HAS_THREADS) + depends on BR2_ARCH_HAS_ATOMICS + depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS || \ + !BR2_USE_WCHAR
Signature · 1 line
2.1.4
PATCH 19/21 enlightenment: add missing indirect dependency on atomics
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/enlightenment/Config.in | 3 +++ 1 file changed, 3 insertions(+)
package/enlightenment/Config.in +3 -0
@@ -27,6 +27,8 @@ config BR2_PACKAGE_ENLIGHTENMENT depends on BR2_USE_MMU depends on BR2_PACKAGE_XORG7 depends on !BR2_avr32 # libevas + # libevas-generic-loaders-svg -> librsvg -> pango -> cairo + depends on BR2_ARCH_HAS_ATOMICS help Enlightenment, also known simply as E, is a stacking window manager for the X Window System which can be used alone or
@@ -39,4 +41,5 @@ config BR2_PACKAGE_ENLIGHTENMENT comment "enlightenment needs a toolchain w/ wchar, C++, threads" depends on BR2_PACKAGE_XORG7 && BR2_USE_MMU depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP + depends on BR2_ARCH_HAS_ATOMICS depends on !BR2_avr32
Signature · 1 line
2.1.4
PATCH 20/21 qt5cinex: add missing indirect dependency on libegl
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/qt5cinex/Config.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
package/qt5cinex/Config.in +3 -2
@@ -1,7 +1,7 @@ -comment "qt5cinex needs an OpenGL-capable backend" +comment "qt5cinex needs an Open(E)GL-capable backend" depends on BR2_PACKAGE_QT5 depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE - depends on !BR2_PACKAGE_QT5_GL_AVAILABLE + depends on !BR2_PACKAGE_QT5_GL_AVAILABLE || !BR2_PACKAGE_HAS_LIBEGL config BR2_PACKAGE_QT5CINEX bool "qt5cinex"
@@ -11,6 +11,7 @@ config BR2_PACKAGE_QT5CINEX select BR2_PACKAGE_QT5BASE_WIDGETS select BR2_PACKAGE_QT5BASE_EGLFS select BR2_PACKAGE_QT5GRAPHICALEFFECTS + depends on BR2_PACKAGE_HAS_LIBEGL # qt5base-eglfs depends on BR2_PACKAGE_QT5_GL_AVAILABLE # No comment needed for this option, it's an architecture # dependency.
Signature · 1 line
2.1.4
PATCH 21/21 qt5webkit: add missing indirect dependency on atomics and !flat
In reply to Arnout Vandecappelle (Essensium/Mind)--- package/qt5/qt5webkit/Config.in | 2 ++ 1 file changed, 2 insertions(+)
package/qt5/qt5webkit/Config.in +2 -0
@@ -9,6 +9,8 @@ config BR2_PACKAGE_QT5WEBKIT # This module does not support static linking depends on !BR2_STATIC_LIBS depends on BR2_PACKAGE_QT5_JSCORE_AVAILABLE + depends on BR2_ARCH_HAS_ATOMICS # icu + depends on !BR2_BINFMT_FLAT # icu help Qt is a cross-platform application and UI framework for developers using C++.
Signature · 1 line
2.1.4
cover Add missing indirect dependencies
In reply to Arnout Vandecappelle (Essensium/Mind)Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
With the fix for randconfig that I made in
http://patchwork.ozlabs.org/patch/432554/ it is now possible to run 'make randconfig' and get usable results. So I ran the following loop to detect missing indirect dependencies:
Quoted 5 lines
while true; do make randconfig 2>&1 | grep warning; done
If there is a missing indirect dependency, this will output a line like:
warning: (
BR2_PACKAGE_UTIL_LINUX_SETPRIV) selectsBR2_PACKAGE_LIBCAP_NGwhich has unmet direct dependencies (!BR2_avr32)
Committed with the minor issues pointed out by Jerzy Grzegorek fixed, thanks.
Quoted 2 lines
It would be good to include such a test in a jenkins job to detect this
type of error earlier.
Indeed. Maxime, is that something you can setup?
Signature · 1 line
Bye, Peter Korsgaard
cover Add missing indirect dependencies
Hi Peter,
Quoted 13 lines · Peter Korsgaard
Quoted 7 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Arnout" == Arnout Vandecappelle (Essensium/Mind) <[email protected]> writes:
With the fix for randconfig that I made in
http://patchwork.ozlabs.org/patch/432554/ it is now possible to run 'make randconfig' and get usable results. So I ran the following loop to detect missing indirect dependencies:Quoted 5 lines
while true; do make randconfig 2>&1 | grep warning; done
If there is a missing indirect dependency, this will output a line like:
warning: (
BR2_PACKAGE_UTIL_LINUX_SETPRIV) selectsBR2_PACKAGE_LIBCAP_NGwhich has unmet direct dependencies (!BR2_avr32)
Quoted 8 lines
Committed with the minor issues pointed out by Jerzy Grzegorek fixed, thanks.
Quoted 2 lines
It would be good to include such a test in a jenkins job to detect this
type of error earlier.Indeed. Maxime, is that something you can setup?
Unfortunately, Jenkins has been down for quite some time now, and I still haven't got the time to fix it.
What would be the test to setup?
Maxime
Signature · 10 lines
Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: Digital signature URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150209/78ad1276/attachment.asc>
cover Add missing indirect dependencies
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Maxime" == Maxime Ripard <[email protected]> writes:
Hi,
Quoted 12 lines
Quoted 12 lines
Quoted 7 lines
while true; do make randconfig 2>&1 | grep warning; done
If there is a missing indirect dependency, this will output a line like:
warning: (
BR2_PACKAGE_UTIL_LINUX_SETPRIV) selectsBR2_PACKAGE_LIBCAP_NGwhich has unmet direct dependencies (!BR2_avr32)Committed with the minor issues pointed out by Jerzy Grzegorek fixed, thanks.
Quoted 7 lines
Quoted 4 lines
Quoted 2 lines
It would be good to include such a test in a jenkins job to detect this
type of error earlier.Indeed. Maxime, is that something you can setup?
Unfortunately, Jenkins has been down for quite some time now, and I still haven't got the time to fix it.
:/
Quoted 1 line
What would be the test to setup?
As Arnout suggested - a number of make randconfig 2>&1 | grep warning calls that shouldn't generate any output at all.
Signature · 2 lines
Venlig hilsen, Peter Korsgaard