Skip to contentSkip to conversation

sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART

PATCH In review Hans de Goede 4 participants 5 messages Feb 3, 2015 – Feb 12, 2015 Arm/Allwinner sunXi SoC support

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART

The recent changes to config_distro_bootcmd.h require CONFIG_CMD_PART to be defined, as the default bootcmd not uses the "part" command.

This fixes sunxi boards not booting with v2015.04-rc1.

---
 include/configs/sunxi-common.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/sunxi-common.h +3 -0
index bf60dcb..9e145f0 100644
@@ -144,6 +144,9 @@
 #define CONFIG_CMD_MEMORY
 #define CONFIG_CMD_SETEXPR
 
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_CMD_PART
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG
Signature · 1 line
2.2.2
#1 lore raw

PATCH 1/1 sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART

Quoted 2 lines · Hans de Goede

The recent changes to config_distro_bootcmd.h require CONFIG_CMD_PART to be defined, as the default bootcmd not uses the "part" command.

                                   ^w

Shouldn't config_distro_bootcmd.h (or perhaps config_distro_defaults.h) enable CMD_PART then? (adding some relevant CCs)

Ian.

Quoted 21 lines

This fixes sunxi boards not booting with v2015.04-rc1.

---
 include/configs/sunxi-common.h | 3 +++
 1 file changed, 3 insertions(+)
include/configs/sunxi-common.h +3 -0
index bf60dcb..9e145f0 100644
@@ -144,6 +144,9 @@
 #define CONFIG_CMD_MEMORY
 #define CONFIG_CMD_SETEXPR
 
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_CMD_PART
+
 #define CONFIG_SETUP_MEMORY_TAGS
 #define CONFIG_CMDLINE_TAG
 #define CONFIG_INITRD_TAG
#2 lore raw

PATCH 1/1 sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART

Hi,

Quoted 7 lines · Ian Campbell
Quoted 2 lines · Hans de Goede

The recent changes to config_distro_bootcmd.h require CONFIG_CMD_PART to be defined, as the default bootcmd not uses the "part" command.

                                    ^w

Shouldn't config_distro_bootcmd.h (or perhaps config_distro_defaults.h) enable CMD_PART then? (adding some relevant CCs)

I was thinking the same myself, but I was not sure, so I thought lets go with a quick fix for now and discuss this further on the list :)

A quick grep shows that config_distro_bootcmd.h is only included from headers under include/configs/*.h, so enabling it there should get it defined early enough for it to be properly picked up, so from my pov yes that is a better solution.

Regards,

Hans

p.s.

Have you seen my reply to your review of "[PATCH 1/2] sunxi: video: Do not use CONFIG_SYS_MEM_TOP_HIDE for the framebuffer" ? I'm waiting on input from you there on the fdt_fixup_memory_banks()
thingie, which I would prefer to keep as is. An "Acked-by" under
the condition that I fix up the Linux specific comments would be
welcome :)

Quoted 26 lines

Ian.

Quoted 21 lines

This fixes sunxi boards not booting with v2015.04-rc1.

---
  include/configs/sunxi-common.h | 3 +++
  1 file changed, 3 insertions(+)
include/configs/sunxi-common.h +3 -0
index bf60dcb..9e145f0 100644
@@ -144,6 +144,9 @@
  #define CONFIG_CMD_MEMORY
  #define CONFIG_CMD_SETEXPR
 
+#define CONFIG_PARTITION_UUIDS
+#define CONFIG_CMD_PART
+
  #define CONFIG_SETUP_MEMORY_TAGS
  #define CONFIG_CMDLINE_TAG
  #define CONFIG_INITRD_TAG
#3 lore raw

PATCH 1/1 sunxi: configs/sunxi-common.h: Enable CONFIG_CMD_PART

In reply to Ian Campbell
Quoted 7 lines · Ian Campbell
Quoted 2 lines · Hans de Goede

The recent changes to config_distro_bootcmd.h require CONFIG_CMD_PART to be defined, as the default bootcmd not uses the "part" command.

                                    ^w

Shouldn't config_distro_bootcmd.h (or perhaps config_distro_defaults.h) enable CMD_PART then? (adding some relevant CCs)

That sounds like the correct solution to me.

#4 lore raw
In reply to Hans de Goede
Quoted 6 lines · Hans de Goede

The recent changes to config_distro_bootcmd.h require CONFIG_CMD_PART to be defined, as the default bootcmd not uses the "part" command.

This fixes sunxi boards not booting with v2015.04-rc1.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150211/dcb7546b/attachment.sig>