vl.c: fixed QEMU crash if no display was selected in command line
PATCH 1/1 vl.c: fixed QEMU crash if no display was selected in command line
Commit 4db14629c3 (vnc: switch to QemuOpts, allow multiple servers) converted vnc option to QemuOpts.
However, the default vnc display had ...,to=99,... between parameters that is not covered by the QemuOpts.
Remove it because is not longer used and solves the crash.
---
This issue is bugging me some time now. Please let me know if I got it wrong.
vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
vl.c +1 -1
@@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp)#elif defined(CONFIG_SDL ) || defined(CONFIG_COCOA ) display_type =DT_SDL ;#elif defined(CONFIG_VNC ) -vnc_parse_func ("localhost:0,to=99,id=default" ); +vnc_parse_func ("localhost:0,id=default" ); show_vnc_port =1 ;#else display_type =DT_NONE ;
Signature · 1 line
2.1.0
A proper fix for this is the thread:
Subject: [PATCH v2 0/3] fix qemu crash about vnc
Date: Fri, 30 Jan 2015 10:14:33 +0800
Message-ID: <[email protected]>
This also has a bug:
https://bugs.launchpad.net/qemu/+bug/1414222
Xen expects this to be working.
-Don Slutz
Quoted 28 lines · Marcel Apfelbaum
Commit
4db14629c3(vnc: switch to QemuOpts, allow multiple servers) converted vnc option to QemuOpts.
However, the default vnc display had ...,to=99,... between parameters that is not covered by the QemuOpts.
Remove it because is not longer used and solves the crash.Signed-off-by Marcel Apfelbaum <[email protected]>---
This issue is bugging me some time now. Please let me know if I got it wrong.vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)vl.c +1
-1@@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp)#elif defined(CONFIG_SDL ) || defined(CONFIG_COCOA ) display_type =DT_SDL ;#elif defined(CONFIG_VNC ) -vnc_parse_func ("localhost:0,to=99,id=default" ); +vnc_parse_func ("localhost:0,id=default" ); show_vnc_port =1 ;#else display_type =DT_NONE ;
A proper fix for this is the thread:
Subject: [PATCH v2 0/3] fix qemu crash about vnc
Date: Fri, 30 Jan 2015 10:14:33 +0800
Message-ID: <[email protected]>
This also has a bug:
https://bugs.launchpad.net/qemu/+bug/1414222
Xen expects this to be working.
-Don Slutz
Quoted 28 lines · Marcel Apfelbaum
Commit
4db14629c3(vnc: switch to QemuOpts, allow multiple servers) converted vnc option to QemuOpts.
However, the default vnc display had ...,to=99,... between parameters that is not covered by the QemuOpts.
Remove it because is not longer used and solves the crash.Signed-off-by Marcel Apfelbaum <[email protected]>---
This issue is bugging me some time now. Please let me know if I got it wrong.vl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)vl.c +1
-1@@ -3970,7 +3970,7 @@ int main(int argc, char **argv, char **envp)#elif defined(CONFIG_SDL ) || defined(CONFIG_COCOA ) display_type =DT_SDL ;#elif defined(CONFIG_VNC ) -vnc_parse_func ("localhost:0,to=99,id=default" ); +vnc_parse_func ("localhost:0,id=default" ); show_vnc_port =1 ;#else display_type =DT_NONE ;
Quoted 1 line · Don Slutz
A proper fix for this is the thread:
I suspected I don't have the whole picture, good to know it is fixed!
Thanks!
Marcel
Quoted 14 lines
Subject: [PATCH v2 0/3] fix qemu crash about vnc
Date: Fri, 30 Jan 2015 10:14:33 +0800
Message-ID: <[email protected]>This also has a bug:
https://bugs.launchpad.net/qemu/+bug/1414222
Xen expects this to be working.
-Don Slutz
[...]
Quoted 1 line · Don Slutz
A proper fix for this is the thread:
I suspected I don't have the whole picture, good to know it is fixed!
Thanks!
Marcel
Quoted 14 lines
Subject: [PATCH v2 0/3] fix qemu crash about vnc
Date: Fri, 30 Jan 2015 10:14:33 +0800
Message-ID: <[email protected]>This also has a bug:
https://bugs.launchpad.net/qemu/+bug/1414222
Xen expects this to be working.
-Don Slutz
[...]