usb: gadget: function/f_uac2: fix sparse warnings
PATCH 1/1 usb: gadget: function/f_uac2: fix sparse warnings
From: "Lad, Prabhakar" <[email protected]>
this patch fixes following sparse warnings:
f_uac2.c:57:12: warning: symbol 'uac2_name' was not declared. Should it be static? f_uac2.c:637:36: warning: symbol 'in_clk_src_desc' was not declared. Should it be static? f_uac2.c:649:36: warning: symbol 'out_clk_src_desc' was not declared. Should it be static? f_uac2.c:661:39: warning: symbol 'usb_out_it_desc' was not declared. Should it be static? f_uac2.c:675:39: warning: symbol 'io_in_it_desc' was not declared. Should it be static? f_uac2.c:689:40: warning: symbol 'usb_in_ot_desc' was not declared. Should it be static? f_uac2.c:703:40: warning: symbol 'io_out_ot_desc' was not declared. Should it be static? f_uac2.c:716:34: warning: symbol 'ac_hdr_desc' was not declared. Should it be static? f_uac2.c:754:34: warning: symbol 'as_out_hdr_desc' was not declared. Should it be static? f_uac2.c:767:38: warning: symbol 'as_out_fmt1_desc' was not declared. Should it be static? f_uac2.c:775:32: warning: symbol 'fs_epout_desc' was not declared. Should it be static? f_uac2.c:785:32: warning: symbol 'hs_epout_desc' was not declared. Should it be static? f_uac2.c:831:34: warning: symbol 'as_in_hdr_desc' was not declared. Should it be static? f_uac2.c:844:38: warning: symbol 'as_in_fmt1_desc' was not declared. Should it be static? f_uac2.c:852:32: warning: symbol 'fs_epin_desc' was not declared. Should it be static? f_uac2.c:862:32: warning: symbol 'hs_epin_desc' was not declared. Should it be static? f_uac2.c:1566:21: warning: symbol 'afunc_alloc' was not declared. Should it be static?
---
Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next.
drivers/usb/gadget/function/f_uac2.c | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-)
drivers/usb/gadget/function/f_uac2.c +17 -17
@@ -54,7 +54,7 @@#define UNFLW_CTRL 8#define OVFLW_CTRL 10 -const char *uac2_name ="snd_uac2" ; +static const char *uac2_name ="snd_uac2" ;struct uac2_req {struct uac2_rtd_params *pp;/* parent param */
@@ -634,7 +634,7 @@ static struct usb_interface_descriptor std_ac_if_desc = { };/* Clock source for IN traffic */ -struct uac_clock_source_descriptor in_clk_src_desc = { +static struct uac_clock_source_descriptor in_clk_src_desc = { .bLength =sizeof in_clk_src_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -646,7 +646,7 @@ struct uac_clock_source_descriptor in_clk_src_desc = { };/* Clock source for OUT traffic */ -struct uac_clock_source_descriptor out_clk_src_desc = { +static struct uac_clock_source_descriptor out_clk_src_desc = { .bLength =sizeof out_clk_src_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -658,7 +658,7 @@ struct uac_clock_source_descriptor out_clk_src_desc = { };/* Input Terminal for USB_OUT */ -struct uac2_input_terminal_descriptor usb_out_it_desc = { +static struct uac2_input_terminal_descriptor usb_out_it_desc = { .bLength =sizeof usb_out_it_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -672,7 +672,7 @@ struct uac2_input_terminal_descriptor usb_out_it_desc = { };/* Input Terminal for I/O-In */ -struct uac2_input_terminal_descriptor io_in_it_desc = { +static struct uac2_input_terminal_descriptor io_in_it_desc = { .bLength =sizeof io_in_it_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -686,7 +686,7 @@ struct uac2_input_terminal_descriptor io_in_it_desc = { };/* Ouput Terminal for USB_IN */ -struct uac2_output_terminal_descriptor usb_in_ot_desc = { +static struct uac2_output_terminal_descriptor usb_in_ot_desc = { .bLength =sizeof usb_in_ot_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -700,7 +700,7 @@ struct uac2_output_terminal_descriptor usb_in_ot_desc = { };/* Ouput Terminal for I/O-Out */ -struct uac2_output_terminal_descriptor io_out_ot_desc = { +static struct uac2_output_terminal_descriptor io_out_ot_desc = { .bLength =sizeof io_out_ot_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -713,7 +713,7 @@ struct uac2_output_terminal_descriptor io_out_ot_desc = { .bmControls = (CONTROL_RDWR << COPY_CTRL), }; -struct uac2_ac_header_descriptor ac_hdr_desc = { +static struct uac2_ac_header_descriptor ac_hdr_desc = { .bLength =sizeof ac_hdr_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -751,7 +751,7 @@ static struct usb_interface_descriptor std_as_out_if1_desc = { };/* Audio Stream OUT Intface Desc */ -struct uac2_as_header_descriptor as_out_hdr_desc = { +static struct uac2_as_header_descriptor as_out_hdr_desc = { .bLength =sizeof as_out_hdr_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -764,7 +764,7 @@ struct uac2_as_header_descriptor as_out_hdr_desc = { };/* Audio USB_OUT Format */ -struct uac2_format_type_i_descriptor as_out_fmt1_desc = { +static struct uac2_format_type_i_descriptor as_out_fmt1_desc = { .bLength =sizeof as_out_fmt1_desc, .bDescriptorType =USB_DT_CS_INTERFACE , .bDescriptorSubtype =UAC_FORMAT_TYPE ,
@@ -772,7 +772,7 @@ struct uac2_format_type_i_descriptor as_out_fmt1_desc = { };/* STD AS ISO OUT Endpoint */ -struct usb_endpoint_descriptor fs_epout_desc = { +static struct usb_endpoint_descriptor fs_epout_desc = { .bLength =USB_DT_ENDPOINT_SIZE , .bDescriptorType =USB_DT_ENDPOINT ,
@@ -782,7 +782,7 @@ struct usb_endpoint_descriptor fs_epout_desc = { .bInterval = 1, }; -struct usb_endpoint_descriptor hs_epout_desc = { +static struct usb_endpoint_descriptor hs_epout_desc = { .bLength =USB_DT_ENDPOINT_SIZE , .bDescriptorType =USB_DT_ENDPOINT ,
@@ -828,7 +828,7 @@ static struct usb_interface_descriptor std_as_in_if1_desc = { };/* Audio Stream IN Intface Desc */ -struct uac2_as_header_descriptor as_in_hdr_desc = { +static struct uac2_as_header_descriptor as_in_hdr_desc = { .bLength =sizeof as_in_hdr_desc, .bDescriptorType =USB_DT_CS_INTERFACE ,
@@ -841,7 +841,7 @@ struct uac2_as_header_descriptor as_in_hdr_desc = { };/* Audio USB_IN Format */ -struct uac2_format_type_i_descriptor as_in_fmt1_desc = { +static struct uac2_format_type_i_descriptor as_in_fmt1_desc = { .bLength =sizeof as_in_fmt1_desc, .bDescriptorType =USB_DT_CS_INTERFACE , .bDescriptorSubtype =UAC_FORMAT_TYPE ,
@@ -849,7 +849,7 @@ struct uac2_format_type_i_descriptor as_in_fmt1_desc = { };/* STD AS ISO IN Endpoint */ -struct usb_endpoint_descriptor fs_epin_desc = { +static struct usb_endpoint_descriptor fs_epin_desc = { .bLength =USB_DT_ENDPOINT_SIZE , .bDescriptorType =USB_DT_ENDPOINT ,
@@ -859,7 +859,7 @@ struct usb_endpoint_descriptor fs_epin_desc = { .bInterval = 1, }; -struct usb_endpoint_descriptor hs_epin_desc = { +static struct usb_endpoint_descriptor hs_epin_desc = { .bLength =USB_DT_ENDPOINT_SIZE , .bDescriptorType =USB_DT_ENDPOINT ,
@@ -1563,7 +1563,7 @@ static void afunc_unbind(struct usb_configuration *c, struct usb_function *f) agdev->out_ep->driver_data =NULL ; } -struct usb_function *afunc_alloc (struct usb_function_instance *fi) +static struct usb_function *afunc_alloc (struct usb_function_instance *fi) {struct audio_dev *agdev;struct f_uac2_opts *opts;
Signature · 1 line
1.9.1