Skip to contentSkip to conversation

tty/n_gsm: fix sparse warning

PATCH New Lad Prabhakar 1 participant 1 message Feb 4, 2015 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tty/n_gsm: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

n_gsm.c:2827:22: warning: symbol 'tty_ldisc_packet' was not declared. Should it be static?

---
Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/tty/n_gsm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/n_gsm.c +1 -1
index c434376..9546b64 100644
@@ -2824,7 +2824,7 @@ static int gsm_create_network(struct gsm_dlci *dlci, struct gsm_netconfig *nc)
 }
 
 /* Line discipline for real tty */
-struct tty_ldisc_ops tty_ldisc_packet = {
+static struct tty_ldisc_ops tty_ldisc_packet = {
 	.owner		 = THIS_MODULE,
 	.magic           = TTY_LDISC_MAGIC,
 	.name            = "n_gsm",
Signature · 1 line
1.9.1