Skip to contentSkip to conversation

Fixes for display managers, emacs, and dracut

PATCH In review Dan McGregor 3 participants 11 messages Feb 4, 2015 – Feb 12, 2015

lore
Share & tools
lore
#0 lore raw

cover Fixes for display managers, emacs, and dracut

From: Dan McGregor <[email protected]>

Here are a bunch of patches that I've been sitting on for far too long; it's time to push them up.

Dan McGregor (5):
xserver-nodm-init: only enable for runlevel 5
lxdm: RDEPEND on libsvg-gtk
emacs: Un-blacklist, seems to work fine with new qemu
gdm: Only start in runlevel 5
dracut: recipe cleanup

 meta-gnome/recipes-gnome/gdm/gdm/gdm               |  4 +-
 meta-gnome/recipes-gnome/gdm/gdm_2.32.2.bb         |  2 +-
 .../recipes-devtools/dracut/dracut_git.bb          | 25 ++++--
 meta-oe/recipes-graphics/lxdm/lxdm_git.bb          |  2 +-
 .../xserver-nodm-init-2.0/xserver-nodm             |  9 +++
 .../xserver-nodm-init/xserver-nodm-init_2.0.bb     |  4 +-
 meta-oe/recipes-support/emacs/emacs.inc            | 89 +---------------------
 meta-oe/recipes-support/emacs/emacs_23.4.bb        |  2 -
 8 files changed, 36 insertions(+), 101 deletions(-)
Signature · 1 line
2.1.0
#1 lore raw

PATCH 1/5 xserver-nodm-init: only enable for runlevel 5

From: Dan McGregor <[email protected]>

Runlevel 5 is traditionally graphical. If it starts in runlevel 2 or 3 systemd gets confused and adds it as a dependency of the multi-user target, not just the graphical target.

---
 .../xserver-nodm-init/xserver-nodm-init-2.0/xserver-nodm         | 9 +++++++++
 .../recipes-graphics/xserver-nodm-init/xserver-nodm-init_2.0.bb  | 4 ++--
 2 files changed, 11 insertions(+), 2 deletions(-)
meta-oe/recipes-graphics/xserver-nodm-init/xserver-nodm-init-2.0/xserver-nodm +9 -0
index d2e2f86..5d7e8a2 100755
@@ -1,4 +1,13 @@
 #!/bin/sh
+#
+### BEGIN INIT INFO
+# Provides: xserver
+# Required-Start: $local_fs $remote_fs dbus
+# Required-Stop: $local_fs $remote_fs
+# Default-Start:     5
+# Default-Stop:      0 1 2 3 6
+### END INIT INFO
+
 
 . /etc/init.d/functions
 
meta-oe/recipes-graphics/xserver-nodm-init/xserver-nodm-init_2.0.bb +2 -2
index 47470fb..f9bf007 100644
@@ -15,8 +15,8 @@ S = "${WORKDIR}"
 inherit allarch update-rc.d systemd
 
 INITSCRIPT_NAME = "xserver-nodm"
-INITSCRIPT_PARAMS = "start 01 5 2 . stop 01 0 1 6 ."
-INITSCRIPT_PARAMS_shr = "start 90 5 2 . stop 90 0 1 6 ."
+INITSCRIPT_PARAMS = "start 01 5 . stop 01 0 1 2 3 6 ."
+INITSCRIPT_PARAMS_shr = "start 90 5 . stop 90 0 1 2 3 6 ."
 
 do_install() {
     install -d ${D}${sysconfdir}/init.d
Signature · 1 line
2.1.0
#2 lore raw

PATCH 2/5 lxdm: RDEPEND on libsvg-gtk

In reply to Dan McGregor

From: Dan McGregor <[email protected]>

The theme uses svg files. If libsvg-gtk isn't available lxdm still runs, but throws a bunch of pixbuf errors.

---
 meta-oe/recipes-graphics/lxdm/lxdm_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-graphics/lxdm/lxdm_git.bb +1 -1
index a3dcc1b..66dc269 100644
@@ -70,7 +70,7 @@ done
 sed -i "s:last_langs=.*$:last_langs=$langs:g" $D${localstatedir}/lib/lxdm/lxdm.conf
 }
 
-RDEPENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam-plugin-loginuid', '', d)} setxkbmap bash"
+RDEPENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'pam', 'pam-plugin-loginuid', '', d)} setxkbmap bash librsvg-gtk"
 
 RPROVIDES_${PN} += "${PN}-systemd"
 RREPLACES_${PN} += "${PN}-systemd"
Signature · 1 line
2.1.0
#3 lore raw

PATCH 3/5 emacs: Un-blacklist, seems to work fine with new qemu

In reply to Dan McGregor

From: Dan McGregor <[email protected]>

I've only tested the build with armv7 and x86, but the build doesn't segfault anymore. The last time this was tested was with qemu 1.5, we're now using 2.1.

While here, don't copy stuff from the sysroot into the qemu tree just use the sysroot itself.

---
 meta-oe/recipes-support/emacs/emacs.inc     | 89 +----------------------------
 meta-oe/recipes-support/emacs/emacs_23.4.bb |  2 -
 2 files changed, 2 insertions(+), 89 deletions(-)
meta-oe/recipes-support/emacs/emacs.inc +2 -87
index a1a4965..e052c5e 100644
@@ -14,14 +14,13 @@ X11DEPENDS = " \
     libx11 libxau libxcomposite libxcursor libxdamage libxdmcp libxext libxfixes \
     libxft libxpm libxrandr libxrender \
     gdk-pixbuf glib-2.0 gtk+ pango libxcb harfbuzz icu \
-" 
+"
 
 EXTRA_OECONF =  "--without-sound --with-crt-dir=${STAGING_LIBDIR} "
 
 PACKAGECONFIG ??= "${@base_contains('DISTRO_FEATURES', 'x11', 'x11', '', d)}"
 PACKAGECONFIG[x11] = "--with-x-toolkit=gtk,--without-x --without-dbus,${X11DEPENDS}"
 
-
 inherit autotools
 
 PACKAGES =+ "${PN}-el"
@@ -33,15 +32,13 @@ FILES_${PN} += "${datadir}/emacs ${datadir}/icons"
 
 FILES_${PN}-dbg += "${libexecdir}/emacs/*/*/.debug ${datadir}/emacs/*/*/.debug"
 
-TREEDIR = "${WORKDIR}/qemu-treedir"
-
 QEMUARCH= "${TARGET_ARCH}"
 QEMUARCH_i486 = "i386"
 QEMUARCH_i586 = "i386"
 QEMUARCH_i686 = "i386"
 
 # Large stack is required at least on x86_64 host, otherwise random segfaults appear:
-QEMU = "qemu-${QEMUARCH} ${QEMU_OPTIONS} -s 1048576 -L ${TREEDIR} "
+QEMU = "qemu-${QEMUARCH} ${QEMU_OPTIONS} -s 1048576 -L ${STAGING_DIR_HOST} "
 
 export LOGNAME = "$(whoami)"
 
@@ -52,88 +49,6 @@ do_compile_prepend() {
     ln -sf ../src/emacs lisp/emacs
     ln -sf ../src/emacs lib-src/emacs
     ln -sf ../src/emacs leim/emacs
-#copy STAGING_DIR_TARGET and libgcc_s.so* to WORKDIR/qemu-treedir #copied code from glibc-package.bbclass
-    treedir=${TREEDIR}
-    if [ -e $treedir ];then
-        rm -rf $treedir
-    fi
-    
-    mkdir -p $treedir/${base_libdir}
-
-    if [ -f ${TOOLCHAIN_PATH}/${TARGET_SYS}/${base_libdir}/libgcc_s.so ]; then
-        cp -pPR ${TOOLCHAIN_PATH}/${TARGET_SYS}/${base_libdir}/libgcc_s.so $treedir/${base_libdir}
-    fi
-    if [ -f ${TOOLCHAIN_PATH}/${TARGET_SYS}/${base_libdir}/libgcc_s.so.* ]; then
-        cp -pPR ${TOOLCHAIN_PATH}/${TARGET_SYS}/${base_libdir}/libgcc_s.so.* $treedir/${base_libdir}
-    fi
-    # stupid hack, but without it, it tries to use /usr/lib/libc.so from host and fails
-    # temacs: error while loading shared libraries: /usr/lib/libc.so: ELF file version does not match current one
-    if [ ! -f $treedir/${base_libdir}/libc.so ]; then
-        ln -s libc.so.6 $treedir/${base_libdir}/libc.so
-    fi
-
-    # copy only as much stuff as we need
-    # before: 5.5G   ../../qemu-treedir/
-    # after:   17M   ../../qemu-treedir/
-    cp -pPR \
-    ${STAGING_DIR_TARGET}/${base_libdir}/ld-* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libc.* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libc-* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libm-* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libm.* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libtinfo.so.* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libresolv* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libdl* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/librt* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libgcc_s.so.* \
-    ${STAGING_DIR_TARGET}/${base_libdir}/libpthread* $treedir/${base_libdir}/
-
-    if [ ! -z "${@base_contains('PACKAGECONFIG', 'x11', 'x11', '', d)}" ] ; then
-        echo "X11 build enabled"
-        # copy only as much stuff as we need
-        # before: 5.5G   ../../qemu-treedir/
-        # after:   86M   ../../qemu-treedir/
-        cp -pPR \
-        ${STAGING_DIR_TARGET}/${base_libdir}/libuuid.so.* \
-        ${STAGING_DIR_TARGET}/${base_libdir}/libz.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libICE.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libSM.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libatk-1.0.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libcairo.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libdbus-1.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libdbus-glib-1.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libexpat.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libffi.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libfontconfig.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libfreetype.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libgconf-2.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libgif.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libjpeg.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/liblzma.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libpixman-1.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libpng1*.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/librsvg-2.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libstdc++.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libtiff.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libxml2.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libcroco-0.6.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libharfbuzz.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libicule.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libicuuc.so.* \
-        ${STAGING_DIR_TARGET}/${libdir}/libicudata.so.* $treedir/${base_libdir}/
-
-        # X11 Xau Xcomposite Xcursor Xdamage Xdmcp Xext Xfixes Xft Xpm Xrandr Xrender
-        cp -pPR ${STAGING_DIR_TARGET}/${libdir}/libX*.so.* $treedir/${base_libdir}/
-
-        # gdk-x11 gdk_pixbuf gio glib gmodule gobject gthread gtk-x11
-        cp -pPR ${STAGING_DIR_TARGET}/${libdir}/libg*-2.0.so.* $treedir/${base_libdir}/
-
-        # pango pangocairo pangoft2
-        cp -pPR ${STAGING_DIR_TARGET}/${libdir}/libpango*-1.0.so.* $treedir/${base_libdir}/
-
-        # xcb-render xcb-shm xcb
-        cp -pPR ${STAGING_DIR_TARGET}/${libdir}/libxcb*.so.* $treedir/${base_libdir}/
-    fi
 }
 
 do_install_append() {
meta-oe/recipes-support/emacs/emacs_23.4.bb +0 -2
index a324828..36e8f0c 100644
@@ -2,8 +2,6 @@ require emacs.inc
 
 PR = "r4"
 
-PNBLACKLIST[emacs] ?= "qemu: uncaught target signal 11 (Segmentation fault) - core dumped"
-
 SRC_URI = "${GNU_MIRROR}/emacs/emacs-${PV}.tar.gz;name=tarball \
            file://use-qemu.patch \
            file://nostdlib-unwind.patch \
Signature · 1 line
2.1.0
#4 lore raw

Re: [meta-oe][PATCH 3/5] emacs: Un-blacklist, seems to work fine with new qemu

Quoted 7 lines · Dan McGregor

I've only tested the build with armv7 and x86, but the build doesn't segfault anymore. The last time this was tested was with qemu 1.5, we're now using 2.1.

While here, don't copy stuff from the sysroot into the qemu tree just use the sysroot itself.

I tried this patch, and I was able to build and install emacs package, on an armv7 board, using master branch as of today. emacs seems to be working fine under X11 here, however when I run it from a console without X11 (over ssh, or on the serial console), emacs would start, but I am not able to use it. keyboard is no working from within the application. ctrl+z isn't working as well, so I need to manually kill the process.

i know the emacs build process isn't straightforward, and maybe we aim to support only emacs + X11 with our recipe.. i am not sure..

have you tried to use emacs without X11?

thanks

#5 lore raw

Re: [meta-oe][PATCH 3/5] emacs: Un-blacklist, seems to work fine with new qemu

Quoted 18 lines · Nicolas Dechesne
Quoted 7 lines · Dan McGregor

I've only tested the build with armv7 and x86, but the build doesn't segfault anymore. The last time this was tested was with qemu 1.5, we're now using 2.1.

While here, don't copy stuff from the sysroot into the qemu tree just use the sysroot itself.

I tried this patch, and I was able to build and install emacs package, on an armv7 board, using master branch as of today. emacs seems to be working fine under X11 here, however when I run it from a console without X11 (over ssh, or on the serial console), emacs would start, but I am not able to use it. keyboard is no working from within the application. ctrl+z isn't working as well, so I need to manually kill the process.

Quoted 5 lines

i know the emacs build process isn't straightforward, and maybe we aim to support only emacs + X11 with our recipe.. i am not sure..

have you tried to use emacs without X11?

In my testing I explicitly disabled x11 in PACKAGECONFIG. I suspect there may be something broken in its X11 support, maybe I should remove x11 from the default PACKAGECONFIG set?

#6 lore raw

Re: [meta-oe][PATCH 3/5] emacs: Un-blacklist, seems to work fine with new qemu

Quoted 3 lines · Dan McGregor

In my testing I explicitly disabled x11 in PACKAGECONFIG. I suspect there may be something broken in its X11 support, maybe I should remove x11 from the default PACKAGECONFIG set?

indeed, without X11 emacs now works fine in non X11 environment. i am not sure what to say then... if i use debian or ubuntu on the same board, emacs works fine with or without X11, so we must be doing something wrong in the recipe..

#7 lore raw

Re: [meta-oe][PATCH 3/5] emacs: Un-blacklist, seems to work fine with new qemu

Quoted 2 lines · Nicolas Dechesne

On Thu, Feb 5, 2015 at 5:10 PM, Dan McGregor <[email protected]>

Quoted 8 lines · wrote:
Quoted 3 lines

In my testing I explicitly disabled x11 in PACKAGECONFIG. I suspect there may be something broken in its X11 support, maybe I should remove x11 from the default PACKAGECONFIG set?

indeed, without X11 emacs now works fine in non X11 environment. i am not sure what to say then... if i use debian or ubuntu on the same board, emacs works fine with or without X11, so we must be doing something wrong in the recipe..

I figured it out. There's a known bug in the emacs-23 branch that was distro patched in several other distros. Basically glib fixed a bug the emacs relied upon to function. I have a new patch I'll post later today that fixes this issue and some others identified in Martin's bitbake world run.

The proper fix is to import emacs 24, but that'll take longer. When I'm done I'll also post that.

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#8 lore raw

Re: [meta-oe][PATCH 3/5] emacs: Un-blacklist, seems to work fine with new qemu

Quoted 13 lines · Dan McGregor
Quoted 2 lines · Nicolas Dechesne

On Thu, Feb 5, 2015 at 5:10 PM, Dan McGregor <[email protected]>

Quoted 8 lines · wrote:
Quoted 3 lines

In my testing I explicitly disabled x11 in PACKAGECONFIG. I suspect there may be something broken in its X11 support, maybe I should remove x11 from the default PACKAGECONFIG set?

indeed, without X11 emacs now works fine in non X11 environment. i am not sure what to say then... if i use debian or ubuntu on the same board, emacs works fine with or without X11, so we must be doing something wrong in the recipe..

Quoted 5 lines

I figured it out. There's a known bug in the emacs-23 branch that was distro patched in several other distros. Basically glib fixed a bug the emacs relied upon to function. I have a new patch I'll post later today that fixes this issue and some others identified in Martin's bitbake world run.

Did you notice that qemu segfaulted in qemux86* world builds?

It looks like the original issue with pixman/pci is still there.

Quoted 13 lines

The proper fix is to import emacs 24, but that'll take longer. When I'm done I'll also post that.

Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#9 lore raw

PATCH 4/5 gdm: Only start in runlevel 5

In reply to Dan McGregor

From: Dan McGregor <[email protected]>

Runlevel 5 is traditionally graphical. If it starts in runlevel 2 or 3 systemd gets confused and adds it as a dependency of the multi-user target, not just the graphical target.

---
 meta-gnome/recipes-gnome/gdm/gdm/gdm       | 4 ++--
 meta-gnome/recipes-gnome/gdm/gdm_2.32.2.bb | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
meta-gnome/recipes-gnome/gdm/gdm/gdm +2 -2
index 43eae95..bb5b418 100755
@@ -4,8 +4,8 @@
 # Should-Start:      console-screen acpid dbus hal network-manager
 # Required-Start:    $local_fs $remote_fs
 # Required-Stop:     $local_fs $remote_fs
-# Default-Start:     2 3 4 5
-# Default-Stop:      0 1 6
+# Default-Start:     5
+# Default-Stop:      0 1 2 3 6
 # Short-Description: GNOME Display Manager
 # Description:       Debian init script for the GNOME Display Manager
 ### END INIT INFO
meta-gnome/recipes-gnome/gdm/gdm_2.32.2.bb +1 -1
index b2ae9ac..fcd51ff 100644
@@ -88,7 +88,7 @@ RCONFLICTS_${PN} += "${PN}-systemd"
 SYSTEMD_SERVICE_${PN} = "gdm.service"
 
 INITSCRIPT_NAME = "gdm"
-INITSCRIPT_PARAMS = "start 99 5 2 . stop 20 0 1 6 ."
+INITSCRIPT_PARAMS = "start 99 5 . stop 20 0 1 2 3 6 ."
 
 USERADD_PACKAGES = "${PN}"
 USERADD_PARAM_${PN} = "--system --no-create-home --home ${localstatedir}/lib/gdm --user-group gdm"
Signature · 1 line
2.1.0
#10 lore raw

PATCH 5/5 dracut: recipe cleanup

In reply to Dan McGregor

From: Dan McGregor <[email protected]>

Split out bash-completion data
Update RDEPENDS: getopt is util-linux-getopt now
Use distro_features_check to require systemd
Recommend busybox

---
 .../recipes-devtools/dracut/dracut_git.bb          | 25 ++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)
meta-initramfs/recipes-devtools/dracut/dracut_git.bb +19 -6
index ea55a4d..8ef0749 100644
@@ -4,6 +4,8 @@ DESCRIPTION = "Dracut is an event driven initramfs infrastructure. dracut (the t
 LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263"
 
+PACKAGES =+ "${PN}-bash-completion"
+
 PE = "1"
 PV = "038"
 
@@ -13,8 +15,10 @@ SRC_URI = "git://git.kernel.org/pub/scm/boot/dracut/dracut.git"
 
 S = "${WORKDIR}/git"
 
-do_configure() {
-    ./configure --prefix=${prefix} \
+inherit distro_features_check
+REQUIRED_DISTRO_FEATURES = "systemd"
+
+EXTRA_OECONF = "--prefix=${prefix} \
                 --libdir=${libdir} \
                 --datadir=${datadir} \
                 --sysconfdir=${sysconfdir} \
@@ -23,20 +27,29 @@ do_configure() {
                 --bindir=${bindir} \
                 --includedir=${includedir} \
                 --localstatedir=${localstatedir} \
+                --systemdsystemunitdir=${systemd_unitdir}/system"
+
+do_configure() {
+    ./configure ${EXTRA_OECONF}
 }
 
 do_install() {
     oe_runmake install DESTDIR=${D}
 }
 
-FILES_${PN} += "${datadir}/bash-completion \ 
-                ${libdir}/kernel \
+FILES_${PN}-bash-completion = "${datadir}/bash-completion"
+
+FILES_${PN} += " ${libdir}/kernel \
+                ${systemd_unitdir} \
                "
+CONFFILES_${PN} += "${sysconfdir}/dracut.conf"
+
+RDEPENDS_${PN} = "systemd findutils cpio util-linux-blkid util-linux-getopt util-linux bash ldd"
+RDEPENDS_${PN}-bash-completion = "bash-completion"
 
-# 'getopt' is in the util-linux main package
-RDEPENDS_${PN} = "systemd findutils cpio util-linux-blkid util-linux bash ldd"
 # This could be optimized a bit, but let's avoid non-booting systems :)
 RRECOMMENDS_${PN} = " \
                      kernel-modules \
+                     busybox \
                      coreutils \ 
                     "
Signature · 1 line
2.1.0