Skip to contentSkip to conversation

usb: gadget: fix sparse warnings

PATCH New Lad Prabhakar 1 participant 1 message Feb 5, 2015 USB

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: fix sparse warnings

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:

g_ffs.c:136:3: warning: symbol 'gfs_configurations' was not declared. Should it be static? g_ffs.c:281:16: warning: Using plain integer as NULL pointer

---
Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/usb/gadget/legacy/g_ffs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/usb/gadget/legacy/g_ffs.c +4 -2
index 06acfa5..b01b88e 100644
@@ -133,7 +133,9 @@ struct gfs_configuration {
 	struct usb_configuration c;
 	int (*eth)(struct usb_configuration *c);
 	int num;
-} gfs_configurations[] = {
+};
+
+static struct gfs_configuration gfs_configurations[] = {
 #ifdef CONFIG_USB_FUNCTIONFS_RNDIS
 	{
 		.eth		= bind_rndis_config,
@@ -278,7 +280,7 @@ static void *functionfs_acquire_dev(struct ffs_dev *dev)
 	if (!try_module_get(THIS_MODULE))
 		return ERR_PTR(-ENOENT);
 	
-	return 0;
+	return NULL;
 }
 
 static void functionfs_release_dev(struct ffs_dev *dev)
Signature · 1 line
1.9.1