Skip to contentSkip to conversation

usb: gadget: function/uvc_v4l2.c: fix sparse warnings

PATCH In review Lad Prabhakar 2 participants 2 messages Feb 5, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 usb: gadget: function/uvc_v4l2.c: fix sparse warnings

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:

uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared. Should it be static? uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was not declared. Should it be static?

---
 drivers/usb/gadget/function/uvc_v4l2.c | 1 +
 1 file changed, 1 insertion(+)
drivers/usb/gadget/function/uvc_v4l2.c +1 -0
index 5aad7fe..8b818fd 100644
@@ -27,6 +27,7 @@
 #include "uvc.h"
 #include "uvc_queue.h"
 #include "uvc_video.h"
+#include "uvc_v4l2.h"
 
 /* --------------------------------------------------------------------------
  * Requests handling
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw

Hi Prabhakar,

Thank you for the patch.

Quoted 9 lines · On Thursday 05 February 2015 13:16:26 Lad Prabhakar wrote:

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warnings:

uvc_v4l2.c:264:29: warning: symbol 'uvc_v4l2_ioctl_ops' was not declared. Should it be static? uvc_v4l2.c:355:29: warning: symbol 'uvc_v4l2_fops' was not declared. Should it be static?

Felipe, could you please take this in your tree ?

Quoted 16 lines
---
 drivers/usb/gadget/function/uvc_v4l2.c | 1 +
 1 file changed, 1 insertion(+)
(quoted diff) +0 -0

b/drivers/usb/gadget/function/uvc_v4l2.c index 5aad7fe..8b818fd 100644

drivers/usb/gadget/function/uvc_v4l2.c +1 -0
@@ -27,6 +27,7 @@
 #include "uvc.h"
 #include "uvc_queue.h"
 #include "uvc_video.h"
+#include "uvc_v4l2.h"
 
 /* -------------------------------------------------------------------------
 * Requests handling
Signature · 3 lines
Regards,

Laurent Pinchart