Skip to contentSkip to conversation

i40e: fix sparse warning

PATCH In review Lad Prabhakar 2 participants 2 messages Feb 5, 2015 – Feb 6, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 i40e: fix sparse warning

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

i40e_lan_hmc.c:911:24: warning: constant 0xFFFFFFFFFFFFFFFF is so big it is unsigned long

---
Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c +1 -1
index 4627588..f221ace 100644
@@ -908,7 +908,7 @@ static void i40e_write_qword(u8 *hmc_bits,
 	if (ce_info->width < 64)
 		mask = ((u64)1 << ce_info->width) - 1;
 	else
-		mask = 0xFFFFFFFFFFFFFFFF;
+		mask = 0xFFFFFFFFFFFFFFFFULL;
 
 	/* don't swizzle the bits until after the mask because the mask bits
 	 * will be in a different bit position on big endian machines
Signature · 1 line
1.9.1
#1 lore raw
Quoted 7 lines · Lad Prabhakar

From: "Lad, Prabhakar" <[email protected]>

this patch fixes following sparse warning:

i40e_lan_hmc.c:911:24: warning: constant 0xFFFFFFFFFFFFFFFF is so big it is unsigned long

Quoted 7 lines

---
Found this issue on linux-next (gcc version 4.8.2, sparse version 0.4.5-rc1)and applies on top linux-next.

 drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

I already have a fix in my queue to resolve this issue, so I am dropping your patch.