checkpatch: Try to avoid poor patch subject lines
Joe Perches
maintainerPATCH 1/1 checkpatch: Try to avoid poor patch subject lines
Naming the tool that found an issue in the subject line isn't
very useful. Emit a warning when a common tool (currently
checkpatch, sparse or smatch) is in the subject line.
Signed-off-by Joe Perches <[email protected]>
Inspired-by Al Viro <[email protected]>
Acked-by Dan Carpenter <[email protected]>
--- scripts/checkpatch.pl | 7 +++++++ 1 file changed, 7 insertions(+)
scripts/checkpatch.pl +7 -0
@@ -2170,6 +2170,13 @@ sub process { } } +# Check email subject for common tools that don't need to be mentioned + if ($in_header_lines && + $line =~ /^Subject:.*\b(?:checkpatch|sparse|smatch)\b[^:]/i) { + WARN("EMAIL_SUBJECT", + "A patch subject line should describe the change not the tool that found it\n" . $herecurr); + } + # Check for old stable address if ($line =~ /^\s*cc:\s*.*<?\bstable\@kernel\.org\b>?.*$/i) { ERROR("STABLE_ADDRESS",