image: Convert to use fdt_for_each_subnode macro
PATCH 1/1 image: Convert to use fdt_for_each_subnode macro
Signed-off-by Axel Lin <[email protected]>
--- common/image-fit.c | 4 +--- common/image-sig.c | 16 ++++------------ 2 files changed, 5 insertions(+), 15 deletions(-)
common/image-fit.c +1 -3
@@ -1010,9 +1010,7 @@ int fit_image_verify(const void *fit, int image_noffset) }/* Process all hash subnodes of the component image node */ -for (noffset =fdt_first_subnode (fit, image_noffset); - noffset >=0 ; - noffset =fdt_next_subnode (fit, noffset)) { +fdt_for_each_subnode (fit, noffset, image_noffset) {const char *name =fit_get_name (fit, noffset,NULL );/*
common/image-sig.c +4 -12
@@ -212,9 +212,7 @@ static int fit_image_verify_sig(const void *fit, int image_noffset,int ret;/* Process all hash subnodes of the component image node */ - for (noffset = fdt_first_subnode(fit, image_noffset); - noffset >= 0; - noffset = fdt_next_subnode(fit, noffset)) { + fdt_for_each_subnode(fit, noffset, image_noffset) { const char *name = fit_get_name(fit, noffset, NULL); if (!strncmp(name, FIT_SIG_NODENAME,
@@ -262,9 +260,7 @@ int fit_image_verify_required_sigs(const void *fit, int image_noffset,return 0 ; } -for (noffset =fdt_first_subnode (sig_blob, sig_node); - noffset >=0 ; - noffset =fdt_next_subnode (sig_blob, noffset)) { +fdt_for_each_subnode (sig_blob, noffset, sig_node) {const char *required;int ret;
@@ -397,9 +393,7 @@ static int fit_config_verify_sig(const void *fit, int conf_noffset,int ret;/* Process all hash subnodes of the component conf node */ - for (noffset = fdt_first_subnode(fit, conf_noffset); - noffset >= 0; - noffset = fdt_next_subnode(fit, noffset)) { + fdt_for_each_subnode(fit, noffset, conf_noffset) { const char *name = fit_get_name(fit, noffset, NULL); if (!strncmp(name, FIT_SIG_NODENAME,
@@ -444,9 +438,7 @@ int fit_config_verify_required_sigs(const void *fit, int conf_noffset,return 0 ; } -for (noffset =fdt_first_subnode (sig_blob, sig_node); - noffset >=0 ; - noffset =fdt_next_subnode (sig_blob, noffset)) { +fdt_for_each_subnode (sig_blob, noffset, sig_node) {const char *required;int ret;
Signature · 1 line
1.9.1
PATCH 1/1 image: Convert to use fdt_for_each_subnode macro
Hi Axel,
Quoted 1 line · Axel Lin
Signed-off-by Axel Lin <[email protected]>
Please can you add a commit message? The code looks fine.
Quoted 69 lines
--- common/image-fit.c | 4 +--- common/image-sig.c | 16 ++++------------ 2 files changed, 5 insertions(+), 15 deletions(-)common/image-fit.c +1
-3@@ -1010,9 +1010,7 @@ int fit_image_verify(const void *fit, int image_noffset) }/* Process all hash subnodes of the component image node */ -for (noffset =fdt_first_subnode (fit, image_noffset); - noffset >=0 ; - noffset =fdt_next_subnode (fit, noffset)) { +fdt_for_each_subnode (fit, noffset, image_noffset) {const char *name =fit_get_name (fit, noffset,NULL );/* common/image-sig.c +4
-13@@ -212,9 +212,7 @@ static int fit_image_verify_sig(const void *fit, int image_noffset,int ret;/* Process all hash subnodes of the component image node */ - for (noffset = fdt_first_subnode(fit, image_noffset); - noffset >= 0; - noffset = fdt_next_subnode(fit, noffset)) { + fdt_for_each_subnode(fit, noffset, image_noffset) { const char *name = fit_get_name(fit, noffset, NULL); if (!strncmp(name, FIT_SIG_NODENAME,@@ -262,9 +260,7 @@ int fit_image_verify_required_sigs(const void *fit, int image_noffset,return 0 ; } -for (noffset =fdt_first_subnode (sig_blob, sig_node); - noffset >=0 ; - noffset =fdt_next_subnode (sig_blob, noffset)) { +fdt_for_each_subnode (sig_blob, noffset, sig_node) {const char *required;int ret;@@ -397,9 +393,7 @@ static int fit_config_verify_sig(const void *fit, int conf_noffset,int ret;/* Process all hash subnodes of the component conf node */ - for (noffset = fdt_first_subnode(fit, conf_noffset); - noffset >= 0; - noffset = fdt_next_subnode(fit, noffset)) { + fdt_for_each_subnode(fit, noffset, conf_noffset) { const char *name = fit_get_name(fit, noffset, NULL); if (!strncmp(name, FIT_SIG_NODENAME,@@ -444,9 +438,7 @@ int fit_config_verify_required_sigs(const void *fit, int conf_noffset,return 0 ; } -for (noffset =fdt_first_subnode (sig_blob, sig_node); - noffset >=0 ; - noffset =fdt_next_subnode (sig_blob, noffset)) { +fdt_for_each_subnode (sig_blob, noffset, sig_node) {const char *required;int ret; --
Quoted 4 lines
1.9.1
Regards,
Simon