Skip to contentSkip to conversation

ARM: dts: exynos4412-trats2: set display clock correctly

PATCH Applied Inki Dae 3 participants 3 messages Feb 7, 2015 – May 21, 2015

Subsystems (2)
lore
Share & tools
lore

Inki Dae

author
#0 lore raw

PATCH 1/1 ARM: dts: exynos4412-trats2: set display clock correctly

This patch sets display clock correctly.

If Display clock isn't set correctly then you would find below messages and Display controller doesn't work correctly since a patch[1]

exynos-drm: No connectors reported connected with modes [drm] Cannot find any crtc or sizes - going 1024x768

[1] commit abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")

---
 arch/arm/boot/dts/exynos4412-trats2.dts |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/exynos4412-trats2.dts +1 -1
index 29231b4..1ec4d33 100644
@@ -691,7 +691,7 @@
 
 			display-timings {
 				timing-0 {
-					clock-frequency = <0>;
+					clock-frequency = <57153600>;
 					hactive = <720>;
 					vactive = <1280>;
 					hfront-porch = <5>;
Signature · 1 line
1.7.9.5
Reviewed-by Tested-by on v1 1/1
#1 lore raw

2015-02-07 19:49 GMT+09:00 Inki Dae <[email protected]>:

Quoted 9 lines

This patch sets display clock correctly.

If Display clock isn't set correctly then you would find below messages and Display controller doesn't work correctly since a patch[1]

exynos-drm: No connectors reported connected with modes [drm] Cannot find any crtc or sizes - going 1024x768

[1] commit abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")

Tested on Trats2 board.

Dear Kukjin,

Could you pull it to current fixes branch (this RC cycle)? The patch fixes display on Trats2 board. Without it (since abc0b1447d49) it won't be properly set up and device boots with blank screen and mentioned error message in logs.

I think this actually is a candidate for stable backporting (4.0+) because it fixes important functionality of device:

Fixes abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")

Best regards,
Krzysztof

Applied
#2 lore raw
Quoted 23 lines · Krzysztof Kozlowski

2015-02-07 19:49 GMT+09:00 Inki Dae <[email protected]>:

Quoted 9 lines

This patch sets display clock correctly.

If Display clock isn't set correctly then you would find below messages and Display controller doesn't work correctly since a patch[1]

exynos-drm: No connectors reported connected with modes [drm] Cannot find any crtc or sizes - going 1024x768

[1] commit abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")

Tested on Trats2 board.

Dear Kukjin,

Could you pull it to current fixes branch (this RC cycle)? The patch fixes display on Trats2 board. Without it (since abc0b1447d49) it won't be properly set up and device boots with blank screen and mentioned error message in logs.

Quoted 6 lines

I think this actually is a candidate for stable backporting (4.0+) because it fixes important functionality of device:

Fixes abc0b1447d49 ("drm: Perform basic sanity checks on probed modes")

Thanks, applied, and will be sent out in a day for v4.1-rc.

- Kukjin