Staging: fbtft: Fix Sparse warnings
Subsystems (2)
PATCH 1/1 Staging: fbtft: Fix Sparse warnings
Fix Sparse warnings for undeclared symbols
Signed-off-by Frederic Jacob <[email protected]>
--- drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/fbtft/fb_hx8340bn.c +1 -1
@@ -108,7 +108,7 @@ static int init_display(struct fbtft_par *par)return 0 ; } -void set_addr_win (struct fbtft_par *par,int xs,int ys,int xe,int ye) +static void set_addr_win (struct fbtft_par *par,int xs,int ys,int xe,int ye) {fbtft_par_dbg (DEBUG_SET_ADDR_WIN , par,"%s(xs=%d, ys=%d, xe=%d, ye=%d)\n" , __func__, xs, ys, xe, ye);
drivers/staging/fbtft/fbtft_device.c +2 -2
@@ -29,8 +29,8 @@#define MAX_GPIOS 32 -struct spi_device *spi_device; -struct platform_device *p_device; +static struct spi_device *spi_device; +static struct platform_device *p_device;static char *name;module_param (name, charp,0 );
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 1 line · Frederic Jacob
Fix Sparse warnings for undeclared symbols
Huh?
Quoted 25 lines
Signed-off-by Frederic Jacob <[email protected]>--- drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/staging/fbtft/fb_hx8340bn.c +1
-1@@ -108,7 +108,7 @@ static int init_display(struct fbtft_par *par)return 0 ; } -void set_addr_win (struct fbtft_par *par,int xs,int ys,int xe,int ye) +static void set_addr_win (struct fbtft_par *par,int xs,int ys,int xe,int ye) {fbtft_par_dbg (DEBUG_SET_ADDR_WIN , par,"%s(xs=%d, ys=%d, xe=%d, ye=%d)\n" , __func__, xs, ys, xe, ye);drivers/staging/fbtft/fbtft_device.c +0
-0
drivers/staging/fbtft/fbtft_device.c line 33
Quoted 7 lines
drivers/staging/fbtft/fbtft_device.c +2
-2@@ -29,8 +29,8 @@#define MAX_GPIOS 32 -struct spi_device *spi_device; -struct platform_device *p_device; +static struct spi_device *spi_device; +static struct platform_device *p_device;
These changes are making things static, not undeclared. Can you fix up your changelog entry to show the exact error you are fixing?
thanks,
greg k-h
PATCH v2 1/1 Staging: fbtft: Fix Sparse warnings
This fixes the folowing sparse warnings:
fb_hx8340bn.c:111:6: warning: symbol 'set_addr_win' was not declared. Should it be static? fbtft_device.c:32:19: warning: symbol 'spi_device' was not declared. Should it be static? fbtft_device.c:33:24: warning: symbol 'p_device' was not declared. Should it be static?
Signed-off-by Frederic Jacob <[email protected]>
---
Corrected the changelog to specify the fixed Sparse warnings.
drivers/staging/fbtft/fb_hx8340bn.c | 2 +- drivers/staging/fbtft/fbtft_device.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/staging/fbtft/fb_hx8340bn.c +1 -1
@@ -108,7 +108,7 @@ static int init_display(struct fbtft_par *par)return 0 ; } -void set_addr_win (struct fbtft_par *par,int xs,int ys,int xe,int ye) +static void set_addr_win (struct fbtft_par *par,int xs,int ys,int xe,int ye) {fbtft_par_dbg (DEBUG_SET_ADDR_WIN , par,"%s(xs=%d, ys=%d, xe=%d, ye=%d)\n" , __func__, xs, ys, xe, ye);
drivers/staging/fbtft/fbtft_device.c +2 -2
@@ -29,8 +29,8 @@#define MAX_GPIOS 32 -struct spi_device *spi_device; -struct platform_device *p_device; +static struct spi_device *spi_device; +static struct platform_device *p_device;static char *name;module_param (name, charp,0 );
Signature · 1 line
1.9.1