Skip to contentSkip to conversation

common: Remove invalid endianess conversion

PATCH Superseded Christian Eggers 3 participants 4 messages Feb 6, 2014 – Feb 21, 2014

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 common: Remove invalid endianess conversion

do_bootm_standanlone() calls ntohl(images->ep) which is wrong because endianess conversion has already been done:

do_bootm()
\-do_bootm_states()

  +-bootm_find_os()
  | \-images.ep = image_get_ep();
  |   \-uimage_to_cpu(hdr->ih_ep);

\-boot_selected_os()
\-do_bootm_standanlone()

Without this conversion the code works correctly at least on ARM9. Addtionally "appl" need not be dereferenced with the "*" operator.

---
Changes in v2:
- Improve description why the patch is required
- (appl)(...) --> appl(...)

Further remarks:
It seems there's no real difference between doing
"(*func_ptr)(args)" and "func_ptr(args)":

--- arm ---
kernel_entry = (void (*)(int, int, uint))images->ep; kernel_entry(0, machid, r2)
---/arm ---
--- powerpc ---
kernel = (void (*)(bd_t *, ulong, ulong, ulong, ulong, ulong, ulong))images->ep; (*kernel)(kbd, initrd_start, initrd_end, cmd_start, cmd_end, 0, 0); ---/powerpc ---

See also:
http://stackoverflow.com/questions/7518815/function-pointer-automatic-dereferencing

 common/cmd_bootm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/cmd_bootm.c +0 -0
index a59ee95..c507e1d 100644
@@ -514,8 +514,8 @@ static int do_bootm_standalone(int flag, int argc, char * 

const argv[],
setenv_hex("filesize", images->os.image_len); return 0;
}
- appl = (int (*)(int, char * const []))(ulong)ntohl(images->ep);
- (*appl)(argc, argv);
+ appl = (int (*)(int, char * const []))images->ep;
+ appl(argc, argv);
return 0;
}

Signature · 1 line
1.8.4.5
#1 lore raw

PATCH v2 1/1 common: Remove invalid endianess conversion

Dear Christian Eggers

Quoted 6 lines · Christian Eggers <ceggers <at> gmx.de> writes:

do_bootm_standanlone() calls ntohl(images->ep) which is wrong because endianess conversion has already been done:

do_bootm()
\-do_bootm_states()

Quoted 7 lines
  +-bootm_find_os()
  | \-images.ep = image_get_ep();
  |   \-uimage_to_cpu(hdr->ih_ep);

\-boot_selected_os()
\-do_bootm_standanlone()

Without this conversion the code works correctly at least on ARM9.

What is the endian of your ARM9 testbed?

I've tested the hello_world standalone image with and without your patch on a T5040 (BE). Behaviour of "bootm" does not change. So I am not sure what problem this patch fixes on PowerPC, if any. The patch might be applicable only to certain archs so you should test it on other archs as well (otherwise this patch might break them).

As a reference, the standalone image was created using the commandline:
../../tools/mkimage -A powerpc -O u-boot -T standalone -C none -a 0x10040000 -e 0x10040000 -n test -d hello_world.bin hello_world.img

(Yes, I modified CONFIG_STANDALONE_LOAD_ADDR for this test.) (Yes, hello_world was modified to not return for this test.)

And executed, on the board:
tftp 100000 hello_world.img
bootm 0x100000

Quoted 1 line

Addtionally "appl" need not be dereferenced with the "*" operator.

-snipped-

common/cmd_bootm.c

Quoted 7 lines
 common/cmd_bootm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/cmd_bootm.c +0 -0
index a59ee95..c507e1d 100644

Also, your patch does not apply on master.

-snipped-

All the best,
Rommel

#2 lore raw

PATCH v3 1/1 common: Remove invalid endianess conversion

do_bootm_standanlone() calls ntohl(images->ep) which is wrong because endianess conversion has already been done:

do_bootm()
\-do_bootm_states()

  +-bootm_find_os()
  | \-images.ep = image_get_ep();
  |   \-uimage_to_cpu(hdr->ih_ep);

\-boot_selected_os()
\-do_bootm_standanlone()

Without this conversion the code works correctly at least on AT91SAM9G45. On big endian systems there should be no difference after applying this patch because uimage_to_cpu(x) and ntohl(x) both expand to 'x'.

---
CC: sessyargc+u-boot at gmail.com

Changes in v3:
- refined patch description
- rebase to master
Changes in v2:
- Improve description why the patch is required
- (appl)(...) --> appl(...)

---
 common/cmd_bootm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
common/cmd_bootm.c +2 -2
index a59ee95..9751edc 100644
@@ -514,8 +514,8 @@ static int do_bootm_standalone(int flag, int argc, char * const argv[],
 		setenv_hex("filesize", images->os.image_len);
 		return 0;
 	}
-	appl = (int (*)(int, char * const []))(ulong)ntohl(images->ep);
-	(*appl)(argc, argv);
+	appl = (int (*)(int, char * const []))images->ep;
+	appl(argc, argv);
 	return 0;
 }
 
Signature · 1 line
1.8.4.5
#3 lore raw

PATCH v3 1/1 common: Remove invalid endianess conversion

Quoted 8 lines · Christian Eggers

do_bootm_standanlone() calls ntohl(images->ep) which is wrong because endianess conversion has already been done:

do_bootm()
\-do_bootm_states()

  +-bootm_find_os()
  | \-images.ep = image_get_ep();
  |   \-uimage_to_cpu(hdr->ih_ep);
Quoted 8 lines

\-boot_selected_os()
\-do_bootm_standanlone()

Without this conversion the code works correctly at least on AT91SAM9G45. On big endian systems there should be no difference after applying this patch because uimage_to_cpu(x) and ntohl(x) both expand to 'x'.

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140221/7e544cc5/attachment.pgp>