Skip to contentSkip to conversation

staging: lustre: fix coding style errors

PATCH In review Tal Shorer 2 participants 6 messages Feb 10, 2015 – Mar 2, 2015 Staging

lore
Share & tools
lore

Tal Shorer

author
#0 lore raw

PATCH v4 1/3 staging: lustre: fix coding style errors

fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
initialization of lnet_table_header (static pointer) to NULL

---
 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c +1 -1
index c539e37..7c259af 100644
@@ -65,7 +65,7 @@
 #include <asm/div64.h>
 #include "../tracefile.h"
 
-static struct ctl_table_header *lnet_table_header = NULL;
+static struct ctl_table_header *lnet_table_header;
 extern char lnet_upcall[1024];
 /**
  * The path of debug log dump upcall script.
Signature · 1 line
2.2.2
author
#1 lore raw

PATCH v4 2/3 staging: lustre: fix coding style errors

fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
initialization of min_watchdog_ratelimit (static int) to 0

for clarity's sake, the "= 0" is kept as part of a comment

---
 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c +1 -1
index 7c259af..c3d00e6 100644
@@ -165,7 +165,7 @@ static int proc_dobitmasks(struct ctl_table *table, int write,
 				 __proc_dobitmasks);
 }
 
-static int min_watchdog_ratelimit = 0;	  /* disable ratelimiting */
+static int min_watchdog_ratelimit; /* = 0 disable ratelimiting */
 static int max_watchdog_ratelimit = (24*60*60); /* limit to once per day */
 
 static int __proc_dump_kernel(void *data, int write,
Signature · 1 line
2.2.2
maintainer
#2 lore raw
Quoted 9 lines · Tal Shorer

fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
initialization of min_watchdog_ratelimit (static int) to 0

for clarity's sake, the "= 0" is kept as part of a comment

---
 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Same exact subject as 1/3, yet it does something different, which makes no sense :(

author
#3 lore raw

PATCH v4 3/3 staging: lustre: fix coding style errors fix the

In reply to Tal Shorer

following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
missing spaces around '='

---
 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c +1 -1
index c3d00e6..d70330f 100644
@@ -308,7 +308,7 @@ static int proc_console_backoff(struct ctl_table *table, int write,
 	dummy.proc_handler = &proc_dointvec;
 
 	if (!write) { /* read */
-		backoff= libcfs_console_backoff;
+		backoff = libcfs_console_backoff;
 		rc = proc_dointvec(&dummy, write, buffer, lenp, ppos);
 		return rc;
 	}
Signature · 1 line
2.2.2
maintainer
#4 lore raw

Re: [PATCH v4 3/3] staging: lustre: fix coding style errors fix the

Quoted 7 lines · Tal Shorer

following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
missing spaces around '='

---
 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Your subject doesn't make sense :(

maintainer
#5 lore raw
In reply to Tal Shorer
Quoted 7 lines · Tal Shorer

fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c:
initialization of lnet_table_header (static pointer) to NULL

---
 drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Please put the error you are fixing in the subject, otherwise we have no idea :(