Skip to contentSkip to conversation

openvswitch: Add missing initialization in validate_and_copy_set_tun()

PATCH Applied Geert Uytterhoeven 4 participants 4 messages Feb 11, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 openvswitch: Add missing initialization in validate_and_copy_set_tun()

net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function

If ipv4_tun_from_nlattr() returns a different positive value than OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and validate_and_copy_set_tun() may return an undefined value instead of a zero success indicator. Initialize err to zero to fix this.

Fixes 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
---
 net/openvswitch/flow_netlink.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/openvswitch/flow_netlink.c +1 -1
index 993281e6278dc829..3829328c5a7648bf 100644
@@ -1746,7 +1746,7 @@ static int validate_and_copy_set_tun(const struct nlattr *attr,
 	struct sw_flow_key key;
 	struct ovs_tunnel_info *tun_info;
 	struct nlattr *a;
-	int err, start, opts_type;
+	int err = 0, start, opts_type;
 
 	ovs_match_init(&match, &key, NULL);
 	opts_type = ipv4_tun_from_nlattr(nla_data(attr), &match, false, log);
Signature · 1 line
1.9.1
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Geert Uytterhoeven

net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function

If ipv4_tun_from_nlattr() returns a different positive value than OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and validate_and_copy_set_tun() may return an undefined value instead of a zero success indicator. Initialize err to zero to fix this.

Fixes 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
Acked-by on v1 1/1
#2 lore raw
In reply to Geert Uytterhoeven
Quoted 10 lines · Geert Uytterhoeven

net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function

If ipv4_tun_from_nlattr() returns a different positive value than OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and validate_and_copy_set_tun() may return an undefined value instead of a zero success indicator. Initialize err to zero to fix this.

Fixes 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")
maintainer Applied
#3 lore raw
In reply to Geert Uytterhoeven

From: Geert Uytterhoeven <[email protected]>
Date: Wed, 11 Feb 2015 11:23:38 +0100

Quoted 10 lines

net/openvswitch/flow_netlink.c: In function ‘validate_and_copy_set_tun’:
net/openvswitch/flow_netlink.c:1749: warning: ‘err’ may be used uninitialized in this function

If ipv4_tun_from_nlattr() returns a different positive value than OVS_TUNNEL_KEY_ATTR_GENEVE_OPTS, err will be uninitialized, and validate_and_copy_set_tun() may return an undefined value instead of a zero success indicator. Initialize err to zero to fix this.

Fixes 1dd144cf5b4b47e1 ("openvswitch: Support VXLAN Group Policy extension")

Applied. �τθΊ{.nΗ+‰·Ÿ�‰­†+%ŠΛ�±ιέΆ�Šw�Ί{.nΗ+‰·�Š{±ώG«ι�Š{ayΊΚ‡Ϊ™λ,j­’f£’·hšοκ�‘κηz_θ�(­ιšŽŠέ’j"ϊΆm§��Ύ«ώG«ι�’Έ?™¨θ­Ϊ&£ψ§~αΆiO•ζ¬z·švΨ^Άm§��Γ �Άμ�’Έ?–I�