Skip to contentSkip to conversation

SoC: Fix MAX98357A codec driver dependencies

PATCH Applied Guenter Roeck 2 participants 4 messages Feb 11, 2015 – Mar 5, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 SoC: Fix MAX98357A codec driver dependencies

The max98357a driver depends on GPIOLIB. This may cause the following build failure.

sound/soc/codecs/max98357a.c: In function 'max98357a_daiops_trigger':
sound/soc/codecs/max98357a.c:30:3: error: implicit declaration of function 'gpiod_set_value' sound/soc/codecs/max98357a.c: In function 'max98357a_codec_probe':
sound/soc/codecs/max98357a.c:55:2: error: implicit declaration of function 'devm_gpiod_get' sound/soc/codecs/max98357a.c:61:2: error: implicit declaration of function 'gpiod_direction_output'

Seen with mips:allmodconfig as well as various randconfig builds.

Fixes af5adf129369 ("ASoC: max98357a: Add MAX98357A codec driver")
Cc Kenneth Westfield <[email protected]>
---
 sound/soc/codecs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/Kconfig +1 -1
index 064e6c1..ea9f0e3 100644
@@ -69,7 +69,7 @@ config SND_SOC_ALL_CODECS
 	select SND_SOC_MAX98088 if I2C
 	select SND_SOC_MAX98090 if I2C
 	select SND_SOC_MAX98095 if I2C
-	select SND_SOC_MAX98357A
+	select SND_SOC_MAX98357A if GPIOLIB
 	select SND_SOC_MAX9850 if I2C
 	select SND_SOC_MAX9768 if I2C
 	select SND_SOC_MAX9877 if I2C
Signature · 1 line
2.1.0
maintainer Applied
#1 lore raw
Quoted 2 lines · Guenter Roeck

The max98357a driver depends on GPIOLIB. This may cause the following build failure.

Applied, thanks. Please use subject lines matching the style for the subsystem.

#2 lore raw
Quoted 7 lines · Mark Brown
Quoted 2 lines · Guenter Roeck

The max98357a driver depends on GPIOLIB. This may cause the following build failure.

Applied, thanks. Please use subject lines matching the style for the subsystem.

Hi Mark,

I notice that the problem this patch is trying to fix is still seen in the upstream kernel. Did the patch get lost after all, or is it still in the queue ?

Thanks,
Guenter

maintainer
#3 lore raw
Quoted 3 lines · Guenter Roeck

I notice that the problem this patch is trying to fix is still seen in the upstream kernel. Did the patch get lost after all, or is it still in the queue ?

My git tree is public...