mozjs: fix build failure due to missing dependency on libxt
PATCH 1/1 mozjs: fix build failure due to missing dependency on libxt
The failure intermittently shows up as follows:
ERROR: This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities. Rerun configure task after fixing this. The path was 'poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/build'
ERROR: Function failed: do_qa_configure
ERROR: Logfile of failure stored in: poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/temp/log.do_configure.8047
ERROR: Task 5 (poky/meta-openembedded/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb, do_configure) failed with exit code '1'
The configure log has:
configure:5494: checking for IceConnectionNumber in -lICE
configure:5513: x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse --sysroot=poky/build/tmp/sysroots/genericx86-64 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -Wl, -O1 -Wl,--hash-style=gnu -Wl,--as-needed -L/usr/lib conftest.c -lICE 1>&5
poky/build/tmp/sysroots/x86_64-linux/usr/libexec/x86_64-poky-linux/gcc/x86_64-poky-linux/4.9.1/ld: warning: library search path "/usr/lib" is unsafe for cross-compilation
Checking build/config/autoconf.mk we find:
X_CFLAGS = -I/usr/includeX_EXTRA_LIBS =X_LIBS = -L/usr/lib
Looking at the configure script, we see these invalid values are output when the autoconf test for X11 fails. That test fails in the following fashion:
configure:4768:27: fatal error: X11/Intrinsic.h: No such file or directory
This header in turn gets put in the sysroot by our build of libxt. So we get build fails whenever mozjs is built before libxt.
Since the package clearly has never been built in a no-X11 OE environment, we assume that all OE users to date are X11 users and hence simply add a dependency on libxt.
--- meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +1 -1
@@ -13,7 +13,7 @@ S = "${WORKDIR}/${PN}${PV}/js/src" inherit autotools pkgconfig perlnative -DEPENDS += "nspr zlib" +DEPENDS += "nspr zlib libxt" # nspr's package-config is ignored so set libs manually EXTRA_OECONF = " \
Signature · 1 line
2.2.1
Quoted 3 lines · Paul Gortmaker
Looking at the configure script, we see these invalid values are output when the autoconf test for X11 fails. That test fails in the following fashion:
...
Quoted 3 lines
Since the package clearly has never been built in a no-X11 OE environment, we assume that all OE users to date are X11 users and hence simply add a dependency on libxt.
I've run into this problem quite a while ago. My fix for this was a .bbappend file that passes --without-x to configure, since my target has no X11.
Quoted 4 lines · [Re: [OE-core] [PATCH] mozjs: fix build failure due to missing dependency on…
Quoted 3 lines · Paul Gortmaker
Looking at the configure script, we see these invalid values are output when the autoconf test for X11 fails. That test fails in the following fashion:
Quoted 9 lines
...
Quoted 3 lines
Since the package clearly has never been built in a no-X11 OE environment, we assume that all OE users to date are X11 users and hence simply add a dependency on libxt.
I've run into this problem quite a while ago. My fix for this was a .bbappend file that passes --without-x to configure, since my target has no X11.
Since it isn't a run time dependency, your local tweak to select a non-X build of the package should still give you that even with the libxt build dependency added. My point still stands that in its current state, the only successful builds have been X11-enabled ones; so my patch fixes the random build failures without changing the build output.
If we want to come at mozjs and enhance it at the same time to support non-x11 without the need for an append like you are using, we'd need to do something like:
DEPENDS_append = "${@bb.utils.contains('DISTRO_FEATURES','x11','libxt','',d)}"
...or perhaps:
EXTRA_OECONF_X = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"
I've not tested either of the above; I've just found them in existing recipes; I'll wait to see if the maintainers have any preference for one of the three possible solutions (the original and now the above two) as doing one of the above two now implies we are supporting non-x11 builds of it, when clearly we were not up to this point.
Paul.
Quoted 8 lines · Paul Gortmaker
DEPENDS_append= "${@bb.utils.contains('DISTRO_FEATURES','x11','libxt','',d)}"...or perhaps:
EXTRA_OECONF_X= "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"
I'm mostly surprised the mozjs has an X11 dependency at all, but yes something like respecting DISTRO_FEATURES to enable/disable X11 is sensible, unless the X11 support is so meaningless it might as well be disabled globally.
Also, wrong list - this is in meta-oe so should go to the openembedded-devel@ list.
Ross