ASoC: codec: Add missing deps/hdrs to MAX98357A
Subsystems (3)
PATCH 1/1 ASoC: codec: Add missing deps/hdrs to MAX98357A
From: Kenneth Westfield <[email protected]>
For the max98357a codec driver:
- Add missing build dependancy to GPIOLIB in Kconfig.
- Add header files to avoid implicit declarations and indirect inclusions.
- Remove use of DRV_NAME constant.
---
for topic/max98357a branch
sound/soc/codecs/Kconfig | 2 +- sound/soc/codecs/max98357a.c | 23 +++++++++++++++-------- 2 files changed, 16 insertions(+), 9 deletions(-)
sound/soc/codecs/Kconfig +1 -1
@@ -69,7 +69,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_MAX98088 if I2C select SND_SOC_MAX98090 if I2C select SND_SOC_MAX98095 if I2C - select SND_SOC_MAX98357A + select SND_SOC_MAX98357A if GPIOLIB select SND_SOC_MAX9850 if I2C select SND_SOC_MAX9768 if I2C select SND_SOC_MAX9877 if I2C
sound/soc/codecs/max98357a.c +15 -8
@@ -12,11 +12,19 @@* max98357a.c -- MAX98357A ALSA SoC Codec driver */ -#include <linux/module.h> +#include <linux/device.h> +#include <linux/err.h> #include <linux/gpio.h> +#include <linux/gpio/consumer.h> +#include <linux/kernel.h> +#include <linux/mod_devicetable.h> +#include <linux/module.h> +#include <linux/of.h> +#include <linux/platform_device.h> +#include <sound/pcm.h> #include <sound/soc.h> - -#define DRV_NAME "max98357a" +#include <sound/soc-dai.h> +#include <sound/soc-dapm.h> static int max98357a_daiops_trigger (struct snd_pcm_substream *substream,int cmd,struct snd_soc_dai *dai)
@@ -77,9 +85,9 @@ static struct snd_soc_dai_ops max98357a_dai_ops = { };static struct snd_soc_dai_driver max98357a_dai_driver = { - .name =DRV_NAME , + .name ="max98357a" , .playback = { - .stream_name =DRV_NAME "-playback" , + .stream_name ="max98357a-playback" , .formats =SNDRV_PCM_FMTBIT_S16 |SNDRV_PCM_FMTBIT_S24 |SNDRV_PCM_FMTBIT_S32 ,
@@ -117,7 +125,7 @@ static int max98357a_platform_remove(struct platform_device *pdev)#ifdef CONFIG_OF static const struct of_device_id max98357a_device_id[] = { - { .compatible ="maxim," DRV_NAME , }, + { .compatible ="maxim,max98357a" }, {} };MODULE_DEVICE_TABLE (of, max98357a_device_id);
@@ -125,7 +133,7 @@ MODULE_DEVICE_TABLE(of, max98357a_device_id);static struct platform_driver max98357a_platform_driver = { .driver = { - .name =DRV_NAME , + .name ="max98357a" , .of_match_table =of_match_ptr (max98357a_device_id), }, .probe = max98357a_platform_probe,
@@ -135,4 +143,3 @@ module_platform_driver(max98357a_platform_driver);MODULE_DESCRIPTION ("Maxim MAX98357A Codec Driver" );MODULE_LICENSE ("GPL v2" ); -MODULE_ALIAS ("platform:" DRV_NAME );
Signature · 2 lines
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
Mark Brown
maintainerQuoted 8 lines · Kenneth Westfield
From: Kenneth Westfield <[email protected]>
For the max98357a codec driver:
- Add missing build dependancy to GPIOLIB inKconfig.
- Add header files to avoid implicit declarations and indirect inclusions.
- Remove use ofDRV_NAMEconstant.
Several of these fixes have already been submitted by other people and applied and (as covered in SubmttingPatches) each you should submit one patch per logical change. Your changelog clearly identifies at least three different changes.