Skip to contentSkip to conversation

package/python: enable xml libraries

PATCH New Angelo Compagnucci 3 participants 7 messages Feb 13, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package/python: enable xml libraries

This patch adds the option to include xml libraries in python.

---
 package/python/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/python/Config.in +6 -0
index 87defad..682a324 100644
@@ -114,6 +114,12 @@ config BR2_PACKAGE_PYTHON_SQLITE
 	help
 	  SQLite database support
 
+config BR2_PACKAGE_PYTHON_XML
+	bool "xml module"
+	select BR2_PACKAGE_PYTHON_PYEXPAT
+	help
+	  Xml libraries for Python
+
 config BR2_PACKAGE_PYTHON_ZLIB
 	bool "zlib module"
 	select BR2_PACKAGE_ZLIB
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 package/python: enable xml libraries

Quoted 12 lines · Angelo Compagnucci

This patch adds the option to include xml libraries in python.

---
 package/python/Config.in | 6 ++++++
 1 file changed, 6 insertions(+)
package/python/Config.in +0 -0
index 87defad..682a324 100644

package/python/Config.in config BR2_PACKAGE_PYTHON_SQLITE · line 122

Quoted 9 lines
package/python/Config.in +6 -0
@@ -114,6 +114,12 @@ config BR2_PACKAGE_PYTHON_SQLITE
        help
          SQLite database support
 
+config BR2_PACKAGE_PYTHON_XML
+       bool "xml module"
+       select BR2_PACKAGE_PYTHON_PYEXPAT
+       help
+         Xml libraries for Python
+

What about this existing option?

config BR2_PACKAGE_PYTHON_PYEXPAT
select BR2_PACKAGE_EXPAT
bool "pyexpat"
help
pyexpat module for Python.

Yegor

Quoted 10 lines
package/python/Config.in +0 -1
 config BR2_PACKAGE_PYTHON_ZLIB
        bool "zlib module"
        select BR2_PACKAGE_ZLIB
--

1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot

#2 lore raw

PATCH 1/1 package/python: enable xml libraries

Hi Yegor,

2015-02-13 10:31 GMT+01:00 Yegor Yefremov <[email protected]>:

Quoted 10 lines

package/python/Config.in config BR2_PACKAGE_PYTHON_SQLITE · line 122

Quoted 7 lines
package/python/Config.in +6 -0
+config BR2_PACKAGE_PYTHON_XML
+       bool "xml module"
+       select BR2_PACKAGE_PYTHON_PYEXPAT
+       help
+         Xml libraries for Python
+

What about this existing option?

Quoted 7 lines

config BR2_PACKAGE_PYTHON_PYEXPAT
select BR2_PACKAGE_EXPAT
bool "pyexpat"
help
pyexpat module for Python.

Yegor

Whithout BR2_PACKAGE_PYTHON_XML there is no way you can know exactly when xml modules will be included or not without reading the configure script.
Inedeed, python xml modules are included by the configure script only if pyexpat is enabled.

BR2_PACKAGE_PYTHON_XML makes clear that if you want xml libraries, you should select pyexpat.

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#3 lore raw

PATCH 1/1 package/python: enable xml libraries

Quoted 22 lines · Angelo Compagnucci

Hi Yegor,

2015-02-13 10:31 GMT+01:00 Yegor Yefremov <[email protected]>:

Quoted 10 lines

package/python/Config.in config BR2_PACKAGE_PYTHON_SQLITE · line 122

Quoted 7 lines
package/python/Config.in +6 -0
+config BR2_PACKAGE_PYTHON_XML
+       bool "xml module"
+       select BR2_PACKAGE_PYTHON_PYEXPAT
+       help
+         Xml libraries for Python
+

What about this existing option?

Quoted 7 lines

config BR2_PACKAGE_PYTHON_PYEXPAT
select BR2_PACKAGE_EXPAT
bool "pyexpat"
help
pyexpat module for Python.

Yegor

Quoted 8 lines

Whithout BR2_PACKAGE_PYTHON_XML there is no way you can know exactly when xml modules will be included or not without reading the configure script.
Inedeed, python xml modules are included by the configure script only if pyexpat is enabled.

BR2_PACKAGE_PYTHON_XML makes clear that if you want xml libraries, you should select pyexpat.

Then the existing MACRO should be renamed. Though this implies renaming it in the existing packages, that have this option as dependency like jango etc.

Yegor

#4 lore raw

PATCH 1/1 package/python: enable xml libraries

Hi Yegor,

2015-02-13 10:47 GMT+01:00 Yegor Yefremov <[email protected]>:

Quoted 30 lines
Quoted 28 lines · Angelo Compagnucci

Hi Yegor,

2015-02-13 10:31 GMT+01:00 Yegor Yefremov <[email protected]>:

Quoted 10 lines

package/python/Config.in config BR2_PACKAGE_PYTHON_SQLITE · line 122

Quoted 7 lines
package/python/Config.in +6 -0
+config BR2_PACKAGE_PYTHON_XML
+       bool "xml module"
+       select BR2_PACKAGE_PYTHON_PYEXPAT
+       help
+         Xml libraries for Python
+

What about this existing option?

Quoted 7 lines

config BR2_PACKAGE_PYTHON_PYEXPAT
select BR2_PACKAGE_EXPAT
bool "pyexpat"
help
pyexpat module for Python.

Yegor

Whithout BR2_PACKAGE_PYTHON_XML there is no way you can know exactly when xml modules will be included or not without reading the configure script.
Inedeed, python xml modules are included by the configure script only if pyexpat is enabled.

Quoted 6 lines
Quoted 2 lines

BR2_PACKAGE_PYTHON_XML makes clear that if you want xml libraries, you should select pyexpat.

Then the existing MACRO should be renamed. Though this implies renaming it in the existing packages, that have this option as dependency like jango etc.

Yes, probably renaming BR2_PACKAGE_PYTHON_PYEXPAT to BR2_PACKAGE_PYTHON_XML makes sense, but it's an intrusive changing. I'm offering to volunteer, but I will wait for more comments.

Sincerely, Angelo

Quoted 2 lines

Yegor

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#5 lore raw

PATCH 1/1 package/python: enable xml libraries

Dear Angelo Compagnucci,

Quoted 7 lines · Angelo Compagnucci
Quoted 3 lines

Then the existing MACRO should be renamed. Though this implies renaming it in the existing packages, that have this option as dependency like jango etc.

Yes, probably renaming BR2_PACKAGE_PYTHON_PYEXPAT to BR2_PACKAGE_PYTHON_XML makes sense, but it's an intrusive changing. I'm offering to volunteer, but I will wait for more comments.

Indeed, the option name is a bit weird. But renaming options is also a bit annoying. What about only renaming the prompt of the option instead?

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH 1/1 package/python: enable xml libraries

Dear Thomas Petazzoni,

2015-02-13 17:59 GMT+01:00 Thomas Petazzoni
<[email protected]>:

Quoted 8 lines

Dear Angelo Compagnucci,

Quoted 4 lines · Angelo Compagnucci
Quoted 3 lines

Then the existing MACRO should be renamed. Though this implies renaming it in the existing packages, that have this option as dependency like jango etc.

Quoted 6 lines
Quoted 3 lines

Yes, probably renaming BR2_PACKAGE_PYTHON_PYEXPAT to BR2_PACKAGE_PYTHON_XML makes sense, but it's an intrusive changing. I'm offering to volunteer, but I will wait for more comments.

Indeed, the option name is a bit weird. But renaming options is also a bit annoying. What about only renaming the prompt of the option instead?

Why not! I think solves both problems and makes clear that BR2_PACKAGE_PYTHON_PYEXPAT enables all python xml modules. I'll prepare a patch in minutes!

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo