Skip to contentSkip to conversation

drm/radeon: Fix regression with suspend/resume

PATCH In review Ross Zwisler 4 participants 9 messages Feb 12, 2015 – Feb 22, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/radeon: Fix regression with suspend/resume

This patch reverts the changes made in this commit:

deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume. This is reproducible 100% of the time.

This patch applies cleanly to v3.19, and fixes the screen flicker issue on my system. Here is the hardware that I'm using (from lspci):

01:00.0 VGA compatible controller: Advanced Micro Devices, Inc. [AMD/ATI] Seymour [Radeon HD 6400M/7400M Series]

Cc Lauri Kasanen <[email protected]>
Cc "Christian König" <[email protected]>
Cc Dave Airlie <[email protected]>
Cc Alex Deucher <[email protected]>
---
 drivers/gpu/drm/radeon/radeon_object.c | 11 -----------
 1 file changed, 11 deletions(-)
drivers/gpu/drm/radeon/radeon_object.c +0 -11
index 86fc564..dea1baf 100644
@@ -173,17 +173,6 @@ void radeon_ttm_placement_from_domain(struct radeon_bo *rbo, u32 domain)
 		else
 			rbo->placements[i].lpfn = 0;
 	}
-
-	/*
-	 * Use two-ended allocation depending on the buffer size to
-	 * improve fragmentation quality.
-	 * 512kb was measured as the most optimal number.
-	 */
-	if (rbo->tbo.mem.size > 512 * 1024) {
-		for (i = 0; i < c; i++) {
-			rbo->placements[i].flags |= TTM_PL_FLAG_TOPDOWN;
-		}
-	}
 }
 
 int radeon_bo_create(struct radeon_device *rdev,
Signature · 1 line
1.9.3
#1 lore raw
Quoted 6 lines · Ross Zwisler

This patch reverts the changes made in this commit:

deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume.

What kind of flicker is it? E.g. does it only affect X or also console, does it flicker all the time or only when there is activity, what does it look like, ...

Signature · 6 lines
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel
#2 lore raw
Quoted 11 lines · Michel Dänzer
Quoted 6 lines · Ross Zwisler

This patch reverts the changes made in this commit:

deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume.

What kind of flicker is it? E.g. does it only affect X or also console, does it flicker all the time or only when there is activity, what does it look like, ...

It's kind of hard to describe it precisely, so I made a video. :)

http://youtu.be/ESm9SMnr0do

It only affects X, not the console, and it seems to go away if you log out back to the login manager (I'm using GDM on Fedora 20) and back into your window manager.

I've tested with OpenBox, Gnome and KDE, and it happens in all three, so it doesn't appear to be related to the window manager.

It does appear to flicker more if you move the mouse, but it still does flicker occasionally if you aren't doing anything.

#3 lore raw
Quoted 21 lines

-----Original Message-----
From: Ross Zwisler [mailto:[email protected]]
Sent: Friday, February 13, 2015 10:55 PM
To: Michel Dänzer
Cc: [email protected]; [email protected]; Deucher, Alexander; Dave Airlie; Lauri Kasanen; Koenig, Christian
Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume

Quoted 11 lines · Michel Dänzer
Quoted 6 lines · Ross Zwisler

This patch reverts the changes made in this commit:

deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume.

What kind of flicker is it? E.g. does it only affect X or also console, does it flicker all the time or only when there is activity, what does it look like, ...

Quoted 7 lines

It's kind of hard to describe it precisely, so I made a video. :)

http://youtu.be/ESm9SMnr0do

It only affects X, not the console, and it seems to go away if you log out back to the login manager (I'm using GDM on Fedora 20) and back into your window manager.

Does a VT switch or forcing a dpms cycle (sleep 5; xset dpms force off) also fix it? It doesn't look related to the patch in question at all. Is the flickering 100% reproducible or does it only happen periodically?

Alex

Quoted 6 lines

I've tested with OpenBox, Gnome and KDE, and it happens in all three, so it doesn't appear to be related to the window manager.

It does appear to flicker more if you move the mouse, but it still does flicker occasionally if you aren't doing anything.

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#4 lore raw
Quoted 25 lines · Alexander
Quoted 25 lines

-----Original Message-----
From: Ross Zwisler [mailto:[email protected]]
Sent: Friday, February 13, 2015 10:55 PM
To: Michel Dänzer
Cc: [email protected]; [email protected]; Deucher, Alexander; Dave Airlie; Lauri Kasanen; Koenig, Christian
Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume

Quoted 11 lines · Michel Dänzer
Quoted 6 lines · Ross Zwisler

This patch reverts the changes made in this commit:

deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume.

What kind of flicker is it? E.g. does it only affect X or also console, does it flicker all the time or only when there is activity, what does it look like, ...

It's kind of hard to describe it precisely, so I made a video. :)

http://youtu.be/ESm9SMnr0do

Quoted 8 lines
Quoted 3 lines

It only affects X, not the console, and it seems to go away if you log out back to the login manager (I'm using GDM on Fedora 20) and back into your window manager.

Does a VT switch or forcing a dpms cycle (sleep 5; xset dpms force off) also fix it? It doesn't look related to the patch in question at all. Is the flickering 100% reproducible or does it only happen periodically?

From kernels 3.14 or so (when the deadcb36f49b patch was introduced) till 3.18 it happened 100% of the time. With 3.19 it only seems to happen maybe 50% of the time, but is still very easily reproducible.

It's entirely possible that the patch isn't the root cause, but it just brought out a bug somewhere else. All I know is that I did a bisect, and with the commit before this the issue never happens, and after this commit it happens 100% of the time. :) Also, reverting that commit with 3.19 makes the issue go away.

Nope, "xset dpms force off" doesn't fix it. After the screen goes black and comes back, the flicker is still there.

- Ross

#5 lore raw
Quoted 27 lines · Ross Zwisler
Quoted 26 lines · Alexander
Quoted 26 lines

-----Original Message-----
From: Ross Zwisler [mailto:[email protected]]
Sent: Friday, February 13, 2015 10:55 PM
To: Michel Dänzer
Cc: [email protected]; [email protected]; Deucher, Alexander; Dave Airlie; Lauri Kasanen; Koenig, Christian
Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume

Quoted 10 lines · Michel Dänzer
Quoted 6 lines · Ross Zwisler

This patch reverts the changes made in this commit:

deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of the screen flickers after my laptop goes thorough a suspend and resume.

What kind of flicker is it? E.g. does it only affect X or also console, does it flicker all the time or only when there is activity, what does it look like, ...

It's kind of hard to describe it precisely, so I made a video. :)

http://youtu.be/ESm9SMnr0do

It only affects X, not the console, and it seems to go away if you log out back to the login manager (I'm using GDM on Fedora 20) and back into your window manager.

Quoted 7 lines
Quoted 4 lines

Does a VT switch or forcing a dpms cycle (sleep 5; xset dpms force off) also fix it? It doesn't look related to the patch in question at all. Is the flickering 100% reproducible or does it only happen periodically?

From kernels 3.14 or so (when the deadcb36f49b patch was introduced)
till 3.18 it happened 100% of the time. With 3.19 it only seems to happen maybe 50% of the time, but is still very easily reproducible.

Well, what the patch does is just changing where buffers are placed in memory. E.g. now we place the buffer at the end of memory as well.

So I can imagine at least three possible causes for the issues you see:
1. We haven't implemented all buffer placement restrictions correctly and without the patch everything just works fine by coincident.
2. Something is overwriting the buffer at it's new location. @Alex&Michel: Didn't we had a similar problem internally recently? Or was that just for APUs?
3. One of the memory chips on your hardware is faulty and without the patch the we just don't use the affected region (rather unlikely).

For testing could you try to limit the amount of VRAM used? E.g. give radeon.vramlimit=256 as kernel commandline to limit the VRAM to the first 256MB.

Regards,
Christian.

Quoted 10 lines

It's entirely possible that the patch isn't the root cause, but it just brought out a bug somewhere else. All I know is that I did a bisect, and with the commit before this the issue never happens, and after this commit it happens 100% of the time. :) Also, reverting that commit with 3.19 makes the issue go away.

Nope, "xset dpms force off" doesn't fix it. After the screen goes black and comes back, the flicker is still there.

Quoted 6 lines

- Ross

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#6 lore raw
Quoted 50 lines

-----Original Message-----
From: Christian König [mailto:[email protected]]
Sent: Wednesday, February 18, 2015 7:02 AM
To: Ross Zwisler; Deucher, Alexander
Cc: Michel Dänzer; [email protected]; dri- [email protected]; Dave Airlie; Lauri Kasanen; Koenig, Christian
Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume

Quoted 6 lines · Ross Zwisler
Quoted 5 lines · Alexander
Quoted 5 lines

-----Original Message-----
From: Ross Zwisler [mailto:[email protected]]
Sent: Friday, February 13, 2015 10:55 PM
To: Michel Dänzer
Cc: [email protected]; [email protected];

Deucher,

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines

Alexander; Dave Airlie; Lauri Kasanen; Koenig, Christian
Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume

Quoted 6 lines · Michel Dänzer
Quoted 5 lines · Ross Zwisler

This patch reverts the changes made in this commit:

deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2")

That patch caused a regression on my system where the bottom of

the

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 4 lines
Quoted 1 line

screen flickers after my laptop goes thorough a suspend and resume.

What kind of flicker is it? E.g. does it only affect X or also console, does it flicker all the time or only when there is activity, what does it look like, ...

It's kind of hard to describe it precisely, so I made a video. :)

http://youtu.be/ESm9SMnr0do

It only affects X, not the console, and it seems to go away if you log out back to the login manager (I'm using GDM on Fedora 20) and back

into

Quoted 8 lines
Quoted 5 lines
Quoted 1 line

your window manager.

Does a VT switch or forcing a dpms cycle (sleep 5; xset dpms force off) also fix it? It doesn't look related to the patch in question at all. Is the flickering 100% reproducible or does it only happen periodically?

From kernels 3.14 or so (when the deadcb36f49b patch was introduced)
till 3.18 it happened 100% of the time. With 3.19 it only seems to happen maybe 50% of the time, but is still very easily reproducible.

Well, what the patch does is just changing where buffers are placed in memory. E.g. now we place the buffer at the end of memory as well.

Quoted 6 lines

So I can imagine at least three possible causes for the issues you see:
1. We haven't implemented all buffer placement restrictions correctly and without the patch everything just works fine by coincident.
2. Something is overwriting the buffer at it's new location. @Alex&Michel: Didn't we had a similar problem internally recently? Or was that just for APUs?

I think that was just two engines trying to use the same memory location for writeback since we had not properly allocated a writeback slot.

What's odd to me is that the region is actively flickering, it looks almost like a display timing issue. I would expect static corruption unless something else is actively writing to the region.

Alex

Quoted 26 lines

3. One of the memory chips on your hardware is faulty and without the patch the we just don't use the affected region (rather unlikely).

For testing could you try to limit the amount of VRAM used? E.g. give radeon.vramlimit=256 as kernel commandline to limit the VRAM to the first 256MB.

Regards,
Christian.

Quoted 16 lines

It's entirely possible that the patch isn't the root cause, but it just brought out a bug somewhere else. All I know is that I did a bisect, and with the commit before this the issue never happens, and after this commit it happens 100% of the time. :) Also, reverting that commit with 3.19 makes the issue go away.

Nope, "xset dpms force off" doesn't fix it. After the screen goes black and comes back, the flicker is still there.

- Ross

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel

#7 lore raw
In reply to Christian König
Quoted 12 lines · Christian König

Well, what the patch does is just changing where buffers are placed in memory. E.g. now we place the buffer at the end of memory as well.

So I can imagine at least three possible causes for the issues you see:
1. We haven't implemented all buffer placement restrictions correctly and without the patch everything just works fine by coincident.
2. Something is overwriting the buffer at it's new location. @Alex&Michel: Didn't we had a similar problem internally recently? Or was that just for APUs?
3. One of the memory chips on your hardware is faulty and without the patch the we just don't use the affected region (rather unlikely).

Quoted 3 lines

For testing could you try to limit the amount of VRAM used? E.g. give radeon.vramlimit=256 as kernel commandline to limit the VRAM to the first 256MB.

Tried with the kernel parameter radeon.vramlimit=256, and it seemed to have the exact same behavior. The flicker was still there, same size, same frequency.

Thanks,
- Ross

#8 lore raw
Quoted 13 lines · Ross Zwisler
Quoted 12 lines · Christian König

Well, what the patch does is just changing where buffers are placed in memory. E.g. now we place the buffer at the end of memory as well.

So I can imagine at least three possible causes for the issues you see:
1. We haven't implemented all buffer placement restrictions correctly and without the patch everything just works fine by coincident.
2. Something is overwriting the buffer at it's new location. @Alex&Michel: Didn't we had a similar problem internally recently? Or was that just for APUs?
3. One of the memory chips on your hardware is faulty and without the patch the we just don't use the affected region (rather unlikely).

Quoted 6 lines
Quoted 3 lines

For testing could you try to limit the amount of VRAM used? E.g. give radeon.vramlimit=256 as kernel commandline to limit the VRAM to the first 256MB.

Tried with the kernel parameter radeon.vramlimit=256, and it seemed to have the exact same behavior. The flicker was still there, same size, same frequency.

Well how much memory does the card have in the first place? 256MB was just an example.

Please provide a complete dmesg output with that paramater.

Regards,
Christian.

Quoted 5 lines

Thanks,
- Ross

_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel