Skip to contentSkip to conversation

Bluetooth: Provide option to enable/disable debugfs information

PATCH Applied Marcel Holtmann 2 participants 2 messages Feb 14, 2015 – Feb 15, 2015

Subsystems (2)
lore
Share & tools
lore

Marcel Holtmann

author maintainer
#0 lore raw

PATCH 1/1 Bluetooth: Provide option to enable/disable debugfs information

The Bluetooth controllers can export extensive information about internal states via debugfs. This patch provides an option to choose if these information are provided or not.

For backwards compatibility with existing kernel configuration, this option defaults to yes.

---
 net/bluetooth/Kconfig       |  8 ++++++++
 net/bluetooth/Makefile      |  3 ++-
 net/bluetooth/hci_debugfs.h | 22 ++++++++++++++++++++++
 3 files changed, 32 insertions(+), 1 deletion(-)
net/bluetooth/Kconfig +8 -0
index 7de74635a110..b8c794b87523 100644
@@ -91,4 +91,12 @@ config BT_SELFTEST_SMP
 	  Run test cases for SMP cryptographic functionality, including both
 	  legacy SMP as well as the Secure Connections features.
 
+config BT_DEBUGFS
+	bool "Export Bluetooth internals in debugfs"
+	depends on BT && DEBUG_FS
+	default y
+	help
+	  Provide extensive information about internal Bluetooth states
+	  in debugfs.
+
 source "drivers/bluetooth/Kconfig"
net/bluetooth/Makefile +2 -1
index 8e96e3072266..5d608799717e 100644
@@ -13,8 +13,9 @@ bluetooth_6lowpan-y := 6lowpan.o
 
 bluetooth-y := af_bluetooth.o hci_core.o hci_conn.o hci_event.o mgmt.o \
 	hci_sock.o hci_sysfs.o l2cap_core.o l2cap_sock.o smp.o sco.o lib.o \
-	a2mp.o amp.o ecc.o hci_request.o hci_debugfs.o
+	a2mp.o amp.o ecc.o hci_request.o
 
+bluetooth-$(CONFIG_BT_DEBUGFS) += hci_debugfs.o
 bluetooth-$(CONFIG_BT_SELFTEST) += selftest.o
 
 subdir-ccflags-y += -D__CHECK_ENDIAN__
net/bluetooth/hci_debugfs.h +22 -0
index fb68efe083c5..4444dc8cedc2 100644
@@ -20,7 +20,29 @@
    SOFTWARE IS DISCLAIMED.
 */
 
+#if IS_ENABLED(CONFIG_BT_DEBUGFS)
+
 void hci_debugfs_create_common(struct hci_dev *hdev);
 void hci_debugfs_create_bredr(struct hci_dev *hdev);
 void hci_debugfs_create_le(struct hci_dev *hdev);
 void hci_debugfs_create_conn(struct hci_conn *conn);
+
+#else
+
+static inline void hci_debugfs_create_common(struct hci_dev *hdev)
+{
+}
+
+static inline void hci_debugfs_create_bredr(struct hci_dev *hdev)
+{
+}
+
+static inline void hci_debugfs_create_le(struct hci_dev *hdev)
+{
+}
+
+static inline void hci_debugfs_create_conn(struct hci_conn *conn)
+{
+}
+
+#endif
Signature · 1 line
2.1.0
#1 lore raw

Hi Marcel,

Quoted 7 lines · Marcel Holtmann

The Bluetooth controllers can export extensive information about internal states via debugfs. This patch provides an option to choose if these information are provided or not.

For backwards compatibility with existing kernel configuration, this option defaults to yes.

Quoted 6 lines
---
 net/bluetooth/Kconfig       |  8 ++++++++
 net/bluetooth/Makefile      |  3 ++-
 net/bluetooth/hci_debugfs.h | 22 ++++++++++++++++++++++
 3 files changed, 32 insertions(+), 1 deletion(-)

Applied to bluetooth-next. Thanks.

Johan