Skip to contentSkip to conversation

KVM: s390: Add MEMOP ioctls for reading/writing guest memory

PATCH In review Thomas Huth 2 participants 3 messages Feb 16, 2015 – Feb 19, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 KVM: s390: Add MEMOP ioctls for reading/writing guest memory

On s390, we've got to make sure to hold the IPTE lock while accessing logical memory. So let's add an ioctl for reading and writing logical memory to provide this feature for userspace, too.

---
 Documentation/virtual/kvm/api.txt |   45 +++++++++++++++++++++++
 arch/s390/kvm/gaccess.c           |   22 +++++++++++
 arch/s390/kvm/gaccess.h           |    2 +
 arch/s390/kvm/kvm-s390.c          |   70 +++++++++++++++++++++++++++++++++++++
 include/uapi/linux/kvm.h          |   20 ++++++++++
 5 files changed, 159 insertions(+), 0 deletions(-)
Documentation/virtual/kvm/api.txt +45 -0
index b112efc..8aa99f3 100644
@@ -2716,6 +2716,51 @@ The fields in each entry are defined as follows:
    eax, ebx, ecx, edx: the values returned by the cpuid instruction for
          this function/index combination
 
+4.89 KVM_S390_MEM_OP
+
+Capability: KVM_CAP_S390_MEM_OP
+Architectures: s390
+Type: vcpu ioctl
+Parameters: struct kvm_s390_mem_op (in)
+Returns: = 0 on success,
+         < 0 on generic error (e.g. -EFAULT or -ENOMEM),
+         > 0 if an exception occurred while walking the page tables
+
+Read or write data from/to the logical (virtual) memory of a VPCU.
+
+Parameters are specified via the following structure:
+
+struct kvm_s390_mem_op {
+	__u64 gaddr;		/* the guest address */
+	__u64 flags;		/* arch specific flags */
+	__u32 size;		/* amount of bytes */
+	__u32 op;		/* type of operation */
+	__u64 buf;		/* buffer in userspace */
+	__u8 reserved[32];	/* should be set to 0 */
+};
+
+The type of operation is specified in the "op" field. It is either
+KVM_S390_MEMOP_LOGICAL_READ for reading from logical memory space or
+KVM_S390_MEMOP_LOGICAL_WRITE for writing to logical memory space. The
+KVM_S390_MEMOP_F_CHECK_ONLY flag can be set in the "flags" field to check
+whether the corresponding memory access would create an access exception
+(without touching the data in the memory at the destination). In case an
+access exception occurred while walking the MMU tables of the guest, the
+ioctl returns a positive error number to indicate the type of exception.
+This exception is also raised directly at the corresponding VCPU if the
+flag KVM_S390_MEMOP_F_INJECT_EXCEPTION is set in the "flags" field.
+
+The start address of the memory region has to be specified in the "gaddr"
+field, and the length of the region in the "size" field. "buf" is the buffer
+supplied by the userspace application where the read data should be written
+to for KVM_S390_MEMOP_LOGICAL_READ, or where the data that should be written
+is stored for a KVM_S390_MEMOP_LOGICAL_WRITE. "buf" is unused and can be NULL
+when KVM_S390_MEMOP_F_CHECK_ONLY is specified.
+
+The "reserved" field is meant for future extensions. It is not used by
+KVM with the currently defined set of flags.
+
+
 5. The kvm_run structure
 ------------------------
 
arch/s390/kvm/gaccess.c +22 -0
index 267523c..70fd956 100644
@@ -697,6 +697,28 @@ int guest_translate_address(struct kvm_vcpu *vcpu, unsigned long gva,
 }
 
 /**
+ * check_gva_range - test a range of guest virtual addresses for accessibility
+ */
+int check_gva_range(struct kvm_vcpu *vcpu, unsigned long gva,
+		    unsigned long length, int is_write)
+{
+	unsigned long gpa;
+	unsigned long currlen;
+	int rc = 0;
+
+	ipte_lock(vcpu);
+	while (length > 0 && !rc) {
+		currlen = min(length, PAGE_SIZE - (gva % PAGE_SIZE));
+		rc = guest_translate_address(vcpu, gva, &gpa, is_write);
+		gva += currlen;
+		length -= currlen;
+	}
+	ipte_unlock(vcpu);
+
+	return rc;
+}
+
+/**
  * kvm_s390_check_low_addr_protection - check for low-address protection
  * @ga: Guest address
  *
arch/s390/kvm/gaccess.h +2 -0
index 0149cf1..268beb7 100644
@@ -157,6 +157,8 @@ int read_guest_lc(struct kvm_vcpu *vcpu, unsigned long gra, void *data,
 
 int guest_translate_address(struct kvm_vcpu *vcpu, unsigned long gva,
 			    unsigned long *gpa, int write);
+int check_gva_range(struct kvm_vcpu *vcpu, unsigned long gva,
+		    unsigned long length, int is_write);
 
 int access_guest(struct kvm_vcpu *vcpu, unsigned long ga, void *data,
 		 unsigned long len, int write);
arch/s390/kvm/kvm-s390.c +70 -0

94 lines not on this page · raw message

include/uapi/linux/kvm.h +20 -0
index 8055706..b82b583 100644
@@ -365,6 +365,23 @@ struct kvm_translation {
 	__u8  pad[5];
 };
 
+/* for KVM_S390_MEM_OP */
+struct kvm_s390_mem_op {
+	/* in */
+	__u64 gaddr;		/* the guest address */
+	__u64 flags;		/* arch specific flags */
+	__u32 size;		/* amount of bytes */
+	__u32 op;		/* type of operation */
+	__u64 buf;		/* buffer in userspace */
+	__u8 reserved[32];	/* should be set to 0 */
+};
+/* types for kvm_s390_mem_op->op */
+#define KVM_S390_MEMOP_LOGICAL_READ	0
+#define KVM_S390_MEMOP_LOGICAL_WRITE	1
+/* flags for kvm_s390_mem_op->flags */
+#define KVM_S390_MEMOP_F_CHECK_ONLY		(1ULL << 0)
+#define KVM_S390_MEMOP_F_INJECT_EXCEPTION	(1ULL << 1)
+
 /* for KVM_INTERRUPT */
 struct kvm_interrupt {
 	/* in */
@@ -760,6 +777,7 @@ struct kvm_ppc_smmu_info {
 #define KVM_CAP_PPC_ENABLE_HCALL 104
 #define KVM_CAP_CHECK_EXTENSION_VM 105
 #define KVM_CAP_S390_USER_SIGP 106
+#define KVM_CAP_S390_MEM_OP 107
 
 #ifdef KVM_CAP_IRQ_ROUTING
 
@@ -1135,6 +1153,8 @@ struct kvm_s390_ucas_mapping {
 #define KVM_ARM_VCPU_INIT	  _IOW(KVMIO,  0xae, struct kvm_vcpu_init)
 #define KVM_ARM_PREFERRED_TARGET  _IOR(KVMIO,  0xaf, struct kvm_vcpu_init)
 #define KVM_GET_REG_LIST	  _IOWR(KVMIO, 0xb0, struct kvm_reg_list)
+/* Available with KVM_CAP_S390_MEM_OP */
+#define KVM_S390_MEM_OP		  _IOW(KVMIO,  0xb1, struct kvm_s390_mem_op)
 
 #define KVM_DEV_ASSIGN_ENABLE_IOMMU	(1 << 0)
 #define KVM_DEV_ASSIGN_PCI_2_3		(1 << 1)
Signature · 1 line
1.7.1
#1 lore raw
Quoted 4 lines · On Mon, 16 Feb 2015 13:16:41 +0100 Thomas Huth <[email protected]> wrote:

On s390, we've got to make sure to hold the IPTE lock while accessing logical memory. So let's add an ioctl for reading and writing logical memory to provide this feature for userspace, too.

Quoted 8 lines
---
 Documentation/virtual/kvm/api.txt |   45 +++++++++++++++++++++++
 arch/s390/kvm/gaccess.c           |   22 +++++++++++
 arch/s390/kvm/gaccess.h           |    2 +
 arch/s390/kvm/kvm-s390.c          |   70 +++++++++++++++++++++++++++++++++++++
 include/uapi/linux/kvm.h          |   20 ++++++++++
 5 files changed, 159 insertions(+), 0 deletions(-)

Looks good, except for one minor thing:

Quoted 4 lines
arch/s390/kvm/kvm-s390.c +4 -0
+static long kvm_s390_guest_mem_op(struct kvm_vcpu *vcpu,
+				  struct kvm_s390_mem_op *mop)
+{
+	void __user *uaddr = (void __user *)mop->buf;

arch/s390/kvm/kvm-s390.c static int kvm_vcpu_ioctl_enable_cap(struct kvm_vcpu *vcpu, · line 2125

Quoted 10 lines
arch/s390/kvm/kvm-s390.c +10 -0
+	void *tmpbuf = NULL;
+	int r, srcu_idx;
+	const u64 supported_flags = KVM_S390_MEMOP_F_INJECT_EXCEPTION
+				    | KVM_S390_MEMOP_F_CHECK_ONLY;
+
+	if (mop->flags & ~supported_flags)
+		return -EINVAL;
+
+	if (mop->size > 16 * PAGE_SIZE)
+		return -E2BIG;

Do you want to document this limit? Or make it discoverable by having the capability check return the number of pages?

#2 lore raw
Quoted 27 lines · On Thu, 19 Feb 2015 10:47:29 +0100 Cornelia Huck <[email protected]>…
Quoted 4 lines · On Mon, 16 Feb 2015 13:16:41 +0100 Thomas Huth <[email protected]> wrote:

On s390, we've got to make sure to hold the IPTE lock while accessing logical memory. So let's add an ioctl for reading and writing logical memory to provide this feature for userspace, too.

Quoted 8 lines
---
 Documentation/virtual/kvm/api.txt |   45 +++++++++++++++++++++++
 arch/s390/kvm/gaccess.c           |   22 +++++++++++
 arch/s390/kvm/gaccess.h           |    2 +
 arch/s390/kvm/kvm-s390.c          |   70 +++++++++++++++++++++++++++++++++++++
 include/uapi/linux/kvm.h          |   20 ++++++++++
 5 files changed, 159 insertions(+), 0 deletions(-)

Looks good, except for one minor thing:

Quoted 9 lines
arch/s390/kvm/kvm-s390.c +9 -0
+static long kvm_s390_guest_mem_op(struct kvm_vcpu *vcpu,
+				  struct kvm_s390_mem_op *mop)
+{
+	void __user *uaddr = (void __user *)mop->buf;
+	void *tmpbuf = NULL;
+	int r, srcu_idx;
+	const u64 supported_flags = KVM_S390_MEMOP_F_INJECT_EXCEPTION
+				    | KVM_S390_MEMOP_F_CHECK_ONLY;
+
Quoted 8 lines

arch/s390/kvm/kvm-s390.c static int kvm_vcpu_ioctl_enable_cap(struct kvm_vcpu *vcpu, · line 2125

Quoted 5 lines
arch/s390/kvm/kvm-s390.c +5 -0
+	if (mop->flags & ~supported_flags)
+		return -EINVAL;
+
+	if (mop->size > 16 * PAGE_SIZE)
+		return -E2BIG;

Do you want to document this limit? Or make it discoverable by having the capability check return the number of pages?

I like the idea with the capability ... I think I'll add that feature.

Thomas